Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84953/?format=api
{ "id": 84953, "url": "https://patches.dpdk.org/api/patches/84953/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201210150648.8784-8-talshn@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201210150648.8784-8-talshn@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201210150648.8784-8-talshn@nvidia.com", "date": "2020-12-10T15:06:22", "name": "[v2,07/33] net/mlx5: do not define static_assert in Windows", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d384eb5f7e50dcb73996ab7149d6ae05c57bd1a5", "submitter": { "id": 1893, "url": "https://patches.dpdk.org/api/people/1893/?format=api", "name": "Tal Shnaiderman", "email": "talshn@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201210150648.8784-8-talshn@nvidia.com/mbox/", "series": [ { "id": 14240, "url": "https://patches.dpdk.org/api/series/14240/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14240", "date": "2020-12-10T15:06:17", "name": "mlx5 Windows support - part #5", "version": 2, "mbox": "https://patches.dpdk.org/series/14240/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84953/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84953/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE94CA04DB;\n\tThu, 10 Dec 2020 16:08:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F356AC982;\n\tThu, 10 Dec 2020 16:07:54 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id C271AC950\n for <dev@dpdk.org>; Thu, 10 Dec 2020 16:07:47 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n talshn@nvidia.com) with SMTP; 10 Dec 2020 17:07:45 +0200", "from nvidia.com (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BAF7h8x007994;\n Thu, 10 Dec 2020 17:07:44 +0200" ], "From": "Tal Shnaiderman <talshn@nvidia.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, matan@nvidia.com, rasland@nvidia.com,\n ophirmu@nvidia.com", "Date": "Thu, 10 Dec 2020 17:06:22 +0200", "Message-Id": "<20201210150648.8784-8-talshn@nvidia.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "In-Reply-To": "<20201210150648.8784-1-talshn@nvidia.com>", "References": "<20201027232335.31427-2-ophirmu@nvidia.com>\n <20201210150648.8784-1-talshn@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v2 07/33] net/mlx5: do not define static_assert\n\tin Windows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ophir Munk <ophirmu@nvidia.com>\n\nIn Linux 'static_assert' is defined in file mlx5_defs.h:\n\n #ifndef HAVE_STATIC_ASSERT\n #define static_assert _Static_assert\n #endif\n\nThe same definition can originate from Linux file /usr/include/assert.h.\n\nIn Windows static_assert is used while _Static_assert is unknown.\nTherefore update the definition condition to be:\n\n #if !defined(HAVE_STATIC_ASSERT) && !defined(RTE_EXEC_ENV_WINDOWS)\n #define static_assert _Static_assert\n #endif\n\nSigned-off-by: Ophir Munk <ophirmu@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_defs.h | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h\nindex aa55db3750..85a0979653 100644\n--- a/drivers/net/mlx5/mlx5_defs.h\n+++ b/drivers/net/mlx5/mlx5_defs.h\n@@ -199,8 +199,11 @@\n /* Maximum number of shared actions supported by rte_flow */\n #define MLX5_MAX_SHARED_ACTIONS 2\n \n-/* Definition of static_assert found in /usr/include/assert.h */\n-#ifndef HAVE_STATIC_ASSERT\n+/*\n+ * Linux definition of static_assert is found in /usr/include/assert.h.\n+ * Windows does not require a redefinition.\n+ */\n+#if !defined(HAVE_STATIC_ASSERT) && !defined(RTE_EXEC_ENV_WINDOWS)\n #define static_assert _Static_assert\n #endif\n \n", "prefixes": [ "v2", "07/33" ] }