Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84833/?format=api
{ "id": 84833, "url": "https://patches.dpdk.org/api/patches/84833/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201208201134.47844-14-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201208201134.47844-14-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201208201134.47844-14-ajit.khaparde@broadcom.com", "date": "2020-12-08T20:11:30", "name": "[13/17] net/bnxt: fix vnic RSS configure function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "57b2ca21bf2e7e7d63a41ee78e8519d149e447bf", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201208201134.47844-14-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 14211, "url": "https://patches.dpdk.org/api/series/14211/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14211", "date": "2020-12-08T20:11:17", "name": "fixes and refactoring changes for bnxt", "version": 1, "mbox": "https://patches.dpdk.org/series/14211/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84833/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84833/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B8F0BA09E9;\n\tTue, 8 Dec 2020 21:16:08 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4B9A1CA32;\n\tTue, 8 Dec 2020 21:12:06 +0100 (CET)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id D770BC950\n for <dev@dpdk.org>; Tue, 8 Dec 2020 21:11:57 +0100 (CET)", "by mail-pg1-f193.google.com with SMTP id m9so13206564pgb.4\n for <dev@dpdk.org>; Tue, 08 Dec 2020 12:11:57 -0800 (PST)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id x10sm5729187pfc.157.2020.12.08.12.11.55\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 08 Dec 2020 12:11:55 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=sZAcDBgkksUSYauHI9bABm7FFGXtOiUqMDjQSbk7hE4=;\n b=U5fHjhw/s7mes6oXQz/TB5WnM3/JsoWrMpIYA25N/1Qmb1spWnLdihL5XZbicQxCwC\n +wp5BpU/CAtu20xOVUQazIEk8O9cyE/ieMJUSbK0tSU62bAYsPwXTZj61ALLcEAJfzNG\n hVG+lC43A8OSvOn1YmwjorlJ7g8+ovJ89qem0=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=sZAcDBgkksUSYauHI9bABm7FFGXtOiUqMDjQSbk7hE4=;\n b=KQ8O18BqkJxQUTe/ziY84DpdAXdPNeymG7lQdGR8bxzUd5rLMP2DileYs+BkuUk1RN\n 1C309EeR5QZO6XRpn6lkKBK41J2rlctXf/6Q+RCL8UymXORtRUUCYoUKvOk5jlA3q/y1\n hDPXtUCMNOaXfnU14s6sS14CGJe6dD+YNxjNwSv/Crlt+ha3+1Z1ovDq3rolkCM5V9ml\n Wx4Ndpd9HAlADTn8OFLU/NjS9zj2hJ+cVwwXJPY/skprsHdG5Uh7BXz6m1ZCcEq0DXcF\n oQrKWIxxpFtHckYf07oyEf9PYmXUcc/K8d/LpY0a35E1Kqa5yKD/rqYzfcsTscChOiah\n KHUw==", "X-Gm-Message-State": "AOAM530iIyJyNTYWEin+XD7mA9+rQpxC2XdkOR+FmREhJk20YbJUjn0I\n 2uRr0MI8eOt1cTsskzp6rxdAgborEd9mj3LGhfSyiJcebpahuyzuQ1EWlLt3I6vhN3SWZ5EpVYA\n lE2VKK5oe3f35z6PA5oXdE11fyn3P4wYEKAOWb/zQlM/UmIfPjIrANEOjxzt9QMaDeA==", "X-Google-Smtp-Source": "\n ABdhPJx0I4DJVXWH7HopHLj8U69ukzWaU9el/W0ZT49dbOT3ZKq/QbqXSeWtgys2PID/6sdFkgMtcw==", "X-Received": "by 2002:a62:1409:0:b029:19e:14d1:efb0 with SMTP id\n 9-20020a6214090000b029019e14d1efb0mr9681379pfu.14.1607458316661;\n Tue, 08 Dec 2020 12:11:56 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, stable@dpdk.org,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Tue, 8 Dec 2020 12:11:30 -0800", "Message-Id": "<20201208201134.47844-14-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "References": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"US-ASCII\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] [PATCH 13/17] net/bnxt: fix vnic RSS configure function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\n1. moved invalid VNIC id check to the beginning of the function.\n2. removed a duplicate check which avoids unnecessary code indentation.\n\nFixes: 49d0709b257fc (\"net/bnxt: delete and flush L2 filters cleanly\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 42 +++++++++++++++++-------------------\n 1 file changed, 20 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 6f5402070..cee2656c1 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -4896,37 +4896,35 @@ int bnxt_vnic_rss_configure(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n {\n \tunsigned int rss_idx, fw_idx, i;\n \n+\tif (vnic->fw_vnic_id == INVALID_HW_RING_ID)\n+\t\treturn 0;\n+\n \tif (!(vnic->rss_table && vnic->hash_type))\n \t\treturn 0;\n \n \tif (BNXT_CHIP_P5(bp))\n \t\treturn bnxt_vnic_rss_configure_p5(bp, vnic);\n \n-\tif (vnic->fw_vnic_id == INVALID_HW_RING_ID)\n-\t\treturn 0;\n-\n-\tif (vnic->rss_table && vnic->hash_type) {\n-\t\t/*\n-\t\t * Fill the RSS hash & redirection table with\n-\t\t * ring group ids for all VNICs\n-\t\t */\n-\t\tfor (rss_idx = 0, fw_idx = 0; rss_idx < HW_HASH_INDEX_SIZE;\n-\t\t\trss_idx++, fw_idx++) {\n-\t\t\tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n-\t\t\t\tfw_idx %= bp->rx_cp_nr_rings;\n-\t\t\t\tif (vnic->fw_grp_ids[fw_idx] !=\n-\t\t\t\t INVALID_HW_RING_ID)\n-\t\t\t\t\tbreak;\n-\t\t\t\tfw_idx++;\n-\t\t\t}\n-\t\t\tif (i == bp->rx_cp_nr_rings)\n-\t\t\t\treturn 0;\n-\t\t\tvnic->rss_table[rss_idx] = vnic->fw_grp_ids[fw_idx];\n+\t/*\n+\t * Fill the RSS hash & redirection table with\n+\t * ring group ids for all VNICs\n+\t */\n+\tfor (rss_idx = 0, fw_idx = 0; rss_idx < HW_HASH_INDEX_SIZE;\n+\t rss_idx++, fw_idx++) {\n+\t\tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n+\t\t\tfw_idx %= bp->rx_cp_nr_rings;\n+\t\t\tif (vnic->fw_grp_ids[fw_idx] != INVALID_HW_RING_ID)\n+\t\t\t\tbreak;\n+\t\t\tfw_idx++;\n \t\t}\n-\t\treturn bnxt_hwrm_vnic_rss_cfg(bp, vnic);\n+\n+\t\tif (i == bp->rx_cp_nr_rings)\n+\t\t\treturn 0;\n+\n+\t\tvnic->rss_table[rss_idx] = vnic->fw_grp_ids[fw_idx];\n \t}\n \n-\treturn 0;\n+\treturn bnxt_hwrm_vnic_rss_cfg(bp, vnic);\n }\n \n static void bnxt_hwrm_set_coal_params(struct bnxt_coal *hw_coal,\n", "prefixes": [ "13/17" ] }