Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84765/?format=api
{ "id": 84765, "url": "https://patches.dpdk.org/api/patches/84765/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201204201646.51746-9-aboyer@pensando.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201204201646.51746-9-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20201204201646.51746-9-aboyer@pensando.io", "date": "2020-12-04T20:16:45", "name": "[v3,8/9] net/ionic: minor refactorings and helper variables", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9c55925978060875c23ba3fd3605dc9746a20b4e", "submitter": { "id": 2036, "url": "https://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201204201646.51746-9-aboyer@pensando.io/mbox/", "series": [ { "id": 14190, "url": "https://patches.dpdk.org/api/series/14190/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14190", "date": "2020-12-04T20:16:37", "name": "net/ionic: minor updates and documentation", "version": 3, "mbox": "https://patches.dpdk.org/series/14190/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84765/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84765/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 580C2A09E3;\n\tFri, 4 Dec 2020 21:20:04 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 05B0ACA1C;\n\tFri, 4 Dec 2020 21:17:54 +0100 (CET)", "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 43075CA14\n for <dev@dpdk.org>; Fri, 4 Dec 2020 21:17:52 +0100 (CET)", "by mail-pl1-f194.google.com with SMTP id x4so3754906pln.8\n for <dev@dpdk.org>; Fri, 04 Dec 2020 12:17:52 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id z20sm2911805pjq.16.2020.12.04.12.17.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 04 Dec 2020 12:17:49 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :in-reply-to:references;\n bh=ijNAd61IGYcSjRFUl2+upCJylzXS4UZOJGcg0UHpk00=;\n b=Q9eEBuh+v3cDLIuEAHp0mjIwR/0qgDyF/B4JIROtAm4qytgyXFzdVdK8LWDuEHRgzs\n iPO4uYeeA1pay75r9lrHXLPoWbSaQ68P1O2Lz1nIjaAuTCAvvM1GzNRRX+TCN+P55CDq\n sVNElAGlh2nhoGDY3wItdPrH6zmg2Mv7SOJXB3bM8fzOlv9Fo+djkZpNHK5+kzDEdQwf\n 108+60MNg8dl/3lUrxNN/Iu3G1vCO7xKhJ7bJ1QUdXiG0No0+mtExXj5sl9A917THIz/\n 8yvTvQg/0zfwrOhaT5o/W/1bJ96poWZjBLy3splzwB3SzSeH3bNzhCQq0jwSMbROk9q1\n GFoA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:in-reply-to:references;\n bh=ijNAd61IGYcSjRFUl2+upCJylzXS4UZOJGcg0UHpk00=;\n b=rd1hwzJKu+k1XZW0hyeYVgKnK3L0F3gCviGQYXitVhEQXrBeOwYRguvRd4t2lbZfJb\n DAovTwEGSafuZMXzZD2OC3Xju08qqUufqCRVzjYaJzdnN5jGr30rQeopAQ2rV7cfOqmT\n 7DFrb0CectZsDyqZGp/iwQVqU72KoMQsME1CLL1S+PiZalXPE9WWjjWG+JscfMz7g+j+\n JE0AHLb/nrwrR/WdgmmpZNFAsh60oz9qdsPXqLlgmA6C+zBoqpmGivuwc15fUdC7+Lju\n N3SMimgqpyuhk8irS8trzfwyJbmC3uLDWYShtGDnyj8AUVPvEj8nsKYQC7hoM/5GoV7c\n 81/A==", "X-Gm-Message-State": "AOAM531bPvSIvEWDM6T37TmsILJCB6TsLwLqLOx6AuT4+YwkNKmw/alA\n JqhUFBC+8hSHfHGoj/iiPvH0GRQGYiupoA==", "X-Google-Smtp-Source": "\n ABdhPJxlSqkgzK+QnjAD1ITDVN8KKTw42Xnj5ESTDj/cvxOz4trTtndWBV5LbxZkF9TlzdDwx9W2uQ==", "X-Received": "by 2002:a17:902:5985:b029:da:c737:5842 with SMTP id\n p5-20020a1709025985b02900dac7375842mr5421708pli.21.1607113070283;\n Fri, 04 Dec 2020 12:17:50 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Fri, 4 Dec 2020 12:16:45 -0800", "Message-Id": "<20201204201646.51746-9-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<20201204201646.51746-1-aboyer@pensando.io>", "<20201203203418.15064-1-aboyer@pensando.io>" ], "References": [ "<20201204201646.51746-1-aboyer@pensando.io>", "<20201203203418.15064-1-aboyer@pensando.io>" ], "Subject": "[dpdk-dev] [PATCH v3 8/9] net/ionic: minor refactorings and helper\n\tvariables", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This makes the code clearer and conserves resources.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_ethdev.c | 5 ++---\n drivers/net/ionic/ionic_lif.c | 15 ++++++++++-----\n drivers/net/ionic/ionic_main.c | 18 +++++++-----------\n 3 files changed, 19 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex ce6ca9671..a1c35ace3 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -901,7 +901,7 @@ ionic_dev_start(struct rte_eth_dev *eth_dev)\n \tstruct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);\n \tstruct ionic_adapter *adapter = lif->adapter;\n \tstruct ionic_dev *idev = &adapter->idev;\n-\tuint32_t allowed_speeds;\n+\tuint32_t speed, allowed_speeds;\n \tint err;\n \n \tIONIC_PRINT_CALL();\n@@ -929,8 +929,7 @@ ionic_dev_start(struct rte_eth_dev *eth_dev)\n \t}\n \n \tif (eth_dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED) {\n-\t\tuint32_t speed = ionic_parse_link_speeds(dev_conf->link_speeds);\n-\n+\t\tspeed = ionic_parse_link_speeds(dev_conf->link_speeds);\n \t\tif (speed)\n \t\t\tionic_dev_cmd_port_speed(idev, speed);\n \t}\ndiff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex 2e33fb8d9..722a89565 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -77,11 +77,14 @@ void\n ionic_lif_reset(struct ionic_lif *lif)\n {\n \tstruct ionic_dev *idev = &lif->adapter->idev;\n+\tint err;\n \n \tIONIC_PRINT_CALL();\n \n \tionic_dev_cmd_lif_reset(idev, lif->index);\n-\tionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);\n+\terr = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);\n+\tif (err)\n+\t\tIONIC_PRINT(WARNING, \"Failed to reset lif\");\n }\n \n static void\n@@ -305,10 +308,11 @@ ionic_dev_add_mac(struct rte_eth_dev *eth_dev,\n }\n \n void\n-ionic_dev_remove_mac(struct rte_eth_dev *eth_dev, uint32_t index __rte_unused)\n+ionic_dev_remove_mac(struct rte_eth_dev *eth_dev, uint32_t index)\n {\n \tstruct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);\n \tstruct ionic_adapter *adapter = lif->adapter;\n+\tstruct rte_ether_addr *mac_addr;\n \n \tIONIC_PRINT_CALL();\n \n@@ -319,11 +323,12 @@ ionic_dev_remove_mac(struct rte_eth_dev *eth_dev, uint32_t index __rte_unused)\n \t\treturn;\n \t}\n \n-\tif (!rte_is_valid_assigned_ether_addr(ð_dev->data->mac_addrs[index]))\n+\tmac_addr = ð_dev->data->mac_addrs[index];\n+\n+\tif (!rte_is_valid_assigned_ether_addr(mac_addr))\n \t\treturn;\n \n-\tionic_lif_addr_del(lif, (const uint8_t *)\n-\t\tð_dev->data->mac_addrs[index]);\n+\tionic_lif_addr_del(lif, (const uint8_t *)mac_addr);\n }\n \n int\ndiff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c\nindex f77bddaa4..92cf0f398 100644\n--- a/drivers/net/ionic/ionic_main.c\n+++ b/drivers/net/ionic/ionic_main.c\n@@ -188,8 +188,7 @@ ionic_adminq_post_wait(struct ionic_lif *lif, struct ionic_admin_ctx *ctx)\n \tdone = ionic_wait_ctx_for_completion(lif, qcq, ctx,\n \t\tIONIC_DEVCMD_TIMEOUT);\n \n-\terr = ionic_adminq_check_err(ctx, !done /* timed out */);\n-\treturn err;\n+\treturn ionic_adminq_check_err(ctx, !done /* timed out */);\n }\n \n static int\n@@ -241,10 +240,11 @@ ionic_dev_cmd_wait_check(struct ionic_dev *idev, unsigned long max_wait)\n \tint err;\n \n \terr = ionic_dev_cmd_wait(idev, max_wait);\n-\tif (err)\n-\t\treturn err;\n \n-\treturn ionic_dev_cmd_check_error(idev);\n+\tif (!err)\n+\t\terr = ionic_dev_cmd_check_error(idev);\n+\n+\treturn err;\n }\n \n int\n@@ -299,22 +299,18 @@ int\n ionic_init(struct ionic_adapter *adapter)\n {\n \tstruct ionic_dev *idev = &adapter->idev;\n-\tint err;\n \n \tionic_dev_cmd_init(idev);\n-\terr = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);\n-\treturn err;\n+\treturn ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);\n }\n \n int\n ionic_reset(struct ionic_adapter *adapter)\n {\n \tstruct ionic_dev *idev = &adapter->idev;\n-\tint err;\n \n \tionic_dev_cmd_reset(idev);\n-\terr = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);\n-\treturn err;\n+\treturn ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);\n }\n \n int\n", "prefixes": [ "v3", "8/9" ] }