Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84763/?format=api
{ "id": 84763, "url": "https://patches.dpdk.org/api/patches/84763/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201204201646.51746-7-aboyer@pensando.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201204201646.51746-7-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20201204201646.51746-7-aboyer@pensando.io", "date": "2020-12-04T20:16:43", "name": "[v3,6/9] net/ionic: convert 'deferred' boolean to a flag bit", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e5e166a17fc347192f9d1d37c4a9bf3f25ba7525", "submitter": { "id": 2036, "url": "https://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201204201646.51746-7-aboyer@pensando.io/mbox/", "series": [ { "id": 14190, "url": "https://patches.dpdk.org/api/series/14190/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14190", "date": "2020-12-04T20:16:37", "name": "net/ionic: minor updates and documentation", "version": 3, "mbox": "https://patches.dpdk.org/series/14190/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84763/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84763/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6E212A09E3;\n\tFri, 4 Dec 2020 21:19:25 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A0B5DC9EE;\n\tFri, 4 Dec 2020 21:17:48 +0100 (CET)", "from mail-pl1-f196.google.com (mail-pl1-f196.google.com\n [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 039FCC9EE\n for <dev@dpdk.org>; Fri, 4 Dec 2020 21:17:47 +0100 (CET)", "by mail-pl1-f196.google.com with SMTP id y10so2297383plr.10\n for <dev@dpdk.org>; Fri, 04 Dec 2020 12:17:46 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id z20sm2911805pjq.16.2020.12.04.12.17.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 04 Dec 2020 12:17:45 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :in-reply-to:references;\n bh=qmxIh6cdNdLLa2XdNRfpBmQWwzN+8fOiAnW4//T+ShM=;\n b=iyREqoT0bdyotRKsYXf5mSnPCs9peRJu7AtiZi+nvRqqHxIoeCdOZBYFzFOOkr+kxR\n FKpNpM0M53IyCQsoo1/vD3uYoZVoz4Ug63UDvOtgZgZXViAYSal4vQ7QNUIkt1qG1ZNU\n h1NdIhSuHSNRFAuBJmzfH0IFIajOMC7FZ9wE7t7FiLS6jFmAHAWvgkxT6AuDNFIjz+U1\n Fu/dBjD9cfJKXqkOaZjE4DO/beEOXmY5WXN/BzmTzS5+veWQK3LedL+vaQq35iLx+KOD\n Am8js4HdyZm0eZDlx6W1YHpPYuf80G4udKrh5SnZplWkQfJCk38TPSeK8JXvovBArvpJ\n QZTw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:in-reply-to:references;\n bh=qmxIh6cdNdLLa2XdNRfpBmQWwzN+8fOiAnW4//T+ShM=;\n b=gLN5beMEyPFkmsnXslq9gv/TvxL52wG0SkTXmOLHSo5tot8tPdw5Ah6wIzYGQf5Mb5\n J7xXaC6O2dCgkfd29PFgq1+rtELkheiluiKLl30ALO3fm6WYXoHzMDfc3/B6tXZKUY7j\n o1ZR6vcHFH/4qt3WIr/OmwiWHHuo8ULs/HpQVaxzKuV2oqP5jIZO8bTSjmqu2DXOpDHv\n m9L9jGvWSCTIQ+uPqS9se8eobgB/ohgg9Cbodqid1SLc6uFPxNTLbINtdFfprw/hmjlK\n /M4/r4INhBmID9cTuzCZO71S2Cvom0ihQ7PbbRIfiOtWAkwW/7i07htXm83gKd/Ji9OS\n KT5g==", "X-Gm-Message-State": "AOAM530AtWVtIvpjSd88UbLrI9Zp1iS5bcyCyS1lK9wFGKTnKN+Zi3FI\n RtvoBWZfYMyiSSHismuPFQVRncUZ6wxUfw==", "X-Google-Smtp-Source": "\n ABdhPJwH3P7stvxS/1XL3EvPLWCX54R/B7cfK1dG6VZ5WONTkt7/4mnMyAldJdBQwh74eSWPj5rWEw==", "X-Received": "by 2002:a17:902:8698:b029:da:1d7a:f5ef with SMTP id\n g24-20020a1709028698b02900da1d7af5efmr5133529plo.67.1607113065996;\n Fri, 04 Dec 2020 12:17:45 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Fri, 4 Dec 2020 12:16:43 -0800", "Message-Id": "<20201204201646.51746-7-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<20201204201646.51746-1-aboyer@pensando.io>", "<20201203203418.15064-1-aboyer@pensando.io>" ], "References": [ "<20201204201646.51746-1-aboyer@pensando.io>", "<20201203203418.15064-1-aboyer@pensando.io>" ], "Subject": "[dpdk-dev] [PATCH v3 6/9] net/ionic: convert 'deferred' boolean to\n\ta flag bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This conserves resources.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_lif.c | 4 ++--\n drivers/net/ionic/ionic_lif.h | 2 +-\n drivers/net/ionic/ionic_rxtx.c | 10 ++++++----\n 3 files changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex bc15d75fd..2e33fb8d9 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -1590,7 +1590,7 @@ ionic_lif_start(struct ionic_lif *lif)\n \n \tfor (i = 0; i < lif->nrxqcqs; i++) {\n \t\tstruct ionic_qcq *rxq = lif->rxqcqs[i];\n-\t\tif (!rxq->deferred_start) {\n+\t\tif (!(rxq->flags & IONIC_QCQ_F_DEFERRED)) {\n \t\t\terr = ionic_dev_rx_queue_start(lif->eth_dev, i);\n \n \t\t\tif (err)\n@@ -1600,7 +1600,7 @@ ionic_lif_start(struct ionic_lif *lif)\n \n \tfor (i = 0; i < lif->ntxqcqs; i++) {\n \t\tstruct ionic_qcq *txq = lif->txqcqs[i];\n-\t\tif (!txq->deferred_start) {\n+\t\tif (!(txq->flags & IONIC_QCQ_F_DEFERRED)) {\n \t\t\terr = ionic_dev_tx_queue_start(lif->eth_dev, i);\n \n \t\t\tif (err)\ndiff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex 4e091719f..8e2b42443 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -50,6 +50,7 @@ struct ionic_rx_stats {\n #define IONIC_QCQ_F_SG\t\tBIT(1)\n #define IONIC_QCQ_F_INTR\tBIT(2)\n #define IONIC_QCQ_F_NOTIFYQ\tBIT(3)\n+#define IONIC_QCQ_F_DEFERRED\tBIT(4)\n \n /* Queue / Completion Queue */\n struct ionic_qcq {\n@@ -68,7 +69,6 @@ struct ionic_qcq {\n \tuint32_t total_size;\n \tuint32_t flags;\n \tstruct ionic_intr_info intr;\n-\tbool deferred_start;\n };\n \n #define IONIC_Q_TO_QCQ(q)\tcontainer_of(q, struct ionic_qcq, q)\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex 2592f5cab..b953aff49 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -64,7 +64,7 @@ ionic_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \n \tqinfo->nb_desc = q->num_descs;\n \tqinfo->conf.offloads = txq->offloads;\n-\tqinfo->conf.tx_deferred_start = txq->deferred_start;\n+\tqinfo->conf.tx_deferred_start = txq->flags & IONIC_QCQ_F_DEFERRED;\n }\n \n static inline void __rte_cold\n@@ -196,7 +196,8 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id,\n \t}\n \n \t/* Do not start queue with rte_eth_dev_start() */\n-\ttxq->deferred_start = tx_conf->tx_deferred_start;\n+\tif (tx_conf->tx_deferred_start)\n+\t\ttxq->flags |= IONIC_QCQ_F_DEFERRED;\n \n \ttxq->offloads = offloads;\n \n@@ -605,7 +606,7 @@ ionic_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \tqinfo->mp = rxq->mb_pool;\n \tqinfo->scattered_rx = dev->data->scattered_rx;\n \tqinfo->nb_desc = q->num_descs;\n-\tqinfo->conf.rx_deferred_start = rxq->deferred_start;\n+\tqinfo->conf.rx_deferred_start = rxq->flags & IONIC_QCQ_F_DEFERRED;\n \tqinfo->conf.offloads = rxq->offloads;\n }\n \n@@ -703,7 +704,8 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,\n \t */\n \n \t/* Do not start queue with rte_eth_dev_start() */\n-\trxq->deferred_start = rx_conf->rx_deferred_start;\n+\tif (rx_conf->rx_deferred_start)\n+\t\trxq->flags |= IONIC_QCQ_F_DEFERRED;\n \n \trxq->offloads = offloads;\n \n", "prefixes": [ "v3", "6/9" ] }