Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84706/?format=api
{ "id": 84706, "url": "https://patches.dpdk.org/api/patches/84706/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201202101212.4717-33-lironh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201202101212.4717-33-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201202101212.4717-33-lironh@marvell.com", "date": "2020-12-02T10:12:06", "name": "[v1,32/38] net/mvpp2: apply flow-ctrl after port init", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8a0051d46567d8d5ea87e0841f0d28ea2deb7717", "submitter": { "id": 996, "url": "https://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201202101212.4717-33-lironh@marvell.com/mbox/", "series": [ { "id": 14168, "url": "https://patches.dpdk.org/api/series/14168/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14168", "date": "2020-12-02T10:11:34", "name": "net/mvpp2: misc updates", "version": 1, "mbox": "https://patches.dpdk.org/series/14168/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84706/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84706/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5C426A04DB;\n\tWed, 2 Dec 2020 11:23:30 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 66975C9DA;\n\tWed, 2 Dec 2020 11:13:28 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 27263C9C2\n for <dev@dpdk.org>; Wed, 2 Dec 2020 11:13:27 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 0B2AAT4i024223 for <dev@dpdk.org>; Wed, 2 Dec 2020 02:13:23 -0800", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 355w509r6g-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 02 Dec 2020 02:13:21 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 2 Dec 2020 02:13:16 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 2 Dec 2020 02:13:15 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=NvlUb5wCv+21GOx33UPZpD1AOUjpai7e7WRNPr0rFNU=;\n b=VWc/14jahpwT9qteUrEG/YUWi7GixdA3wCC21GddN6LhX9VKN388V3+7OlMb9I3gmrbo\n pJo5xO/nI5MRGNgkanw/yQw660o+72eOZ/aRyJRxzD+0IZff5rUlm3G2rC2yHanzVfEE\n ghssJ7P843xRJSZLkf/E56mnoZ3XUX0BXzKWAi9zNbFoaxJsBJ/SMgXRxhLMdyIuUcxC\n TGCpi7XYpqFbRm3/8qdVZNFjvgPM59jQNBxUtRmcCBGt3lbv/ZaIVe9rOGyjLigKhzAS\n k/PBUELlPZvSbO5dTfXX24rTV6DkdNBydfjXzNOdtsOlkhifrJexJ9pSeRr6HbhARqGu OQ==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>, Liron Himi <lironh@marvell.com>", "Date": "Wed, 2 Dec 2020 12:12:06 +0200", "Message-ID": "<20201202101212.4717-33-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201202101212.4717-1-lironh@marvell.com>", "References": "<20201202101212.4717-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737\n definitions=2020-12-02_04:2020-11-30,\n 2020-12-02 signatures=0", "Subject": "[dpdk-dev] [PATCH v1 32/38] net/mvpp2: apply flow-ctrl after port\n\tinit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Liron Himi <lironh@marvell.com>\n\nin case ppio was not initialized yet (only at 'start' function)\nthe flow-ctrl setting should be saved for later stage.\n\nSigned-off-by: Liron Himi <lironh@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 26 +++++++++++++++++++++-----\n drivers/net/mvpp2/mrvl_ethdev.h | 2 ++\n 2 files changed, 23 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex d388fde96..fe5fd90ef 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -164,6 +164,8 @@ static int\n mrvl_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on);\n static int mrvl_promiscuous_enable(struct rte_eth_dev *dev);\n static int mrvl_allmulticast_enable(struct rte_eth_dev *dev);\n+static int\n+mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf);\n \n #define MRVL_XSTATS_TBL_ENTRY(name) { \\\n \t#name, offsetof(struct pp2_ppio_statistics, name),\t\\\n@@ -912,6 +914,15 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \tif (dev->data->promiscuous == 1)\n \t\tmrvl_promiscuous_enable(dev);\n \n+\tif (priv->flow_ctrl) {\n+\t\tret = mrvl_flow_ctrl_set(dev, &priv->fc_conf);\n+\t\tif (ret) {\n+\t\t\tMRVL_LOG(ERR, \"Failed to configure flow control\");\n+\t\t\tgoto out;\n+\t\t}\n+\t\tpriv->flow_ctrl = 0;\n+\t}\n+\n \tif (dev->data->dev_link.link_status == ETH_LINK_UP) {\n \t\tret = mrvl_dev_set_link_up(dev);\n \t\tif (ret) {\n@@ -2147,8 +2158,10 @@ mrvl_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tint ret, en;\n \n-\tif (!priv)\n-\t\treturn -EPERM;\n+\tif (!priv->ppio) {\n+\t\tmemcpy(fc_conf, &priv->fc_conf, sizeof(struct rte_eth_fc_conf));\n+\t\treturn 0;\n+\t}\n \n \tfc_conf->autoneg = 1;\n \tret = pp2_ppio_get_rx_pause(priv->ppio, &en);\n@@ -2194,9 +2207,6 @@ mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)\n \tint ret;\n \tint rx_en, tx_en;\n \n-\tif (!priv)\n-\t\treturn -EPERM;\n-\n \tif (fc_conf->high_water ||\n \t fc_conf->low_water ||\n \t fc_conf->pause_time ||\n@@ -2211,6 +2221,12 @@ mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)\n \t\treturn -EINVAL;\n \t}\n \n+\tif (!priv->ppio) {\n+\t\tmemcpy(&priv->fc_conf, fc_conf, sizeof(struct rte_eth_fc_conf));\n+\t\tpriv->flow_ctrl = 1;\n+\t\treturn 0;\n+\t}\n+\n \tswitch (fc_conf->mode) {\n \tcase RTE_FC_FULL:\n \t\trx_en = 1;\ndiff --git a/drivers/net/mvpp2/mrvl_ethdev.h b/drivers/net/mvpp2/mrvl_ethdev.h\nindex ada2c51b2..148f2acba 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.h\n+++ b/drivers/net/mvpp2/mrvl_ethdev.h\n@@ -161,6 +161,8 @@ struct mrvl_priv {\n \tuint8_t isolated;\n \tuint8_t multiseg;\n \tuint16_t max_mtu;\n+\tuint8_t\tflow_ctrl;\n+\tstruct rte_eth_fc_conf fc_conf;\n \n \tstruct pp2_ppio_params ppio_params;\n \tstruct pp2_cls_qos_tbl_params qos_tbl_params;\n", "prefixes": [ "v1", "32/38" ] }