Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84689/?format=api
{ "id": 84689, "url": "https://patches.dpdk.org/api/patches/84689/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201202101212.4717-18-lironh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201202101212.4717-18-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201202101212.4717-18-lironh@marvell.com", "date": "2020-12-02T10:11:51", "name": "[v1,17/38] net/mvpp2: add TX flow control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e93d61e1f5366e42488c1cde8d1a0b1c587c63dd", "submitter": { "id": 996, "url": "https://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201202101212.4717-18-lironh@marvell.com/mbox/", "series": [ { "id": 14168, "url": "https://patches.dpdk.org/api/series/14168/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14168", "date": "2020-12-02T10:11:34", "name": "net/mvpp2: misc updates", "version": 1, "mbox": "https://patches.dpdk.org/series/14168/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84689/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84689/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 919CFA04DB;\n\tWed, 2 Dec 2020 11:17:52 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2BAB4CA1E;\n\tWed, 2 Dec 2020 11:12:55 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id CD7D1CA1E\n for <dev@dpdk.org>; Wed, 2 Dec 2020 11:12:53 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 0B2AAKqc024171 for <dev@dpdk.org>; Wed, 2 Dec 2020 02:12:52 -0800", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 355w509r5h-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 02 Dec 2020 02:12:52 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 2 Dec 2020 02:12:50 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 2 Dec 2020 02:12:49 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=U4C9JW9cVJNXhBDAozfPubHQfU5HhDf6a3SH4LElBxg=;\n b=TbOh6TltZ0oy8kbIgfCMlheFbHV1SXxPeO9CQINPSjy+6EIlH/m+CbrNq7vwYmpye669\n LeyGhqt6fZ54MaegmOq3Uc51iS3OvbbymP6CxHersUyE6tQNZJLMYUHHwlRufbTYExL2\n HKK7Zatf467wnZZCd0xpMffgZkJZEVcpnKxuQqugyDkg4cVUtf8DoeKfpHb3WqsM/eFz\n THPXsdnHhN/4Nd5Gi+2NksdrnSweyfSvKXx/zAnGVxtlXQMwXCl/aUq4RWZJ+rrWMck1\n mYMd9+3CQFN1bkGtUENkL6/9ICM4iE1DmM7HrV8gtglVDMmLjLOWXNZt+VFMsJyEs8YV Qg==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>, Yuri Chipchev <yuric@marvell.com>, Liron Himi\n <lironh@marvell.com>", "Date": "Wed, 2 Dec 2020 12:11:51 +0200", "Message-ID": "<20201202101212.4717-18-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201202101212.4717-1-lironh@marvell.com>", "References": "<20201202101212.4717-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737\n definitions=2020-12-02_04:2020-11-30,\n 2020-12-02 signatures=0", "Subject": "[dpdk-dev] [PATCH v1 17/38] net/mvpp2: add TX flow control", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yuri Chipchev <yuric@marvell.com>\n\nadd tx flow control operations.\n\nSigned-off-by: Yuri Chipchev <yuric@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 59 ++++++++++++++++++++++++++++-----\n 1 file changed, 51 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex d1bb4c35a..f80843c63 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -2049,6 +2049,19 @@ mrvl_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)\n \n \tfc_conf->mode = en ? RTE_FC_RX_PAUSE : RTE_FC_NONE;\n \n+\tret = pp2_ppio_get_tx_pause(priv->ppio, &en);\n+\tif (ret) {\n+\t\tMRVL_LOG(ERR, \"Failed to read tx pause state\");\n+\t\treturn ret;\n+\t}\n+\n+\tif (en) {\n+\t\tif (fc_conf->mode == RTE_FC_NONE)\n+\t\t\tfc_conf->mode = RTE_FC_TX_PAUSE;\n+\t\telse\n+\t\t\tfc_conf->mode = RTE_FC_FULL;\n+\t}\n+\n \treturn 0;\n }\n \n@@ -2067,6 +2080,9 @@ static int\n mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)\n {\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n+\tstruct pp2_ppio_tx_pause_params mrvl_pause_params;\n+\tint ret;\n+\tint rx_en, tx_en;\n \n \tif (!priv)\n \t\treturn -EPERM;\n@@ -2081,16 +2097,43 @@ mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)\n \t\treturn -EINVAL;\n \t}\n \n-\tif (fc_conf->mode == RTE_FC_NONE ||\n-\t fc_conf->mode == RTE_FC_RX_PAUSE) {\n-\t\tint ret, en;\n+\tswitch (fc_conf->mode) {\n+\tcase RTE_FC_FULL:\n+\t\trx_en = 1;\n+\t\ttx_en = 1;\n+\t\tbreak;\n+\tcase RTE_FC_TX_PAUSE:\n+\t\trx_en = 0;\n+\t\ttx_en = 1;\n+\t\tbreak;\n+\tcase RTE_FC_RX_PAUSE:\n+\t\trx_en = 1;\n+\t\ttx_en = 0;\n+\t\tbreak;\n+\tcase RTE_FC_NONE:\n+\t\trx_en = 0;\n+\t\ttx_en = 0;\n+\t\tbreak;\n+\tdefault:\n+\t\tMRVL_LOG(ERR, \"Incorrect Flow control flag (%d)\",\n+\t\t\t fc_conf->mode);\n+\t\treturn -EINVAL;\n+\t}\n \n-\t\ten = fc_conf->mode == RTE_FC_NONE ? 0 : 1;\n-\t\tret = pp2_ppio_set_rx_pause(priv->ppio, en);\n-\t\tif (ret)\n-\t\t\tMRVL_LOG(ERR,\n-\t\t\t\t\"Failed to change flowctrl on RX side\");\n+\t/* Set RX flow control */\n+\tret = pp2_ppio_set_rx_pause(priv->ppio, rx_en);\n+\tif (ret) {\n+\t\tMRVL_LOG(ERR, \"Failed to change RX flowctrl\");\n+\t\treturn ret;\n+\t}\n \n+\t/* Set TX flow control */\n+\tmrvl_pause_params.en = tx_en;\n+\t/* all inqs participate in xon/xoff decision */\n+\tmrvl_pause_params.use_tc_pause_inqs = 0;\n+\tret = pp2_ppio_set_tx_pause(priv->ppio, &mrvl_pause_params);\n+\tif (ret) {\n+\t\tMRVL_LOG(ERR, \"Failed to change TX flowctrl\");\n \t\treturn ret;\n \t}\n \n", "prefixes": [ "v1", "17/38" ] }