Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84683/?format=api
{ "id": 84683, "url": "https://patches.dpdk.org/api/patches/84683/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201202101212.4717-11-lironh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201202101212.4717-11-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201202101212.4717-11-lironh@marvell.com", "date": "2020-12-02T10:11:44", "name": "[v1,10/38] net/mvpp2: cosmetic changes to cookie usage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a9c270fb3c388ca4350dc21d122cdad8087fd5e0", "submitter": { "id": 996, "url": "https://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201202101212.4717-11-lironh@marvell.com/mbox/", "series": [ { "id": 14168, "url": "https://patches.dpdk.org/api/series/14168/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14168", "date": "2020-12-02T10:11:34", "name": "net/mvpp2: misc updates", "version": 1, "mbox": "https://patches.dpdk.org/series/14168/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84683/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84683/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B6C7A04DB;\n\tWed, 2 Dec 2020 11:15:53 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EF645CA51;\n\tWed, 2 Dec 2020 11:12:41 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 20B69C9CA\n for <dev@dpdk.org>; Wed, 2 Dec 2020 11:12:40 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 0B2AAT4a024223 for <dev@dpdk.org>; Wed, 2 Dec 2020 02:12:39 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 355w509r53-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 02 Dec 2020 02:12:39 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 2 Dec 2020 02:12:37 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 2 Dec 2020 02:12:36 -0800" ], "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>, Yuri Chipchev <yuric@marvell.com>, Liron Himi\n <lironh@marvell.com>", "Date": "Wed, 2 Dec 2020 12:11:44 +0200", "Message-ID": "<20201202101212.4717-11-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201202101212.4717-1-lironh@marvell.com>", "References": "<20201202101212.4717-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737\n definitions=2020-12-02_04:2020-11-30,\n 2020-12-02 signatures=0", "Subject": "[dpdk-dev] [PATCH v1 10/38] net/mvpp2: cosmetic changes to cookie\n\tusage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yuri Chipchev <yuric@marvell.com>\n\nNo need to add high address to cookie on transmit side, as it has\nalready 64bit value\n\nSigned-off-by: Yuri Chipchev <yuric@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex e81d5ee91..130f5221d 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -1643,14 +1643,16 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num)\n \t\tif (((uint64_t)mbufs[i] & MRVL_COOKIE_HIGH_ADDR_MASK)\n \t\t\t!= cookie_addr_high) {\n \t\t\tMRVL_LOG(ERR,\n-\t\t\t\t\"mbuf virtual addr high 0x%lx out of range\",\n-\t\t\t\t(uint64_t)mbufs[i] >> 32);\n+\t\t\t\t\"mbuf virtual addr high is out of range \"\n+\t\t\t\t\"0x%x instead of 0x%x\\n\",\n+\t\t\t\t(uint32_t)((uint64_t)mbufs[i] >> 32),\n+\t\t\t\t(uint32_t)(cookie_addr_high >> 32));\n \t\t\tgoto out;\n \t\t}\n \n \t\tentries[i].buff.addr =\n \t\t\trte_mbuf_data_iova_default(mbufs[i]);\n-\t\tentries[i].buff.cookie = (uint64_t)mbufs[i];\n+\t\tentries[i].buff.cookie = (uintptr_t)mbufs[i];\n \t\tentries[i].bpool = bpool;\n \t}\n \n@@ -2549,8 +2551,7 @@ mrvl_free_sent_buffers(struct pp2_ppio *ppio, struct pp2_hif *hif,\n \t\tif (unlikely(!entry->bpool)) {\n \t\t\tstruct rte_mbuf *mbuf;\n \n-\t\t\tmbuf = (struct rte_mbuf *)\n-\t\t\t (cookie_addr_high | entry->buff.cookie);\n+\t\t\tmbuf = (struct rte_mbuf *)entry->buff.cookie;\n \t\t\trte_pktmbuf_free(mbuf);\n \t\t\tskip_bufs = 1;\n \t\t\tgoto skip;\n@@ -2663,7 +2664,7 @@ mrvl_tx_pkt_burst(void *txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\tfor (i = nb_pkts; i < num; i++) {\n \t\t\tsq->head = (MRVL_PP2_TX_SHADOWQ_SIZE + sq->head - 1) &\n \t\t\t\tMRVL_PP2_TX_SHADOWQ_MASK;\n-\t\t\taddr = cookie_addr_high | sq->ent[sq->head].buff.cookie;\n+\t\t\taddr = sq->ent[sq->head].buff.cookie;\n \t\t\tbytes_sent -=\n \t\t\t\trte_pktmbuf_pkt_len((struct rte_mbuf *)addr);\n \t\t}\n", "prefixes": [ "v1", "10/38" ] }