Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84520/?format=api
{ "id": 84520, "url": "https://patches.dpdk.org/api/patches/84520/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1bbaefeb069a75f57a2f49b4217efa994bed5d4b.1606229937.git.tredaelli@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1bbaefeb069a75f57a2f49b4217efa994bed5d4b.1606229937.git.tredaelli@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1bbaefeb069a75f57a2f49b4217efa994bed5d4b.1606229937.git.tredaelli@redhat.com", "date": "2020-11-24T15:14:14", "name": "[1/2] eal: fix shared lib mode detection", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "aba269cd69b23f34257a348bf49d9ffecc3f94f9", "submitter": { "id": 717, "url": "https://patches.dpdk.org/api/people/717/?format=api", "name": "Timothy Redaelli", "email": "tredaelli@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1bbaefeb069a75f57a2f49b4217efa994bed5d4b.1606229937.git.tredaelli@redhat.com/mbox/", "series": [ { "id": 14077, "url": "https://patches.dpdk.org/api/series/14077/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14077", "date": "2020-11-24T15:14:13", "name": "Fix shared lib detection on Fedora/CentOS/RHEL", "version": 1, "mbox": "https://patches.dpdk.org/series/14077/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84520/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/84520/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CE80AA04B1;\n\tTue, 24 Nov 2020 16:14:53 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C9809C93C;\n\tTue, 24 Nov 2020 16:14:32 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by dpdk.org (Postfix) with ESMTP id D14D6C93A\n for <dev@dpdk.org>; Tue, 24 Nov 2020 16:14:30 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-197-qvnwdN-pN4alCNduRHKHDg-1; Tue, 24 Nov 2020 10:14:27 -0500", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E70C1018BD2;\n Tue, 24 Nov 2020 15:14:26 +0000 (UTC)", "from localhost.localdomain\n (dhcp19-189-130.ntdv.lab.eng.bos.redhat.com [10.19.189.130])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 29C1960864;\n Tue, 24 Nov 2020 15:14:24 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1606230869;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=AbwrugNtaoeN4ZUzGCyK28CdQfb/O8RhVwKYhE+H1vM=;\n b=fXsD5fGr45itHW21u97HWCDOh6Ta9/qP0xKQZSM87SlpBaJxrZlXgPIZFREx/rvPnBDwC1\n gNNpNmq42A1IfuTfdGfGNTLEhzILPNguoDyOs+56XD6edc7FADAg4GnYPGvr1g+1aCq6p+\n rH007WrtNDZoGCXe+l3HgZ+WMBKAoyg=", "X-MC-Unique": "qvnwdN-pN4alCNduRHKHDg-1", "From": "Timothy Redaelli <tredaelli@redhat.com>", "To": "Anatoly Burakov <anatoly.burakov@intel.com>", "Cc": "bruce.richardson@intel.com,\n\tdev@dpdk.org,\n\tstable@dpdk.org", "Date": "Tue, 24 Nov 2020 16:14:14 +0100", "Message-Id": "\n <1bbaefeb069a75f57a2f49b4217efa994bed5d4b.1606229937.git.tredaelli@redhat.com>", "In-Reply-To": "<cover.1606229937.git.tredaelli@redhat.com>", "References": "<cover.1606229937.git.tredaelli@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=tredaelli@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 1/2] eal: fix shared lib mode detection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Commit 06c7871dde01 (\"eal: restrict default plugin path to shared lib mode\")\nintroduced a check that enabled shared lib mode when librte_eal.so can\nbe loaded, but it can't work, at least, on Fedora/CentOS/RHEL since .so\nsymlinks are not installed when you install dpdk package, but only when\nyou install dpdk-devel package.\n\nThis commit uses librte_eal.so.ABI_VERSION to check for shared lib,\nsince it exists on any linux distributions.\n\nSee Fedora Packaging Guidelines for more informations:\nhttps://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages\n\nFixes: 06c7871dde01 (\"eal: restrict default plugin path to shared lib mode\")\nCc: bruce.richardson@intel.com\nCc: stable@dpdk.org\nSigned-off-by: Timothy Redaelli <tredaelli@redhat.com>\n---\n lib/librte_eal/common/eal_common_options.c | 3 ++-\n lib/librte_eal/common/meson.build | 2 ++\n 2 files changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex fc6f0cea93..e6f77ad217 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -503,7 +503,8 @@ eal_plugins_init(void)\n \t * (Using dlopen with NOLOAD flag on EAL, will return NULL if the EAL\n \t * shared library is not already loaded i.e. it's statically linked.)\n \t */\n-\tif (dlopen(\"librte_eal.so\", RTLD_LAZY | RTLD_NOLOAD) != NULL &&\n+\tif (dlopen(\"librte_eal.so.\"ABI_VERSION, RTLD_LAZY | RTLD_NOLOAD)\n+\t\t\t!= NULL &&\n \t\t\t*default_solib_dir != '\\0' &&\n \t\t\tstat(default_solib_dir, &sb) == 0 &&\n \t\t\tS_ISDIR(sb.st_mode))\ndiff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build\nindex 9f32262450..39abf7a0a4 100644\n--- a/lib/librte_eal/common/meson.build\n+++ b/lib/librte_eal/common/meson.build\n@@ -3,6 +3,8 @@\n \n includes += include_directories('.')\n \n+cflags += [ '-DABI_VERSION=\"@0@\"'.format(abi_version) ]\n+\n if is_windows\n \tsources += files(\n \t\t'eal_common_bus.c',\n", "prefixes": [ "1/2" ] }