Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84480/?format=api
{ "id": 84480, "url": "https://patches.dpdk.org/api/patches/84480/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201123221918.20825-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201123221918.20825-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20201123221918.20825-3-stephen@networkplumber.org", "date": "2020-11-23T22:19:18", "name": "[2/2] net/netvsc: fix ethdev get_supported_ptypes", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e10e2a7750c8cdb27f59266f0bd0eb6326324fe2", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201123221918.20825-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 14046, "url": "https://patches.dpdk.org/api/series/14046/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14046", "date": "2020-11-23T22:19:16", "name": "net/netvsc: fix supported_ptypes", "version": 1, "mbox": "https://patches.dpdk.org/series/14046/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84480/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/84480/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 234FDA04B1;\n\tMon, 23 Nov 2020 23:20:22 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 15DDAC92C;\n\tMon, 23 Nov 2020 23:19:46 +0100 (CET)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 2CA8EC906\n for <dev@dpdk.org>; Mon, 23 Nov 2020 23:19:41 +0100 (CET)", "by mail-pg1-f196.google.com with SMTP id v21so15595719pgi.2\n for <dev@dpdk.org>; Mon, 23 Nov 2020 14:19:41 -0800 (PST)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id h7sm12950414pgi.90.2020.11.23.14.19.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 23 Nov 2020 14:19:37 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=OIgNDlflmIConLZzILl+qRFhC9bxq64g5x+maOQHTT8=;\n b=MtDrTVChtfAJ+uW/wMBiDlq+qfYL3FvN16XHgrzf77P4/DyDZ2raplmDPUtL/MQCJD\n FDMh4kl24VjEF1s92Hn6VogPXbmPymmoru9QK4tmjhyEI0i9PGz1woMP7DBpJ3kQ4Ocr\n wZnxcw9z8tkz8WDOj+qZfFuZrmGpptGcwKbWtcZvRE/4LZtUvpxyafr8yczHRXu0cd4k\n Vwqa1iFd3NmJzbBSVFfK4Jz7oeKeJ231RPzKcDf8f5f3a276YLX93CNMP0JbUydLxNhr\n IX7PUYB7cmjkKAh38+Cbrb5AepM6zfnBQmMYrkJqIhzIb+6GPhr/G+5ZTQXFp9FbdC1X\n ud2A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=OIgNDlflmIConLZzILl+qRFhC9bxq64g5x+maOQHTT8=;\n b=ElCgiVA8BFnP4GegWBdVIKm8T7RUPXk5ap4iOoJaU6fFH0heIyiO5GHksQt61i1IIV\n SZunFPzAAuj8qbKg4clT834asDHKl1odFknytMX6LNnR7Faj+eJBoRgRjzzldKFiIqoV\n 5OJiiNdAlS92lbJ44DnSDrqg4WFitmDyZHA3VWrfwYJT+YmLSl/solfsU3IU4YB+5Kx9\n 97Nt2cSCv3nOesfHdxrus3L38hM27SbFi4uoIOcf4coasP8b9kFR6VAlYBbhDWxNPVW1\n vciT6s1QOraM80KLSLPLA66uHefrnpbcQZEsIhdVQQGTU6s3bb1xIAjcLqkD/TsjN4/b\n 9Gkg==", "X-Gm-Message-State": "AOAM530n8po+TCdFri/kGZyeFZuTT0X8jTTx7c0Fd/bnWmqL8r2IvYI+\n jRt8FQeLkn8V7lAc0V6eKGkS9jIJ/CGNPt/H", "X-Google-Smtp-Source": "\n ABdhPJz73tsjHR6qop2LxAhzlaCNC33wZImJK6DWQiePdzpuqp9cK6qKGqsgrb0sI1mp9W4NNcD6bA==", "X-Received": "by 2002:a17:90a:940e:: with SMTP id\n r14mr1211234pjo.47.1606169978920;\n Mon, 23 Nov 2020 14:19:38 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 23 Nov 2020 14:19:18 -0800", "Message-Id": "<20201123221918.20825-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201123221918.20825-1-stephen@networkplumber.org>", "References": "<20201123221918.20825-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] net/netvsc: fix ethdev get_supported_ptypes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When doing rte_eth_dev_get_supported_ptypes on netvsc device\nthe values reported are incorrect if VF is not present.\n\nIf no VF is present the device uses rte_net_get_ptype()\nwhich can return a wide range of values. Use the same table\nas TAP device in that case.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/netvsc/hn_ethdev.c | 48 +++++++++++++++++++++++++++++++++-\n drivers/net/netvsc/hn_var.h | 1 -\n drivers/net/netvsc/hn_vf.c | 15 -----------\n 3 files changed, 47 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex 49f954305dd8..9ce0134bd41b 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -438,6 +438,52 @@ static int hn_rss_hash_conf_get(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+static const uint32_t*\n+hn_dev_supported_ptypes(struct rte_eth_dev *dev)\n+{\n+\tstruct hn_data *hv = dev->data->dev_private;\n+\tstruct rte_eth_dev *vf_dev;\n+\tconst uint32_t *ptypes = NULL;\n+\n+\t/* List of possible ptypes comes from rte_net_get_ptype. */\n+\tstatic const uint32_t net_ptypes[] = {\n+\t\tRTE_PTYPE_INNER_L2_ETHER,\n+\t\tRTE_PTYPE_INNER_L2_ETHER_VLAN,\n+\t\tRTE_PTYPE_INNER_L2_ETHER_QINQ,\n+\t\tRTE_PTYPE_INNER_L3_IPV4,\n+\t\tRTE_PTYPE_INNER_L3_IPV4_EXT,\n+\t\tRTE_PTYPE_INNER_L3_IPV6,\n+\t\tRTE_PTYPE_INNER_L3_IPV6_EXT,\n+\t\tRTE_PTYPE_INNER_L4_FRAG,\n+\t\tRTE_PTYPE_INNER_L4_UDP,\n+\t\tRTE_PTYPE_INNER_L4_TCP,\n+\t\tRTE_PTYPE_INNER_L4_SCTP,\n+\t\tRTE_PTYPE_L2_ETHER,\n+\t\tRTE_PTYPE_L2_ETHER_VLAN,\n+\t\tRTE_PTYPE_L2_ETHER_QINQ,\n+\t\tRTE_PTYPE_L3_IPV4,\n+\t\tRTE_PTYPE_L3_IPV4_EXT,\n+\t\tRTE_PTYPE_L3_IPV6_EXT,\n+\t\tRTE_PTYPE_L3_IPV6,\n+\t\tRTE_PTYPE_L4_FRAG,\n+\t\tRTE_PTYPE_L4_UDP,\n+\t\tRTE_PTYPE_L4_TCP,\n+\t\tRTE_PTYPE_L4_SCTP,\n+\t};\n+\n+\trte_rwlock_read_lock(&hv->vf_lock);\n+\tvf_dev = hn_get_vf_dev(hv);\n+\tif (vf_dev) {\n+\t\tif (vf_dev->dev_ops->dev_supported_ptypes_get)\n+\t\t\tptypes = (*vf_dev->dev_ops->dev_supported_ptypes_get)(vf_dev);\n+\t} else {\n+\t\tptypes = net_ptypes;\n+\t}\n+\trte_rwlock_read_unlock(&hv->vf_lock);\n+\n+\treturn ptypes;\n+}\n+\n static int\n hn_dev_promiscuous_enable(struct rte_eth_dev *dev)\n {\n@@ -880,7 +926,7 @@ static const struct eth_dev_ops hn_eth_dev_ops = {\n \t.dev_infos_get\t\t= hn_dev_info_get,\n \t.txq_info_get\t\t= hn_dev_tx_queue_info,\n \t.rxq_info_get\t\t= hn_dev_rx_queue_info,\n-\t.dev_supported_ptypes_get = hn_vf_supported_ptypes,\n+\t.dev_supported_ptypes_get = hn_dev_supported_ptypes,\n \t.promiscuous_enable = hn_dev_promiscuous_enable,\n \t.promiscuous_disable = hn_dev_promiscuous_disable,\n \t.allmulticast_enable = hn_dev_allmulticast_enable,\ndiff --git a/drivers/net/netvsc/hn_var.h b/drivers/net/netvsc/hn_var.h\nindex bd874c6b4d70..7c84f58d430d 100644\n--- a/drivers/net/netvsc/hn_var.h\n+++ b/drivers/net/netvsc/hn_var.h\n@@ -223,7 +223,6 @@ int\thn_vf_info_get(struct hn_data *hv,\n int\thn_vf_add(struct rte_eth_dev *dev, struct hn_data *hv);\n int\thn_vf_configure(struct rte_eth_dev *dev,\n \t\t\tconst struct rte_eth_conf *dev_conf);\n-const uint32_t *hn_vf_supported_ptypes(struct rte_eth_dev *dev);\n int\thn_vf_start(struct rte_eth_dev *dev);\n void\thn_vf_reset(struct rte_eth_dev *dev);\n int\thn_vf_close(struct rte_eth_dev *dev);\ndiff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c\nindex d43ebaa69fbb..e18596e77061 100644\n--- a/drivers/net/netvsc/hn_vf.c\n+++ b/drivers/net/netvsc/hn_vf.c\n@@ -244,21 +244,6 @@ int hn_vf_configure(struct rte_eth_dev *dev,\n \treturn ret;\n }\n \n-const uint32_t *hn_vf_supported_ptypes(struct rte_eth_dev *dev)\n-{\n-\tstruct hn_data *hv = dev->data->dev_private;\n-\tstruct rte_eth_dev *vf_dev;\n-\tconst uint32_t *ptypes = NULL;\n-\n-\trte_rwlock_read_lock(&hv->vf_lock);\n-\tvf_dev = hn_get_vf_dev(hv);\n-\tif (vf_dev && vf_dev->dev_ops->dev_supported_ptypes_get)\n-\t\tptypes = (*vf_dev->dev_ops->dev_supported_ptypes_get)(vf_dev);\n-\trte_rwlock_read_unlock(&hv->vf_lock);\n-\n-\treturn ptypes;\n-}\n-\n int hn_vf_start(struct rte_eth_dev *dev)\n {\n \tstruct hn_data *hv = dev->data->dev_private;\n", "prefixes": [ "2/2" ] }