Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84416/?format=api
{ "id": 84416, "url": "https://patches.dpdk.org/api/patches/84416/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1605871656-51819-2-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1605871656-51819-2-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1605871656-51819-2-git-send-email-oulijun@huawei.com", "date": "2020-11-20T11:27:33", "name": "[1/4] net/hns3: fix segment fault with the multi-TC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "215a4777c17a7d3238ff68ae5de25e2372a47728", "submitter": { "id": 1675, "url": "https://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1605871656-51819-2-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 14002, "url": "https://patches.dpdk.org/api/series/14002/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14002", "date": "2020-11-20T11:27:34", "name": "hns3 fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/14002/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84416/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84416/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A61F3A04DD;\n\tFri, 20 Nov 2020 12:27:46 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E1497C8B6;\n\tFri, 20 Nov 2020 12:27:29 +0100 (CET)", "from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by dpdk.org (Postfix) with ESMTP id 8049BDED\n for <dev@dpdk.org>; Fri, 20 Nov 2020 12:27:26 +0100 (CET)", "from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CcvQg2Dyxz7065\n for <dev@dpdk.org>; Fri, 20 Nov 2020 19:27:07 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id\n 14.3.487.0; Fri, 20 Nov 2020 19:27:15 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@huawei.com>", "Date": "Fri, 20 Nov 2020 19:27:33 +0800", "Message-ID": "<1605871656-51819-2-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1605871656-51819-1-git-send-email-oulijun@huawei.com>", "References": "<1605871656-51819-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 1/4] net/hns3: fix segment fault with the multi-TC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThe HW and SW DCB configurations need to be updated only\nafter the DCB configuration information changed. But the\nchange of tx/rx queue number is ignored. If user decreases\nthe number of tx queue after configuring multi-TC, the queue\nmapping information in hns3_tc_queue_info can not be updated.\nAnd then accessing the released queue resource in\n\"hns3_init_tx_ring_tc\" will trigger a segment fault.\n\nFixes: 62e3ccc2b94c (\"net/hns3: support flow control\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n drivers/net/hns3/hns3_dcb.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_dcb.c b/drivers/net/hns3/hns3_dcb.c\nindex ab02c87..fb50179 100644\n--- a/drivers/net/hns3/hns3_dcb.c\n+++ b/drivers/net/hns3/hns3_dcb.c\n@@ -1351,6 +1351,8 @@ hns3_dcb_cfg_validate(struct hns3_adapter *hns, uint8_t *tc, bool *changed)\n {\n \tstruct rte_eth_dcb_rx_conf *dcb_rx_conf;\n \tstruct hns3_hw *hw = &hns->hw;\n+\tuint16_t nb_rx_q = hw->data->nb_rx_queues;\n+\tuint16_t nb_tx_q = hw->data->nb_tx_queues;\n \tuint8_t max_tc = 0;\n \tuint8_t pfc_en;\n \tint i;\n@@ -1376,6 +1378,10 @@ hns3_dcb_cfg_validate(struct hns3_adapter *hns, uint8_t *tc, bool *changed)\n \tpfc_en = RTE_LEN2MASK((uint8_t)dcb_rx_conf->nb_tcs, uint8_t);\n \tif (hw->dcb_info.pfc_en != pfc_en)\n \t\t*changed = true;\n+\n+\t/* tx/rx queue number is reconfigured. */\n+\tif (nb_rx_q != hw->used_rx_queues || nb_tx_q != hw->used_tx_queues)\n+\t\t*changed = true;\n }\n \n static int\n", "prefixes": [ "1/4" ] }