Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84375/?format=api
{ "id": 84375, "url": "https://patches.dpdk.org/api/patches/84375/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201119115900.4095566-6-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201119115900.4095566-6-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201119115900.4095566-6-ferruh.yigit@intel.com", "date": "2020-11-19T11:58:55", "name": "[v21.02,v3,05/10] net/pcap: remove local variable shadowing outer one", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c80919b3b37b00f50d56838f2c8d8998b062add6", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201119115900.4095566-6-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 13979, "url": "https://patches.dpdk.org/api/series/13979/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13979", "date": "2020-11-19T11:58:50", "name": "cppcheck", "version": 3, "mbox": "https://patches.dpdk.org/series/13979/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84375/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/84375/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 14BC0A04DD;\n\tThu, 19 Nov 2020 13:01:00 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 93547C91E;\n\tThu, 19 Nov 2020 12:59:22 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 47996C8C6;\n Thu, 19 Nov 2020 12:59:17 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Nov 2020 03:59:15 -0800", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.180])\n by orsmga002.jf.intel.com with ESMTP; 19 Nov 2020 03:59:14 -0800" ], "IronPort-SDR": [ "\n 4/tRvwfUOI52HmmIlqm3OYq8SKBUn0HgNTPy5S21psxFb6Puyv9PHZZW/kka3E81+DevsoTE0V\n +ZGAhHBC9Hsw==", "\n picvZ2mA9u71fwi/v6z990XKVIYbA3x/uRmA8FmeG/QC96VMEQGCQ0FjRYn2rtymq5i4UdED4j\n 8+XbDAUIdC7g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9809\"; a=\"170494403\"", "E=Sophos;i=\"5.77,490,1596524400\"; d=\"scan'208\";a=\"170494403\"", "E=Sophos;i=\"5.77,490,1596524400\"; d=\"scan'208\";a=\"341665185\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org,\n\tJuhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 19 Nov 2020 11:58:55 +0000", "Message-Id": "<20201119115900.4095566-6-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20201119115900.4095566-1-ferruh.yigit@intel.com>", "References": "<20200824094021.2323605-1-ferruh.yigit@intel.com>\n <20201119115900.4095566-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [v21.02 v3 05/10] net/pcap: remove local variable\n\tshadowing outer one", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'ret' is already defined in the function scope, removing the 'ret' in\nthe block scope.\n\nFixes: c9507cd0cada (\"net/pcap: support physical interface MAC address\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nv3:\n* Eliminated block scope 'ret' variable usage completely.\n---\n drivers/net/pcap/rte_eth_pcap.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex 4930d7d382..90929478eb 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -1324,9 +1324,8 @@ eth_from_pcaps(struct rte_vdev_device *vdev,\n \n \t\t/* phy_mac arg is applied only only if \"iface\" devarg is provided */\n \t\tif (rx_queues->phy_mac) {\n-\t\t\tint ret = eth_pcap_update_mac(rx_queues->queue[0].name,\n-\t\t\t\t\teth_dev, vdev->device.numa_node);\n-\t\t\tif (ret == 0)\n+\t\t\tif(eth_pcap_update_mac(rx_queues->queue[0].name,\n+\t\t\t\t\teth_dev, vdev->device.numa_node) == 0)\n \t\t\t\tinternals->phy_mac = 1;\n \t\t}\n \t}\n", "prefixes": [ "v21.02", "v3", "05/10" ] }