Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84339/?format=api
{ "id": 84339, "url": "https://patches.dpdk.org/api/patches/84339/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201118181103.3865787-2-conor.walsh@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201118181103.3865787-2-conor.walsh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201118181103.3865787-2-conor.walsh@intel.com", "date": "2020-11-18T18:11:02", "name": "[v2,1/2] build: fix gcc compile warnings by adding wformat", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6983d46fac7f97882200ad93a9f7d2bb12278f83", "submitter": { "id": 1935, "url": "https://patches.dpdk.org/api/people/1935/?format=api", "name": "Conor Walsh", "email": "conor.walsh@intel.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201118181103.3865787-2-conor.walsh@intel.com/mbox/", "series": [ { "id": 13955, "url": "https://patches.dpdk.org/api/series/13955/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13955", "date": "2020-11-18T18:11:01", "name": "build: add Wformat to fix gcc compile warnings and format fixes", "version": 2, "mbox": "https://patches.dpdk.org/series/13955/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84339/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84339/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98684A04DD;\n\tWed, 18 Nov 2020 19:11:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E298EC8DE;\n\tWed, 18 Nov 2020 19:11:16 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 39A2BC872\n for <dev@dpdk.org>; Wed, 18 Nov 2020 19:11:13 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Nov 2020 10:11:12 -0800", "from silpixa00400466.ir.intel.com ([10.237.213.98])\n by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 10:11:09 -0800" ], "IronPort-SDR": [ "\n 8RaR7Im5tl0slh/8be4QPIJ552pLHom73G7rtSj2BnXYpC9bIDoEBnBvGboO9+B7ZJNFmquPBz\n exYkPPdXArAg==", "\n me6Co0sudOu4z9/RKa1uyF8nCMbDkieW+y+uad9S4tanG4H1PtAkm4fl2ksXXSsbGc2lyvGp6E\n XHAB7qSKnm9w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9809\"; a=\"189240733\"", "E=Sophos;i=\"5.77,488,1596524400\"; d=\"scan'208\";a=\"189240733\"", "E=Sophos;i=\"5.77,488,1596524400\"; d=\"scan'208\";a=\"476464016\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Conor Walsh <conor.walsh@intel.com>", "To": "bruce.richardson@intel.com, ajit.khaparde@broadcom.com,\n somnath.kotur@broadcom.com, bluca@debian.org, stuart.schacher@broadcom.com,\n venkatkumar.duvvuru@broadcom.com, michael.wildt@broadcom.com", "Cc": "dev@dpdk.org, linglix.chen@intel.com, thomas@monjalon.net,\n\tConor Walsh <conor.walsh@intel.com>, Chen@dpdk.org", "Date": "Wed, 18 Nov 2020 18:11:02 +0000", "Message-Id": "<20201118181103.3865787-2-conor.walsh@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201118181103.3865787-1-conor.walsh@intel.com>", "References": "<20201112113537.1996073-1-conor.walsh@intel.com>\n <20201118181103.3865787-1-conor.walsh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/2] build: fix gcc compile warnings by adding\n\twformat", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On some CentOS/RHEL systems using gcc 8.3.1 to compile dpdk, gcc shows a\nwarning on every build step saying that -Wformat-nonliteral and\n-Wformat-security warnings will be ignored unless -Wformat is\nalso specified as a compiler flag. When the build is run with -werror\nthe build will fail due to these warnings.\n\nExact warning returned:\ncc1: error: -Wformat-nonliteral ignored without -Wformat\n[-Werror=format-nonliteral]\ncc1: error: -Wformat-security ignored without -Wformat\n[-Werror=format-security]\ncc1: all warnings being treated as errors\n\nThis patch adds the -Wformat flag to config/meson.build. The warning id\n181 has also been suppressed in icc as icc was showing false positives\nwith -Wformat enabled.\n\nFixes: 524a0d5d66b9 (\"build: enable extra warnings with meson\")\nCc: bruce.richardson@intel.com\n\nSigned-off-by: Conor Walsh <conor.walsh@intel.com>\nTested-by: Chen, LingliX <linglix.chen@intel.com>\n---\n config/meson.build | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex a29693b883..c02802c18e 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -194,6 +194,7 @@ warning_flags = [\n \t# additional warnings in alphabetical order\n \t'-Wcast-qual',\n \t'-Wdeprecated',\n+\t'-Wformat',\n \t'-Wformat-nonliteral',\n \t'-Wformat-security',\n \t'-Wmissing-declarations',\n@@ -220,7 +221,7 @@ if not dpdk_conf.get('RTE_ARCH_64')\n \twarning_flags += '-Wno-pointer-to-int-cast'\n endif\n if cc.get_id() == 'intel'\n-\twarning_ids = [188, 2203, 2279, 2557, 3179, 3656]\n+\twarning_ids = [181, 188, 2203, 2279, 2557, 3179, 3656]\n \tforeach i:warning_ids\n \t\twarning_flags += '-diag-disable=@0@'.format(i)\n \tendforeach\n", "prefixes": [ "v2", "1/2" ] }