Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84318/?format=api
{ "id": 84318, "url": "https://patches.dpdk.org/api/patches/84318/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201118114525.99053-3-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201118114525.99053-3-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201118114525.99053-3-ferruh.yigit@intel.com", "date": "2020-11-18T11:45:20", "name": "[v2,2/7] app/procinfo: fix negative check on unsigned variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ebbbcf25dedaa8b8ea560d4da19675e9f8fe5aac", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201118114525.99053-3-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 13949, "url": "https://patches.dpdk.org/api/series/13949/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13949", "date": "2020-11-18T11:45:18", "name": "cppcheck", "version": 2, "mbox": "https://patches.dpdk.org/series/13949/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84318/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84318/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 978ACA04E6;\n\tWed, 18 Nov 2020 12:46:20 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ED466C8CC;\n\tWed, 18 Nov 2020 12:45:43 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 9D4DE5947;\n Wed, 18 Nov 2020 12:45:40 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Nov 2020 03:45:40 -0800", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.180])\n by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 03:45:38 -0800" ], "IronPort-SDR": [ "\n T7E4skyl+jt0CoGqkguLPXOabcx2EHExI+1cgk0RUKFI1/sbEM+tGRhWv477uPzwk6wb0qTRMD\n XeCmp3Fmxydw==", "\n 61IvArz9KogZDohY+K2KEotiwo/uxZoFbErGa9Q0oxQsaCv/ucChd9GBePIkbXO83OPVbXOaTL\n 40lRxENHhwmA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9808\"; a=\"158876061\"", "E=Sophos;i=\"5.77,486,1596524400\"; d=\"scan'208\";a=\"158876061\"", "E=Sophos;i=\"5.77,486,1596524400\"; d=\"scan'208\";a=\"476313123\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Maryam Tahhan <maryam.tahhan@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>, Kuba Kozak <kubax.kozak@intel.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tdev@dpdk.org,\n\tstable@dpdk.org", "Date": "Wed, 18 Nov 2020 11:45:20 +0000", "Message-Id": "<20201118114525.99053-3-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20201118114525.99053-1-ferruh.yigit@intel.com>", "References": "<20201117171435.2303641-1-ferruh.yigit@intel.com>\n <20201118114525.99053-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 2/7] app/procinfo: fix negative check on\n\tunsigned variable", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'parse_xstats_ids()' return 'int'. The return value is assigned to\n'nb_xstats_ids' unsigned value, later negative check on this variable is\nwrong.\n\nAdding interim 'int' variable for negative check.\n\nFixes: 7ac16a3660c0 (\"app/proc-info: support xstats by ID and by name\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n app/proc-info/main.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex 35e5b596eb..c11fe25af4 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -301,14 +301,13 @@ proc_info_parse_args(int argc, char **argv)\n \t\t\t} else if (!strncmp(long_option[option_index].name,\n \t\t\t\t\t\"xstats-ids\",\n \t\t\t\t\tMAX_LONG_OPT_SZ))\t{\n-\t\t\t\tnb_xstats_ids = parse_xstats_ids(optarg,\n+\t\t\t\tint ret = parse_xstats_ids(optarg,\n \t\t\t\t\t\txstats_ids, MAX_NB_XSTATS_IDS);\n-\n-\t\t\t\tif (nb_xstats_ids <= 0) {\n+\t\t\t\tif (ret <= 0) {\n \t\t\t\t\tprintf(\"xstats-id list parse error.\\n\");\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n-\n+\t\t\t\tnb_xstats_ids = (uint32_t)ret;\n \t\t\t}\n \t\t\tbreak;\n \t\tdefault:\n", "prefixes": [ "v2", "2/7" ] }