Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84299/?format=api
{ "id": 84299, "url": "https://patches.dpdk.org/api/patches/84299/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201118073524.25646-2-feifei.wang2@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201118073524.25646-2-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201118073524.25646-2-feifei.wang2@arm.com", "date": "2020-11-18T07:35:21", "name": "[v1,1/4] net/ixgbe: add VLAN stripping support for Arm", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a98b626131c3eaccf78ef8fd4cb1f9b74e0fc26a", "submitter": { "id": 1771, "url": "https://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201118073524.25646-2-feifei.wang2@arm.com/mbox/", "series": [ { "id": 13942, "url": "https://patches.dpdk.org/api/series/13942/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13942", "date": "2020-11-18T07:35:20", "name": "Enable Checksum Offloading for NEON vector", "version": 1, "mbox": "https://patches.dpdk.org/series/13942/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84299/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/84299/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C15F9A04E6;\n\tWed, 18 Nov 2020 08:35:56 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3B4AF5AAE;\n\tWed, 18 Nov 2020 08:35:40 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 8DBC45947\n for <dev@dpdk.org>; Wed, 18 Nov 2020 08:35:38 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09357101E;\n Tue, 17 Nov 2020 23:35:37 -0800 (PST)", "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.219])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 868CC3F70D;\n Tue, 17 Nov 2020 23:35:34 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Jeff Guo <jia.guo@intel.com>, Haiyue Wang <haiyue.wang@intel.com>", "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tFeifei Wang <feifei.wang2@arm.com>", "Date": "Wed, 18 Nov 2020 01:35:21 -0600", "Message-Id": "<20201118073524.25646-2-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201118073524.25646-1-feifei.wang2@arm.com>", "References": "<20201118073524.25646-1-feifei.wang2@arm.com>", "Subject": "[dpdk-dev] [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for\n\tArm", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Implemented PKT_RX_VLAN_STRIPPED for vector PMD on Arm platform.\n\nTest Results:\nNICs: 82599(igb)\nDriver: ixgbe(vector)\nPacket: vlan-id=1\n\n$:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i --port-topology=chained \\\nto enable vlan stripping: --enable-hw-vlan-strip\ntest-pmd> set fwd rxonly\ntest-pmd> set verbose 1\ntest-pmd> start\n\nWith this patch:\n%enable vlan stripping:\ntestpmd> port 0/queue 0: received 1 packets\nsrc=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1 - VLAN tci=0x1\nol_flags: PKT_RX_VLAN PKT_RX_VLAN_STRIPPED\n\n%disable vlan stripping:\ntestpmd> port 0/queue 0: received 1 packets\nsrc=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x8100 - length=74 - nb_segs=1 - VLAN tci=0x0\nol_flags: PKT_RX_VLAN\n\nWithout this patch:\n%enable vlan stripping:\ntestpmd> port 0/queue 0: received 1 packets\nsrc=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1 - VLAN tci=0x1\nol_flags: PKT_RX_VLAN\n\n%disable vlan stripping:\ntestpmd> port 0/queue 0: received 1 packets\nsrc=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x8100 - length=74 - nb_segs=1 - VLAN tci=0x0\nol_flags: PKT_RX_VLAN\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 36 ++++++++++++++++---------\n 1 file changed, 23 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\nindex 4c81ae9dc..e6d877af9 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\n@@ -81,11 +81,9 @@ ixgbe_rxq_rearm(struct ixgbe_rx_queue *rxq)\n \tIXGBE_PCI_REG_WRITE(rxq->rdt_reg_addr, rx_id);\n }\n \n-#define VTAG_SHIFT (3)\n-\n static inline void\n desc_to_olflags_v(uint8x16x2_t sterr_tmp1, uint8x16x2_t sterr_tmp2,\n-\t\t uint8x16_t staterr, struct rte_mbuf **rx_pkts)\n+\t\t uint8x16_t staterr, uint8_t vlan_flags, struct rte_mbuf **rx_pkts)\n {\n \tuint8x16_t ptype;\n \tuint8x16_t vtag;\n@@ -95,13 +93,6 @@ desc_to_olflags_v(uint8x16x2_t sterr_tmp1, uint8x16x2_t sterr_tmp2,\n \t\tuint32_t word;\n \t} vol;\n \n-\tconst uint8x16_t pkttype_msk = {\n-\t\t\tPKT_RX_VLAN, PKT_RX_VLAN,\n-\t\t\tPKT_RX_VLAN, PKT_RX_VLAN,\n-\t\t\t0x00, 0x00, 0x00, 0x00,\n-\t\t\t0x00, 0x00, 0x00, 0x00,\n-\t\t\t0x00, 0x00, 0x00, 0x00};\n-\n \tconst uint8x16_t rsstype_msk = {\n \t\t\t0x0F, 0x0F, 0x0F, 0x0F,\n \t\t\t0x00, 0x00, 0x00, 0x00,\n@@ -114,12 +105,26 @@ desc_to_olflags_v(uint8x16x2_t sterr_tmp1, uint8x16x2_t sterr_tmp2,\n \t\t\tPKT_RX_RSS_HASH, 0, 0, 0,\n \t\t\t0, 0, 0, PKT_RX_FDIR};\n \n+\tconst uint8x16_t vlan_msk = {\n+\t\t\tIXGBE_RXD_STAT_VP, IXGBE_RXD_STAT_VP,\n+\t\t\tIXGBE_RXD_STAT_VP, IXGBE_RXD_STAT_VP,\n+\t\t\t0, 0, 0, 0,\n+\t\t\t0, 0, 0, 0,\n+\t\t\t0, 0, 0, 0};\n+\n+\tconst uint8x16_t vlan_map = {\n+\t\t\t0, 0, 0, 0,\n+\t\t\t0, 0, 0, 0,\n+\t\t\tvlan_flags, 0, 0, 0,\n+\t\t\t0, 0, 0, 0};\n+\n \tptype = vzipq_u8(sterr_tmp1.val[0], sterr_tmp2.val[0]).val[0];\n \tptype = vandq_u8(ptype, rsstype_msk);\n \tptype = vqtbl1q_u8(rss_flags, ptype);\n \n-\tvtag = vshrq_n_u8(staterr, VTAG_SHIFT);\n-\tvtag = vandq_u8(vtag, pkttype_msk);\n+\t/* extract vlan_flags from IXGBE_RXD_STAT_VP bits of staterr */\n+\tvtag = vandq_u8(staterr, vlan_msk);\n+\tvtag = vqtbl1q_u8(vlan_map, vtag);\n \tvtag = vorrq_u8(ptype, vtag);\n \n \tvol.word = vgetq_lane_u32(vreinterpretq_u32_u8(vtag), 0);\n@@ -221,6 +226,7 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \t\t};\n \tuint16x8_t crc_adjust = {0, 0, rxq->crc_len, 0,\n \t\t\t\t rxq->crc_len, 0, 0, 0};\n+\tuint8_t vlan_flags;\n \n \t/* nb_pkts has to be floor-aligned to RTE_IXGBE_DESCS_PER_LOOP */\n \tnb_pkts = RTE_ALIGN_FLOOR(nb_pkts, RTE_IXGBE_DESCS_PER_LOOP);\n@@ -250,6 +256,10 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \t */\n \tsw_ring = &rxq->sw_ring[rxq->rx_tail];\n \n+\t/* ensure these 2 flags are in the lower 8 bits */\n+\tRTE_BUILD_BUG_ON((PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED) > UINT8_MAX);\n+\tvlan_flags = rxq->vlan_flags & UINT8_MAX;\n+\n \t/* A. load 4 packet in one loop\n \t * B. copy 4 mbuf point from swring to rx_pkts\n \t * C. calc the number of DD bits among the 4 packets\n@@ -311,7 +321,7 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \t\tstaterr = vzipq_u8(sterr_tmp1.val[1], sterr_tmp2.val[1]).val[0];\n \n \t\t/* set ol_flags with vlan packet type */\n-\t\tdesc_to_olflags_v(sterr_tmp1, sterr_tmp2, staterr,\n+\t\tdesc_to_olflags_v(sterr_tmp1, sterr_tmp2, staterr, vlan_flags,\n \t\t\t\t &rx_pkts[pos]);\n \n \t\t/* D.2 pkt 3,4 set in_port/nb_seg and remove crc */\n", "prefixes": [ "v1", "1/4" ] }