Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 84295,
    "url": "https://patches.dpdk.org/api/patches/84295/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201118062929.21345-3-feifei.wang2@arm.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201118062929.21345-3-feifei.wang2@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201118062929.21345-3-feifei.wang2@arm.com",
    "date": "2020-11-18T06:29:27",
    "name": "[v1,2/4] net/ixgbe: support checksum flags for NEON vector",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "a66afa6fda574007be8b1a1818450651f7bb2d86",
    "submitter": {
        "id": 1771,
        "url": "https://patches.dpdk.org/api/people/1771/?format=api",
        "name": "Feifei Wang",
        "email": "feifei.wang2@arm.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201118062929.21345-3-feifei.wang2@arm.com/mbox/",
    "series": [
        {
            "id": 13941,
            "url": "https://patches.dpdk.org/api/series/13941/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13941",
            "date": "2020-11-18T06:29:25",
            "name": "Enable Checksum Offloading for NEON vector",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/13941/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/84295/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/84295/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 18C7AA04E6;\n\tWed, 18 Nov 2020 07:30:17 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E34EFC8F4;\n\tWed, 18 Nov 2020 07:29:48 +0100 (CET)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id DEC5DC8F2\n for <dev@dpdk.org>; Wed, 18 Nov 2020 07:29:46 +0100 (CET)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5CF60101E;\n Tue, 17 Nov 2020 22:29:45 -0800 (PST)",
            "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.219])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DD1DE3F70D;\n Tue, 17 Nov 2020 22:29:42 -0800 (PST)"
        ],
        "From": "Feifei Wang <feifei.wang2@arm.com>",
        "To": "Jerin Jacob <jerinj@marvell.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Jeff Guo <jia.guo@intel.com>, Haiyue Wang <haiyue.wang@intel.com>",
        "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tFeifei Wang <feifei.wang2@arm.com>",
        "Date": "Wed, 18 Nov 2020 00:29:27 -0600",
        "Message-Id": "<20201118062929.21345-3-feifei.wang2@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20201118062929.21345-1-feifei.wang2@arm.com>",
        "References": "<20201118062929.21345-1-feifei.wang2@arm.com>",
        "Subject": "[dpdk-dev] [PATCH v1 2/4] net/ixgbe: support checksum flags for\n\tNEON vector",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Updated desc_to_olflags_v() to support PKT_RX_IP_CKSUM_BAD and\nPKT_RX_L4_CKSUM_BAD in the ol_flags of the mbuf for Arm neon vector\nRx function.\n\nTest Results:\nNICs: 82599(igb)\nDirver: ixgbe(vector)\nPacket: IPv4_checksum = 0xee && UDP_checksum = 0xee\n\n$:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i --port-topology=chained\ntest-pmd> set fwd rxonly\ntest-pmd> set verbose 1\ntest-pmd> start\n\nWith this patch:\ntestpmd> port 0/queue 0: received 1 packets\nsrc=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1\nol_flags: PKT_RX_L4_CKSUM_BAD PKT_RX_IP_CKSUM_BAD\n\nWithout this patch:\ntestpmd> port 0/queue 0: received 1 packets\nsrc=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - length=70 - nb_segs=1\nol_flags: PKT_RX_L4_CKSUM_UNKNOWN PKT_RX_IP_CKSUM_UNKNOWN\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 47 +++++++++++++++++++------\n 1 file changed, 36 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\nindex e6d877af9..4d6f057e7 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c\n@@ -87,6 +87,8 @@ desc_to_olflags_v(uint8x16x2_t sterr_tmp1, uint8x16x2_t sterr_tmp2,\n {\n \tuint8x16_t ptype;\n \tuint8x16_t vtag;\n+\tuint8x16_t temp_csum;\n+\tuint32x4_t csum = {0, 0, 0, 0};\n \n \tunion {\n \t\tuint8_t e[4];\n@@ -105,26 +107,51 @@ desc_to_olflags_v(uint8x16x2_t sterr_tmp1, uint8x16x2_t sterr_tmp2,\n \t\t\tPKT_RX_RSS_HASH, 0, 0, 0,\n \t\t\t0, 0, 0, PKT_RX_FDIR};\n \n-\tconst uint8x16_t vlan_msk = {\n+\t/* mask everything except vlan present and l4/ip csum error */\n+\tconst uint8x16_t vlan_csum_msk = {\n \t\t\tIXGBE_RXD_STAT_VP, IXGBE_RXD_STAT_VP,\n \t\t\tIXGBE_RXD_STAT_VP, IXGBE_RXD_STAT_VP,\n \t\t\t0, 0, 0, 0,\n \t\t\t0, 0, 0, 0,\n-\t\t\t0, 0, 0, 0};\n-\n-\tconst uint8x16_t vlan_map = {\n+\t\t\t(IXGBE_RXDADV_ERR_TCPE | IXGBE_RXDADV_ERR_IPE) >> 24,\n+\t\t\t(IXGBE_RXDADV_ERR_TCPE | IXGBE_RXDADV_ERR_IPE) >> 24,\n+\t\t\t(IXGBE_RXDADV_ERR_TCPE | IXGBE_RXDADV_ERR_IPE) >> 24,\n+\t\t\t(IXGBE_RXDADV_ERR_TCPE | IXGBE_RXDADV_ERR_IPE) >> 24};\n+\n+\t/* map vlan present (0x8), IPE (0x2), L4E (0x1) to ol_flags */\n+\tconst uint8x16_t vlan_csum_map = {\n+\t\t\t0,\n+\t\t\tPKT_RX_L4_CKSUM_BAD,\n+\t\t\tPKT_RX_IP_CKSUM_BAD,\n+\t\t\tPKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD,\n \t\t\t0, 0, 0, 0,\n-\t\t\t0, 0, 0, 0,\n-\t\t\tvlan_flags, 0, 0, 0,\n+\t\t\tvlan_flags,\n+\t\t\tvlan_flags | PKT_RX_L4_CKSUM_BAD,\n+\t\t\tvlan_flags | PKT_RX_IP_CKSUM_BAD,\n+\t\t\tvlan_flags | PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD,\n \t\t\t0, 0, 0, 0};\n \n \tptype = vzipq_u8(sterr_tmp1.val[0], sterr_tmp2.val[0]).val[0];\n \tptype = vandq_u8(ptype, rsstype_msk);\n \tptype = vqtbl1q_u8(rss_flags, ptype);\n \n-\t/* extract vlan_flags from IXGBE_RXD_STAT_VP bits of staterr */\n-\tvtag = vandq_u8(staterr, vlan_msk);\n-\tvtag = vqtbl1q_u8(vlan_map, vtag);\n+\t/* extract vlan_flags and csum_error from staterr */\n+\tvtag = vandq_u8(staterr, vlan_csum_msk);\n+\n+\t/* csum bits are in the most significant, to use shuffle we need to\n+\t * shift them. Change mask from 0xc0 to 0x03.\n+\t */\n+\ttemp_csum = vshrq_n_u8(vtag, 6);\n+\n+\t/* 'OR' the most significant 32 bits containing the checksum\n+\t * flags with the vlan present flags\n+\t * Then bits layout of each lane(8bits) will be 'xxxx,VP,x,IPE,L4E'\n+\t */\n+\tcsum = vsetq_lane_u32(vgetq_lane_u32(vreinterpretq_u32_u8(temp_csum), 3), csum, 0);\n+\tvtag = vorrq_u8(vreinterpretq_u8_u32(csum), vtag);\n+\n+\t/* convert VP, IPE, L4E to ol_flags */\n+\tvtag = vqtbl1q_u8(vlan_csum_map, vtag);\n \tvtag = vorrq_u8(ptype, vtag);\n \n \tvol.word = vgetq_lane_u32(vreinterpretq_u32_u8(vtag), 0);\n@@ -391,7 +418,6 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n  * Notice:\n  * - nb_pkts < RTE_IXGBE_DESCS_PER_LOOP, just return no packet\n  * - floor align nb_pkts to a RTE_IXGBE_DESC_PER_LOOP power-of-two\n- * - don't support ol_flags for rss and csum err\n  */\n uint16_t\n ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n@@ -404,7 +430,6 @@ ixgbe_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n  * vPMD receive routine that reassembles scattered packets\n  *\n  * Notice:\n- * - don't support ol_flags for rss and csum err\n  * - nb_pkts < RTE_IXGBE_DESCS_PER_LOOP, just return no packet\n  * - floor align nb_pkts to a RTE_IXGBE_DESC_PER_LOOP power-of-two\n  */\n",
    "prefixes": [
        "v1",
        "2/4"
    ]
}