Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84269/?format=api
{ "id": 84269, "url": "https://patches.dpdk.org/api/patches/84269/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201117112648.29725-3-maxime.leroy@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201117112648.29725-3-maxime.leroy@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201117112648.29725-3-maxime.leroy@6wind.com", "date": "2020-11-17T11:26:47", "name": "[v4,2/2] net/mlx5: fix Rx descriptor status returned value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e0d0974fccb8ed6074bfdd8fc867fb45288d2c1b", "submitter": { "id": 112, "url": "https://patches.dpdk.org/api/people/112/?format=api", "name": "Maxime Leroy", "email": "maxime.leroy@6wind.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201117112648.29725-3-maxime.leroy@6wind.com/mbox/", "series": [ { "id": 13925, "url": "https://patches.dpdk.org/api/series/13925/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13925", "date": "2020-11-17T11:26:45", "name": "net/mlx5: fixes for rx queue count calculation", "version": 4, "mbox": "https://patches.dpdk.org/series/13925/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84269/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/84269/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 91D6AA04DB;\n\tTue, 17 Nov 2020 12:27:33 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 99588C8B2;\n\tTue, 17 Nov 2020 12:27:22 +0100 (CET)", "from mail-wr1-f67.google.com (mail-wr1-f67.google.com\n [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 687CC37B0\n for <dev@dpdk.org>; Tue, 17 Nov 2020 12:27:21 +0100 (CET)", "by mail-wr1-f67.google.com with SMTP id d12so22762240wrr.13\n for <dev@dpdk.org>; Tue, 17 Nov 2020 03:27:21 -0800 (PST)", "from bolet.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n [62.23.145.78])\n by smtp.gmail.com with ESMTPSA id o17sm3136265wmd.34.2020.11.17.03.27.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Nov 2020 03:27:19 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=vMCnc/1tFsVP8Qd+rcwb7LVDrrSJzHqzDQKu78Zh8y8=;\n b=DVJXnPQTTE//UOcwurqnk0z5O1kcL4ouDQuMEod3g4veuNA6dVcqRYknkX4Sjo9juE\n LJRAxmeGLY4bza2X8OpU1F04G1Dp/pdorDxRhNwKyH0L/to2+u++7jeU8lHAi3zslCcj\n +/0z871TouS0Z51GtZ1uIo2bsejm4LOEGi65UPfzt9g9RKRT3Wycjs8PNrxdgZUW/a6M\n n++D2YpteAWgglmTnJQyJEbArQJRSjB+BoiwBzq8VkGZ9ELEqpSiG/eXrMGs69I7JcI2\n DXI6SGKDpSfs54Z53VHcwKYJyIIocQY+GJRcKfDWqnwGDFGLaxSQR7Vg3NoUwEpLskur\n 7gig==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=vMCnc/1tFsVP8Qd+rcwb7LVDrrSJzHqzDQKu78Zh8y8=;\n b=Cz8lNlSObaiP61WEPA8BbY64uzllHpUIW42FIucZWc8sgh8Vk5MxiGL5BVBHWAnyoO\n 7wMkXTVmuPi6MMpbtVQX3nTWF+tNlQd4nu6wrCwghzF23+wIkawPYc995NVnLWYH3jKr\n w0MEteSXjOBFNfdAtvjYppWE5VPvvihfOlWDMpDpid4eYI7FiVjALSWwq3t7ANplega+\n fzMsQ5CSakHg/PmTSJttoAjBbq+SaphmrLYFH8MZ509e/4BAC7+N+TDaJgPl4Sa7bYWC\n Kv+EsQ107fcZ22aq1FAJIVWUexVDJc6XtzH54UvLZVqzXTR5TE0nSsqUukLViBSU7N3G\n cvbA==", "X-Gm-Message-State": "AOAM532ijZ1nAJmWtR3rYg3Xdi8nGCr6AEpHm3UmBO1gnZEjwdzThQSV\n c6y8DhBivU1NaDUEy5AT7t5Fcw==", "X-Google-Smtp-Source": "\n ABdhPJwNfoeM3HGOeTG62O7qR5bbwE3fA+JaAEro91kdh96Larsm/i7KFSnavf7QfJClOR0kS7z/pA==", "X-Received": "by 2002:a5d:54c7:: with SMTP id x7mr25156169wrv.359.1605612440136;\n Tue, 17 Nov 2020 03:27:20 -0800 (PST)", "From": "Maxime Leroy <maxime.leroy@6wind.com>", "To": "Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Olivier Matz <olivier.matz@6wind.com>", "Cc": "dev@dpdk.org,\n\tDidier Pallard <didier.pallard@6wind.com>", "Date": "Tue, 17 Nov 2020 12:26:47 +0100", "Message-Id": "<20201117112648.29725-3-maxime.leroy@6wind.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201117112648.29725-1-maxime.leroy@6wind.com>", "References": "<20201117112648.29725-1-maxime.leroy@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 2/2] net/mlx5: fix Rx descriptor status\n\treturned value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Didier Pallard <didier.pallard@6wind.com>\n\nThree bugs in rx_queue_count function:\n- One entry may contain several segments, so 'used' must be multiplied\n by number of segments per entry to properly reflect the queue usage.\n- The number of cqes is equals to (1U << rxq->elts_n) - 1 in SPRQ mode.\n The range returned by rx_queue_count should be the number of entries\n used in queue, so it ranges from 0 to max number of entries\n in queue, not this number minus one.\n- For MPRQ mode, we need to take into account of the number of strd.\n\nFixes: 8788fec1f269 (\"net/mlx5: implement descriptor status API\")\nSigned-off-by: Didier Pallard <didier.pallard@6wind.com>\nSigned-off-by: Maxime Leroy <maxime.leroy@6wind.com>\n---\n drivers/net/mlx5/mlx5_rxtx.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex 2733dcd3..2ecf901f 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -463,6 +463,9 @@ rx_queue_count(struct mlx5_rxq_data *rxq)\n \tstruct rxq_zip *zip = &rxq->zip;\n \tvolatile struct mlx5_cqe *cqe;\n \tconst unsigned int cqe_n = (1 << rxq->cqe_n);\n+\tconst unsigned int sges_n = (1 << rxq->sges_n);\n+\tconst unsigned int elts_n = (1 << rxq->elts_n);\n+\tconst unsigned int strd_n = (1 << rxq->strd_num_n);\n \tconst unsigned int cqe_cnt = cqe_n - 1;\n \tunsigned int cq_ci, used;\n \n@@ -488,7 +491,7 @@ rx_queue_count(struct mlx5_rxq_data *rxq)\n \t\tused += n;\n \t\tcqe = &(*rxq->cqes)[cq_ci & cqe_cnt];\n \t}\n-\tused = RTE_MIN(used, cqe_n);\n+\tused = RTE_MIN(used * sges_n, elts_n * strd_n);\n \treturn used;\n }\n \n", "prefixes": [ "v4", "2/2" ] }