Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84207/?format=api
{ "id": 84207, "url": "https://patches.dpdk.org/api/patches/84207/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/141eb0140301108b1320ecfd93c89e48b02cd546.1605493464.git.jackmin@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<141eb0140301108b1320ecfd93c89e48b02cd546.1605493464.git.jackmin@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/141eb0140301108b1320ecfd93c89e48b02cd546.1605493464.git.jackmin@nvidia.com", "date": "2020-11-16T07:55:16", "name": "[3/5] net/bnxt: fix protocol size for VXLAN encap copy", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "0c28a56cbefd1fa0b4271e19fe21183aa2d67076", "submitter": { "id": 1065, "url": "https://patches.dpdk.org/api/people/1065/?format=api", "name": "Xiaoyu Min", "email": "jackmin@mellanox.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/141eb0140301108b1320ecfd93c89e48b02cd546.1605493464.git.jackmin@nvidia.com/mbox/", "series": [ { "id": 13896, "url": "https://patches.dpdk.org/api/series/13896/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13896", "date": "2020-11-16T07:55:13", "name": "fix protocol size calculation", "version": 1, "mbox": "https://patches.dpdk.org/series/13896/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84207/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84207/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3F9B3A04DB;\n\tMon, 16 Nov 2020 08:56:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C3D3BC8C6;\n\tMon, 16 Nov 2020 08:55:39 +0100 (CET)", "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n by dpdk.org (Postfix) with ESMTP id 23C4A2BF1\n for <dev@dpdk.org>; Mon, 16 Nov 2020 08:55:38 +0100 (CET)" ], "From": "Xiaoyu Min <jackmin@mellanox.com>", "To": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Cc": "dev@dpdk.org,\n\tXiaoyu Min <jackmin@nvidia.com>", "Date": "Mon, 16 Nov 2020 15:55:16 +0800", "Message-Id": "\n <141eb0140301108b1320ecfd93c89e48b02cd546.1605493464.git.jackmin@nvidia.com>", "X-Mailer": "git-send-email 2.24.0.rc0.3.g12a4aeaad8", "In-Reply-To": "<cover.1605493464.git.jackmin@nvidia.com>", "References": "<cover.1605493464.git.jackmin@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/5] net/bnxt: fix protocol size for VXLAN encap\n\tcopy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Xiaoyu Min <jackmin@nvidia.com>\n\nThe rte_flow_item_eth and rte_flow_item_vlan items are refined.\nThe structs do not exactly represent the packet bits captured on the\nwire anymore so should only copy real header instead of the whole struct.\n\nReplace the rte_flow_item_* with the existing corresponding rte_*_hdr.\n\nFixes: 09315fc83861 (\"ethdev: add VLAN attributes to ethernet and VLAN items\")\n\nSigned-off-by: Xiaoyu Min <jackmin@nvidia.com>\n---\n drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\nindex a54c55c5f5..823eeb21b8 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n@@ -3,6 +3,7 @@\n * All rights reserved.\n */\n \n+#include <rte_vxlan.h>\n #include \"bnxt.h\"\n #include \"ulp_template_db_enum.h\"\n #include \"ulp_template_struct.h\"\n@@ -1548,7 +1549,7 @@ ulp_rte_vxlan_encap_act_handler(const struct rte_flow_action *action_item,\n \t\tbuff = &ap->act_details[BNXT_ULP_ACT_PROP_IDX_ENCAP_VTAG];\n \t\tulp_encap_buffer_copy(buff,\n \t\t\t\t item->spec,\n-\t\t\t\t sizeof(struct rte_flow_item_vlan),\n+\t\t\t\t sizeof(struct rte_vlan_hdr),\n \t\t\t\t ULP_BUFFER_ALIGN_8_BYTE);\n \n \t\tif (!ulp_rte_item_skip_void(&item, 1))\n@@ -1559,15 +1560,15 @@ ulp_rte_vxlan_encap_act_handler(const struct rte_flow_action *action_item,\n \tif (item->type == RTE_FLOW_ITEM_TYPE_VLAN) {\n \t\tvlan_num++;\n \t\tmemcpy(&ap->act_details[BNXT_ULP_ACT_PROP_IDX_ENCAP_VTAG +\n-\t\t sizeof(struct rte_flow_item_vlan)],\n+\t\t sizeof(struct rte_vlan_hdr)],\n \t\t item->spec,\n-\t\t sizeof(struct rte_flow_item_vlan));\n+\t\t sizeof(struct rte_vlan_hdr));\n \t\tif (!ulp_rte_item_skip_void(&item, 1))\n \t\t\treturn BNXT_TF_RC_ERROR;\n \t}\n \t/* Update the vlan count and size of more than one */\n \tif (vlan_num) {\n-\t\tvlan_size = vlan_num * sizeof(struct rte_flow_item_vlan);\n+\t\tvlan_size = vlan_num * sizeof(struct rte_vlan_hdr);\n \t\tvlan_num = tfp_cpu_to_be_32(vlan_num);\n \t\tmemcpy(&ap->act_details[BNXT_ULP_ACT_PROP_IDX_ENCAP_VTAG_NUM],\n \t\t &vlan_num,\n@@ -1726,7 +1727,7 @@ ulp_rte_vxlan_encap_act_handler(const struct rte_flow_action *action_item,\n \t\tBNXT_TF_DBG(ERR, \"vxlan encap does not have vni\\n\");\n \t\treturn BNXT_TF_RC_ERROR;\n \t}\n-\tvxlan_size = sizeof(struct rte_flow_item_vxlan);\n+\tvxlan_size = sizeof(struct rte_vxlan_hdr);\n \t/* copy the vxlan details */\n \tmemcpy(&vxlan_spec, item->spec, vxlan_size);\n \tvxlan_spec.flags = 0x08;\n", "prefixes": [ "3/5" ] }