Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84117/?format=api
{ "id": 84117, "url": "https://patches.dpdk.org/api/patches/84117/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1605267483-13167-2-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1605267483-13167-2-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/1605267483-13167-2-git-send-email-juraj.linkes@pantheon.tech", "date": "2020-11-13T11:37:49", "name": "[v11,01/15] crypto/armv8: replace meson option with pkg-config support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "43fef81574b3ed410fcffef6bceedf486849b4f3", "submitter": { "id": 1626, "url": "https://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1605267483-13167-2-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 13870, "url": "https://patches.dpdk.org/api/series/13870/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13870", "date": "2020-11-13T11:37:48", "name": "Arm build options rework", "version": 11, "mbox": "https://patches.dpdk.org/series/13870/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84117/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84117/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9DE81A09DE;\n\tFri, 13 Nov 2020 12:38:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E452AC876;\n\tFri, 13 Nov 2020 12:38:12 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by dpdk.org (Postfix) with ESMTP id 6A13923D\n for <dev@dpdk.org>; Fri, 13 Nov 2020 12:38:10 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id 326CCB9309;\n Fri, 13 Nov 2020 12:38:06 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id Tviy_9Ddrbmi; Fri, 13 Nov 2020 12:38:05 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id 00BC4B92E2;\n Fri, 13 Nov 2020 12:38:04 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "bruce.richardson@intel.com, Ruifeng.Wang@arm.com,\n Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com,\n Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com,\n ajit.khaparde@broadcom.com, ferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>", "Date": "Fri, 13 Nov 2020 12:37:49 +0100", "Message-Id": "<1605267483-13167-2-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech>", "References": "<1605265789-12932-1-git-send-email-juraj.linkes@pantheon.tech>\n <1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech>", "Subject": "[dpdk-dev] [PATCH v11 01/15] crypto/armv8: replace meson option\n\twith pkg-config support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dharmik Thakkar <dharmik.thakkar@arm.com>\n\nWith pkg-config support available within AArch64crypto library,\nmeson option 'armv8_crypto_dir' can be removed.\nPKG_CONFIG_PATH environment variable should be set appropriately\nto use the crypto library.\n\nSuggested-by: Thomas Monjalon <thomas@monjalon.net>\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n doc/guides/cryptodevs/armv8.rst | 10 ++++++++--\n drivers/crypto/armv8/meson.build | 19 ++++---------------\n meson_options.txt | 2 --\n 3 files changed, 12 insertions(+), 19 deletions(-)", "diff": "diff --git a/doc/guides/cryptodevs/armv8.rst b/doc/guides/cryptodevs/armv8.rst\nindex f0f30fe00..8963f66a2 100644\n--- a/doc/guides/cryptodevs/armv8.rst\n+++ b/doc/guides/cryptodevs/armv8.rst\n@@ -37,11 +37,17 @@ To build DPDK with this virtual crypto PMD, the user is required to:\n \n make\n \n-* Build DPDK with meson option ``-Darmv8_crypto_dir=<path_to_AArch64cryptolib>``:\n+* Add path to `libAArch64crypto.pc` in `PKG_CONFIG_PATH` environment variable:\n \n .. code-block:: console\n \n- meson -Darmv8_crypto_dir=<path_to_AArch64cryptolib> build\n+ export PKG_CONFIG_PATH=<path_to_AArch64cryptolib>/pkgconfig/:$PKG_CONFIG_PATH\n+\n+* Build DPDK:\n+\n+.. code-block:: console\n+\n+ meson build\n ninja -C build\n \n The corresponding device can be created only if the following features\ndiff --git a/drivers/crypto/armv8/meson.build b/drivers/crypto/armv8/meson.build\nindex c445c5bd3..3289a2adc 100644\n--- a/drivers/crypto/armv8/meson.build\n+++ b/drivers/crypto/armv8/meson.build\n@@ -1,24 +1,13 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2019 Arm Limited\n \n-path = get_option('armv8_crypto_dir')\n-if path == ''\n+dep = dependency('libAArch64crypto', required: false)\n+if not dep.found()\n \tbuild = false\n-\treason = 'missing dependency, \"armv8_crypto\"'\n+\treason = 'missing dependency, \"libAArch64crypto\"'\n \tsubdir_done()\n endif\n \n-inc_dir = path\n-\n-lib = cc.find_library('libAArch64crypto', dirs: [path], required: false)\n-if not lib.found()\n-\tbuild = false\n-\treason = 'missing dependency, \"AArch64crypto\"'\n-\tsubdir_done()\n-else\n-\text_deps += lib\n-\tincludes += include_directories(inc_dir)\n-endif\n-\n+ext_deps += dep\n deps += ['bus_vdev']\n sources = files('rte_armv8_pmd.c', 'rte_armv8_pmd_ops.c')\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 9bf18ab6b..e384e6dbb 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -1,7 +1,5 @@\n # Please keep these options sorted alphabetically.\n \n-option('armv8_crypto_dir', type: 'string', value: '',\n-\tdescription: 'path to the armv8_crypto library installation directory')\n option('disable_drivers', type: 'string', value: '',\n \tdescription: 'Comma-separated list of drivers to explicitly disable.')\n option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',\n", "prefixes": [ "v11", "01/15" ] }