Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84104/?format=api
{ "id": 84104, "url": "https://patches.dpdk.org/api/patches/84104/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1605265789-12932-6-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1605265789-12932-6-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/1605265789-12932-6-git-send-email-juraj.linkes@pantheon.tech", "date": "2020-11-13T11:09:39", "name": "[v10,05/15] build: simplify how Arm flags are processed", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "17d5203f65d6a6612840c11d88723b49b9c3cc9e", "submitter": { "id": 1626, "url": "https://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1605265789-12932-6-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 13869, "url": "https://patches.dpdk.org/api/series/13869/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13869", "date": "2020-11-13T11:09:35", "name": "Arm build options rework", "version": 10, "mbox": "https://patches.dpdk.org/series/13869/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84104/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/84104/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4E214A09DE;\n\tFri, 13 Nov 2020 12:11:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 45CC3C8D4;\n\tFri, 13 Nov 2020 12:10:13 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by dpdk.org (Postfix) with ESMTP id 605C0C876\n for <dev@dpdk.org>; Fri, 13 Nov 2020 12:10:03 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id 43DD8B997B;\n Fri, 13 Nov 2020 12:10:00 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id XWzYAt1tpHA2; Fri, 13 Nov 2020 12:09:59 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id E64CAB931F;\n Fri, 13 Nov 2020 12:09:54 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "bruce.richardson@intel.com, Ruifeng.Wang@arm.com,\n Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com,\n Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com,\n ajit.khaparde@broadcom.com, ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Date": "Fri, 13 Nov 2020 12:09:39 +0100", "Message-Id": "<1605265789-12932-6-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1605265789-12932-1-git-send-email-juraj.linkes@pantheon.tech>", "References": "<1605100718-7991-1-git-send-email-juraj.linkes@pantheon.tech>\n <1605265789-12932-1-git-send-email-juraj.linkes@pantheon.tech>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v10 05/15] build: simplify how Arm flags are\n\tprocessed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Set flags in one loop. Append flags to a list and use the list in the\nloop.\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n config/arm/meson.build | 37 +++++++++++++++++--------------------\n 1 file changed, 17 insertions(+), 20 deletions(-)", "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 7ab856143..0f8a94ffe 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -150,7 +150,6 @@ if dpdk_conf.get('RTE_ARCH_32')\n else\n \t# aarch64 build\n \timplementer_id = 'generic'\n-\tmachine_args = [] # Clear previous machine args\n \tif machine == 'generic' and not meson.is_cross_build()\n \t\t# generic build\n \t\timplementer_config = implementer_generic\n@@ -183,34 +182,32 @@ else\n \t\timplementer_config = get_variable('implementer_' + implementer_id)\n \tendif\n \n-\t# Apply Common Defaults. These settings may be overwritten by machine\n-\t# settings later.\n-\tforeach flag: flags_common\n-\t\tif flag.length() > 0\n-\t\t\tdpdk_conf.set(flag[0], flag[1])\n-\t\tendif\n-\tendforeach\n+\tmessage('Arm implementer: ' + implementer_config[0])\n+\tmessage('Arm part number: ' + part_number)\n \n-\tmessage('Implementer : ' + implementer_config[0])\n-\tforeach flag: implementer_config[1]\n-\t\tif flag.length() > 0\n-\t\t\tdpdk_conf.set(flag[0], flag[1])\n-\t\tendif\n-\tendforeach\n+\t# use default flags with implementer flags\n+\tdpdk_flags = flags_common + implementer_config[1]\n \n+\tmachine_args = [] # Clear previous machine args\n \tforeach marg: implementer_config[2]\n \t\tif marg[0] == part_number\n+\t\t\t# apply supported machine args\n \t\t\tforeach flag: marg[1]\n \t\t\t\tif cc.has_argument(flag)\n \t\t\t\t\tmachine_args += flag\n \t\t\t\tendif\n \t\t\tendforeach\n-\t\t\t# Apply any extra machine specific flags.\n-\t\t\tforeach flag: marg.get(2, [])\n-\t\t\t\tif flag.length() > 0\n-\t\t\t\t\tdpdk_conf.set(flag[0], flag[1])\n-\t\t\t\tendif\n-\t\t\tendforeach\n+\t\t\tif marg.length() > 2\n+\t\t\t\t# add extra flags for the part\n+\t\t\t\tdpdk_flags += marg[2]\n+\t\t\tendif\n+\t\tendif\n+\tendforeach\n+\n+\t# apply flags\n+\tforeach flag: dpdk_flags\n+\t\tif flag.length() > 0\n+\t\t\tdpdk_conf.set(flag[0], flag[1])\n \t\tendif\n \tendforeach\n endif\n", "prefixes": [ "v10", "05/15" ] }