Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 84103,
    "url": "https://patches.dpdk.org/api/patches/84103/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1605265789-12932-4-git-send-email-juraj.linkes@pantheon.tech/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1605265789-12932-4-git-send-email-juraj.linkes@pantheon.tech>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1605265789-12932-4-git-send-email-juraj.linkes@pantheon.tech",
    "date": "2020-11-13T11:09:37",
    "name": "[v10,03/15] build: remove unused or superfluous variables",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "87eb6d0890178833769bdaa8a151f866d5effa48",
    "submitter": {
        "id": 1626,
        "url": "https://patches.dpdk.org/api/people/1626/?format=api",
        "name": "Juraj Linkeš",
        "email": "juraj.linkes@pantheon.tech"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1605265789-12932-4-git-send-email-juraj.linkes@pantheon.tech/mbox/",
    "series": [
        {
            "id": 13869,
            "url": "https://patches.dpdk.org/api/series/13869/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13869",
            "date": "2020-11-13T11:09:35",
            "name": "Arm build options rework",
            "version": 10,
            "mbox": "https://patches.dpdk.org/series/13869/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/84103/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/84103/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB3C1A09DE;\n\tFri, 13 Nov 2020 12:10:59 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2B453C8C4;\n\tFri, 13 Nov 2020 12:10:07 +0100 (CET)",
            "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by dpdk.org (Postfix) with ESMTP id A54B5C87A\n for <dev@dpdk.org>; Fri, 13 Nov 2020 12:10:00 +0100 (CET)",
            "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id 6DE4EB9979;\n Fri, 13 Nov 2020 12:09:57 +0100 (CET)",
            "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id KntGYrWeaA22; Fri, 13 Nov 2020 12:09:55 +0100 (CET)",
            "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id 5B752B92ED;\n Fri, 13 Nov 2020 12:09:52 +0100 (CET)"
        ],
        "X-Virus-Scanned": "amavisd-new at siecit.sk",
        "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>",
        "To": "bruce.richardson@intel.com, Ruifeng.Wang@arm.com,\n Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com,\n Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com,\n ajit.khaparde@broadcom.com, ferruh.yigit@intel.com",
        "Cc": "dev@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>",
        "Date": "Fri, 13 Nov 2020 12:09:37 +0100",
        "Message-Id": "<1605265789-12932-4-git-send-email-juraj.linkes@pantheon.tech>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1605265789-12932-1-git-send-email-juraj.linkes@pantheon.tech>",
        "References": "<1605100718-7991-1-git-send-email-juraj.linkes@pantheon.tech>\n <1605265789-12932-1-git-send-email-juraj.linkes@pantheon.tech>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v10 03/15] build: remove unused or superfluous\n\tvariables",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Remove variables that were either not used, referenced just once or not\nneeded.\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n config/arm/meson.build | 28 +++++++---------------------\n 1 file changed, 7 insertions(+), 21 deletions(-)",
    "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 704be567d..ee9277b5d 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -3,11 +3,7 @@\n # Copyright(c) 2017 Cavium, Inc\n # Copyright(c) 2020 PANTHEON.tech s.r.o.\n \n-# for checking defines we need to use the correct compiler flags\n-march_opt = '-march=@0@'.format(machine)\n-\n arm_force_native_march = false\n-arm_force_generic_march = (machine == 'generic')\n \n flags_common = [\n \t# Accelarate rte_memcpy. Be sure to run unit test (memcpy_perf_autotest)\n@@ -62,7 +58,6 @@ flags_implementer_armada = [\n \t['RTE_MAX_NUMA_NODES', 1],\n \t['RTE_MAX_LCORE', 16]]\n \n-flags_part_number_default = []\n flags_part_number_thunderx = [\n \t['RTE_MACHINE', '\"thunderx\"'],\n \t['RTE_USE_C11_MEM_MODEL', false]]\n@@ -119,17 +114,9 @@ part_number_config_emag = [\n ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321)\n implementer_generic = ['Generic armv8', flags_implementer_generic, part_number_config_arm]\n implementer_0x41 = ['Arm', flags_implementer_arm, part_number_config_arm]\n-implementer_0x42 = ['Broadcom', flags_implementer_generic, part_number_config_arm]\n implementer_0x43 = ['Cavium', flags_implementer_cavium, part_number_config_cavium]\n-implementer_0x44 = ['DEC', flags_implementer_generic, part_number_config_arm]\n-implementer_0x49 = ['Infineon', flags_implementer_generic, part_number_config_arm]\n-implementer_0x4d = ['Motorola', flags_implementer_generic, part_number_config_arm]\n-implementer_0x4e = ['NVIDIA', flags_implementer_generic, part_number_config_arm]\n implementer_0x50 = ['Ampere Computing', flags_implementer_emag, part_number_config_emag]\n-implementer_0x51 = ['Qualcomm', flags_implementer_generic, part_number_config_arm]\n-implementer_0x53 = ['Samsung', flags_implementer_generic, part_number_config_arm]\n implementer_0x56 = ['Marvell ARMADA', flags_implementer_armada, part_number_config_arm]\n-implementer_0x69 = ['Intel', flags_implementer_generic, part_number_config_arm]\n implementer_dpaa = ['NXP DPAA', flags_implementer_dpaa, part_number_config_arm]\n \n dpdk_conf.set('RTE_ARCH_ARM', 1)\n@@ -145,11 +132,9 @@ else\n \tdpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)\n \tdpdk_conf.set('RTE_ARCH_ARM64', 1)\n \n-\timplementer_config = []\n-\tcmd_generic = ['generic', '', '', 'generic', '']\n-\tcmd_output = cmd_generic # Set generic by default\n+\timplementer_id = 'generic'\n \tmachine_args = [] # Clear previous machine args\n-\tif arm_force_generic_march and not meson.is_cross_build()\n+\tif machine == 'generic' and not meson.is_cross_build()\n \t\timplementer_config = implementer_generic\n \t\tpart_number = 'generic'\n \telif not meson.is_cross_build()\n@@ -160,14 +145,15 @@ else\n \t\tcmd = run_command(detect_vendor.path())\n \t\tif cmd.returncode() == 0\n \t\t\tcmd_output = cmd.stdout().to_lower().strip().split(' ')\n+\t\t\timplementer_id = cmd_output[0]\n+\t\t\tpart_number = cmd_output[3]\n \t\tendif\n \t\t# Set to generic if variable is not found\n-\t\timplementer_config = get_variable('implementer_' + cmd_output[0], ['generic'])\n+\t\timplementer_config = get_variable('implementer_' + implementer_id, ['generic'])\n \t\tif implementer_config[0] == 'generic'\n \t\t\timplementer_config = implementer_generic\n-\t\t\tcmd_output = cmd_generic\n+\t\t\tpart_number = 'generic'\n \t\tendif\n-\t\tpart_number = cmd_output[3]\n \t\tif arm_force_native_march == true\n \t\t\tpart_number = 'native'\n \t\tendif\n@@ -200,7 +186,7 @@ else\n \t\t\t\tendif\n \t\t\tendforeach\n \t\t\t# Apply any extra machine specific flags.\n-\t\t\tforeach flag: marg.get(2, flags_part_number_default)\n+\t\t\tforeach flag: marg.get(2, [])\n \t\t\t\tif flag.length() > 0\n \t\t\t\t\tdpdk_conf.set(flag[0], flag[1])\n \t\t\t\tendif\n",
    "prefixes": [
        "v10",
        "03/15"
    ]
}