Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84054/?format=api
{ "id": 84054, "url": "https://patches.dpdk.org/api/patches/84054/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201112103157.53486-1-ruifeng.wang@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201112103157.53486-1-ruifeng.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201112103157.53486-1-ruifeng.wang@arm.com", "date": "2020-11-12T10:31:57", "name": "[v1] eal/arm: fix clang build of native target", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ba45d0938ccd124184ca8d5771448af8acac8d8b", "submitter": { "id": 1198, "url": "https://patches.dpdk.org/api/people/1198/?format=api", "name": "Ruifeng Wang", "email": "ruifeng.wang@arm.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201112103157.53486-1-ruifeng.wang@arm.com/mbox/", "series": [ { "id": 13836, "url": "https://patches.dpdk.org/api/series/13836/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13836", "date": "2020-11-12T10:31:57", "name": "[v1] eal/arm: fix clang build of native target", "version": 1, "mbox": "https://patches.dpdk.org/series/13836/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/84054/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/84054/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ECDA6A09D3;\n\tThu, 12 Nov 2020 11:32:16 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2E1A15928;\n\tThu, 12 Nov 2020 11:32:15 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 48D7B56A3;\n Thu, 12 Nov 2020 11:32:13 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B88C9139F;\n Thu, 12 Nov 2020 02:32:11 -0800 (PST)", "from net-arm-kp920-01.shanghai.arm.com\n (net-arm-kp920-01.shanghai.arm.com [10.169.210.104])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 00E7B3F73C;\n Thu, 12 Nov 2020 02:32:08 -0800 (PST)" ], "From": "Ruifeng Wang <ruifeng.wang@arm.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n David Marchand <david.marchand@redhat.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Phil Yang <phil.yang@arm.com>", "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tstable@dpdk.org", "Date": "Thu, 12 Nov 2020 18:31:57 +0800", "Message-Id": "<20201112103157.53486-1-ruifeng.wang@arm.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] eal/arm: fix clang build of native target", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When doing Clang build with '-mcpu=native' on N1 platform, build failed\nwith:\n../lib/librte_eal/arm/include/rte_atomic_64.h:76:39:\n\terror: instruction requires: lse\n__ATOMIC128_CAS_OP(__cas_128_release, \"caspl\")\n\nThis is because native detection for Neoverse N1 was added in Clang-11.\nPrior version of Clang's assembler doesn't know LSE support on hardware.\nFixed this for Clang earlier than version 11 by specifying architecture\nfor assembler.\nReferred to [1] for this fix.\n\nFixes: 7e2c3e17fe2c (\"eal/arm64: add 128-bit atomic compare exchange\")\nCc: stable@dpdk.org\n\n[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e0d5896bd356cd577f9710a02d7a474cdf58426b\n\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/librte_eal/arm/include/rte_atomic_64.h | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/lib/librte_eal/arm/include/rte_atomic_64.h b/lib/librte_eal/arm/include/rte_atomic_64.h\nindex 2cef88629..7fcd17466 100644\n--- a/lib/librte_eal/arm/include/rte_atomic_64.h\n+++ b/lib/librte_eal/arm/include/rte_atomic_64.h\n@@ -46,6 +46,8 @@ rte_atomic_thread_fence(int memorder)\n /*------------------------ 128 bit atomic operations -------------------------*/\n \n #if defined(__ARM_FEATURE_ATOMICS) || defined(RTE_ARM_FEATURE_ATOMICS)\n+#define __LSE_PREAMBLE\t\".arch armv8-a+lse\\n\"\n+\n #define __ATOMIC128_CAS_OP(cas_op_name, op_string) \\\n static __rte_noinline rte_int128_t \\\n cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) \\\n@@ -59,6 +61,7 @@ cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) \\\n \tregister uint64_t x2 __asm(\"x2\") = (uint64_t)updated.val[0]; \\\n \tregister uint64_t x3 __asm(\"x3\") = (uint64_t)updated.val[1]; \\\n \tasm volatile( \\\n+\t\t__LSE_PREAMBLE\t\t\t\t\t\t \\\n \t\top_string \" %[old0], %[old1], %[upd0], %[upd1], [%[dst]]\" \\\n \t\t: [old0] \"+r\" (x0), \\\n \t\t[old1] \"+r\" (x1) \\\n@@ -76,6 +79,7 @@ __ATOMIC128_CAS_OP(__cas_128_acquire, \"caspa\")\n __ATOMIC128_CAS_OP(__cas_128_release, \"caspl\")\n __ATOMIC128_CAS_OP(__cas_128_acq_rel, \"caspal\")\n \n+#undef __LSE_PREAMBLE\n #undef __ATOMIC128_CAS_OP\n \n #endif\n", "prefixes": [ "v1" ] }