Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8392/?format=api
{ "id": 8392, "url": "https://patches.dpdk.org/api/patches/8392/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1446210879-14242-2-git-send-email-jijiang.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1446210879-14242-2-git-send-email-jijiang.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1446210879-14242-2-git-send-email-jijiang.liu@intel.com", "date": "2015-10-30T13:14:38", "name": "[dpdk-dev,v2,1/2] lib/lpm:fix an issue of condition check in delete_depth_small()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "78ba95cf89100dca4c6410d9489c2bde92199050", "submitter": { "id": 52, "url": "https://patches.dpdk.org/api/people/52/?format=api", "name": "Jijiang Liu", "email": "jijiang.liu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1446210879-14242-2-git-send-email-jijiang.liu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8392/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8392/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DA5769190;\n\tFri, 30 Oct 2015 14:14:59 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 7708A9190\n\tfor <dev@dpdk.org>; Fri, 30 Oct 2015 14:14:57 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 30 Oct 2015 06:14:56 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 30 Oct 2015 06:14:48 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9UDEl8i021652;\n\tFri, 30 Oct 2015 21:14:47 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9UDEi57014284; Fri, 30 Oct 2015 21:14:46 +0800", "(from jijiangl@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9UDEiJ9014280; \n\tFri, 30 Oct 2015 21:14:44 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,218,1444719600\"; d=\"scan'208\";a=\"675038111\"", "From": "Jijiang Liu <jijiang.liu@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 30 Oct 2015 21:14:38 +0800", "Message-Id": "<1446210879-14242-2-git-send-email-jijiang.liu@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1446210879-14242-1-git-send-email-jijiang.liu@intel.com>", "References": "<1446210879-14242-1-git-send-email-jijiang.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/2] lib/lpm:fix an issue of condition check\n\tin delete_depth_small()", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixes an issue of check logic in delete_depth_small function.\n\nFor a tbl24 entry, the 'ext_entry' field indicates whether we need to use tbl8_gindex to read the next_hop from a tbl8 entry, or whether it can be read directly from this entry.\n\nIf a route is deleted, the prefix of previous route is used to override the deleted route.\n\nWhen checking the depth of the previous route the conditional checks both the ext_entry and the depth, but the \"else\" leg fails to take account that the condition could fail for one of two possible reasons, leading to an incorrect flow when 'ext_entry == 0' is true , but 'lpm->tbl24[i].depth > depth' is false. The fix here is to add a condition check to the else leg so that it only executes when ext_entry is set.\n\nSigned-off-by: NaNa <nana.nn@alibaba-inc.com>\n\n---\n lib/librte_lpm/rte_lpm.c | 6 ++----\n 1 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c\nindex 163ba3c..57ec2f0 100644\n--- a/lib/librte_lpm/rte_lpm.c\n+++ b/lib/librte_lpm/rte_lpm.c\n@@ -734,8 +734,7 @@ delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked,\n \t\t\tif (lpm->tbl24[i].ext_entry == 0 &&\n \t\t\t\t\tlpm->tbl24[i].depth <= depth ) {\n \t\t\t\tlpm->tbl24[i].valid = INVALID;\n-\t\t\t}\n-\t\t\telse {\n+\t\t\t} else if (lpm->tbl24[i].ext_entry == 1) {\n \t\t\t\t/*\n \t\t\t\t * If TBL24 entry is extended, then there has\n \t\t\t\t * to be a rule with depth >= 25 in the\n@@ -780,8 +779,7 @@ delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked,\n \t\t\tif (lpm->tbl24[i].ext_entry == 0 &&\n \t\t\t\t\tlpm->tbl24[i].depth <= depth ) {\n \t\t\t\tlpm->tbl24[i] = new_tbl24_entry;\n-\t\t\t}\n-\t\t\telse {\n+\t\t\t} else if (lpm->tbl24[i].ext_entry == 1) {\n \t\t\t\t/*\n \t\t\t\t * If TBL24 entry is extended, then there has\n \t\t\t\t * to be a rule with depth >= 25 in the\n", "prefixes": [ "dpdk-dev", "v2", "1/2" ] }