Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83857/?format=api
{ "id": 83857, "url": "https://patches.dpdk.org/api/patches/83857/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201109145506.1758827-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201109145506.1758827-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201109145506.1758827-1-ferruh.yigit@intel.com", "date": "2020-11-09T14:55:06", "name": "[v2] devtools: fix 32-bits build", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "cf58ffdea32a4dcf79a91ab0d62b01e3191ae7d1", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201109145506.1758827-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 13749, "url": "https://patches.dpdk.org/api/series/13749/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13749", "date": "2020-11-09T14:55:06", "name": "[v2] devtools: fix 32-bits build", "version": 2, "mbox": "https://patches.dpdk.org/series/13749/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83857/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/83857/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35C45A0527;\n\tMon, 9 Nov 2020 15:55:14 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 14E985B3A;\n\tMon, 9 Nov 2020 15:55:13 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 4C83D5B30\n for <dev@dpdk.org>; Mon, 9 Nov 2020 15:55:10 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Nov 2020 06:55:09 -0800", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.180])\n by orsmga004.jf.intel.com with ESMTP; 09 Nov 2020 06:55:07 -0800" ], "IronPort-SDR": [ "\n 090cxLj0RRwKJ+7M1PXKDl1Mmq+TWMednmm+gRT0ThxUBoGUtJ6Nk6o7dJ+w3Tz9AytepsGp9T\n MAHOBcBSSkxg==", "\n fqdPPmiYGmNh/UyHzOJ55iRqwSbAlJjjsMBSZJ5TH2q9JVWKtqxC3P8cb8bfkUwx+lNnJ3rQNG\n lyHeVEAkjZ9g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9799\"; a=\"231444600\"", "E=Sophos;i=\"5.77,463,1596524400\"; d=\"scan'208\";a=\"231444600\"", "E=Sophos;i=\"5.77,463,1596524400\"; d=\"scan'208\";a=\"473004923\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,\n david.marchand@redhat.com", "Date": "Mon, 9 Nov 2020 14:55:06 +0000", "Message-Id": "<20201109145506.1758827-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20201109130035.3948462-1-ferruh.yigit@intel.com>", "References": "<20201109130035.3948462-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] devtools: fix 32-bits build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If the 'PKG_CONFIG_PATH' is set in the environment before script run,\n32 bit still uses that value for 64-bits libraries.\n\nFrom the build log:\n\n\"\nUsing DPDK_TARGET i386-pc-linux-gnu\nmeson -Dexamples=l3fwd --buildtype=debugoptimized --werror\n-Dc_args=-m32 -Dc_link_args=-m32\n/tmp/dpdk_maintain/self/dpdk/devtools/.. ./build-32b\n...\nUsing 'PKG_CONFIG_PATH' from environment with value:\n'/usr/local/lib64/pkgconfig/\n\"\n\nThis causes build error when linking with the found libraries.\n\nReproduced with 'librte_bpf' which only has 64 bit installed but still\nenables building 'af_xdp' and link fails.\n\nTo fix this, using default 'PKG_CONFIG_PATH' variable unless\n'CUSTOM_PKG_CONFIG_PATH' set, and set the 'CUSTOM_PKG_CONFIG_PATH' for\n32 bit build.\n\nFixes: 9b83106d8784 (\"devtools: test 32-bit build\")\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nCc: Bruce Richardson <bruce.richardson@intel.com>\nCc: Thomas Monjalon <thomas@monjalon.net>\n\nv2:\n* Enable overwriting default 'PKG_CONFIG_PATH' value\n---\n devtools/test-meson-builds.sh | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex 0c95d1cc98..29aed9ac84 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -53,7 +53,11 @@ load_env () # <target compiler>\n {\n \ttargetcc=$1\n \texport PATH=$default_path\n-\texport PKG_CONFIG_PATH=$default_pkgpath\n+\tif [ -n \"$CUSTOM_PKG_CONFIG_PATH\" ]; then\n+\t\texport PKG_CONFIG_PATH=$CUSTOM_PKG_CONFIG_PATH\n+\telse\n+\t\texport PKG_CONFIG_PATH=$default_pkgpath\n+\tfi\n \texport CPPFLAGS=$default_cppflags\n \texport CFLAGS=$default_cflags\n \texport LDFLAGS=$default_ldflags\n@@ -226,10 +230,12 @@ if check_cc_flags '-m32' ; then\n \t\t# 32-bit pkgconfig on RHEL/Fedora (lib vs lib64)\n \t\texport PKG_CONFIG_LIBDIR='/usr/lib/pkgconfig'\n \tfi\n+\texport CUSTOM_PKG_CONFIG_PATH=$PKG_CONFIG_LIBDIR\n \ttarget_override='i386-pc-linux-gnu'\n \tbuild build-32b cc -Dc_args='-m32' -Dc_link_args='-m32'\n \ttarget_override=\n \tunset PKG_CONFIG_LIBDIR\n+\tunset CUSTOM_PKG_CONFIG_PATH\n fi\n \n # x86 MinGW\n", "prefixes": [ "v2" ] }