Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83722/?format=api
{ "id": 83722, "url": "https://patches.dpdk.org/api/patches/83722/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201105114549.97717-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201105114549.97717-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201105114549.97717-3-maxime.coquelin@redhat.com", "date": "2020-11-05T11:45:48", "name": "[2/3] vhost: fix fd leak in dirty logging setup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2372afacff880f32db8d61cfe35670d5e040c2c1", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201105114549.97717-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 13687, "url": "https://patches.dpdk.org/api/series/13687/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13687", "date": "2020-11-05T11:45:46", "name": "vhost: fix fd an memory leaks", "version": 1, "mbox": "https://patches.dpdk.org/series/13687/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83722/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/83722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF342A04B1;\n\tThu, 5 Nov 2020 12:46:49 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4B683C7F2;\n\tThu, 5 Nov 2020 12:46:11 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [63.128.21.124])\n by dpdk.org (Postfix) with ESMTP id B82F0C30F\n for <dev@dpdk.org>; Thu, 5 Nov 2020 12:46:08 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-282-4SfaRS9IOMuOlKEmDLVe7A-1; Thu, 05 Nov 2020 06:46:03 -0500", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com\n [10.5.11.14])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D3EA85F9D2;\n Thu, 5 Nov 2020 11:46:01 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.110.29])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 013E15D9D5;\n Thu, 5 Nov 2020 11:45:59 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1604576767;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=AyZ9KbxwRDASTYStxoPP6fJGqyGHnI6EtIZFcQa87Pk=;\n b=WMdOUxgO2NW4sb8LgMMperyX96EYI8QuX270QQzT5RJZ5KRDxWsQroSLSyfqxWAkolgjrG\n MjxsVo8gL3PZtYAUGMLk7TDdb1X0KQ8Rqt7TDcQGys0L+t6iXDYzJOVorSqro4moh9NFcl\n Q9vTUF5cS7iAIE4ySI48/Eykp3oxEK4=", "X-MC-Unique": "4SfaRS9IOMuOlKEmDLVe7A-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, xuan.ding@intel.com, stephen@networkplumber.org,\n ferruh.yigit@intel.com, thomas@monjalon.net, chenbo.xia@intel.com", "Cc": "stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 5 Nov 2020 12:45:48 +0100", "Message-Id": "<20201105114549.97717-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20201105114549.97717-1-maxime.coquelin@redhat.com>", "References": "<20201105114549.97717-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 2/3] vhost: fix fd leak in dirty logging setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes a file descriptor leak which happens\nin the error path of vhost_user_set_log_base().\n\nFixes: 4796ad63ba1f (\"examples/vhost: import userspace vhost application\")\nCc: stable@dpdk.org\n\nReported-by: Xuan Ding <xuan.ding@intel.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 473fd778ca..7dfda15991 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -2076,14 +2076,14 @@ vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \n \tif (fd < 0) {\n \t\tVHOST_LOG_CONFIG(ERR, \"invalid log fd: %d\\n\", fd);\n-\t\treturn RTE_VHOST_MSG_RESULT_ERR;\n+\t\tgoto close_msg_fds;\n \t}\n \n \tif (msg->size != sizeof(VhostUserLog)) {\n \t\tVHOST_LOG_CONFIG(ERR,\n \t\t\t\"invalid log base msg size: %\"PRId32\" != %d\\n\",\n \t\t\tmsg->size, (int)sizeof(VhostUserLog));\n-\t\treturn RTE_VHOST_MSG_RESULT_ERR;\n+\t\tgoto close_msg_fds;\n \t}\n \n \tsize = msg->payload.log.mmap_size;\n@@ -2094,7 +2094,7 @@ vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \t\tVHOST_LOG_CONFIG(ERR,\n \t\t\t\"log offset %#\"PRIx64\" and log size %#\"PRIx64\" overflow\\n\",\n \t\t\toff, size);\n-\t\treturn RTE_VHOST_MSG_RESULT_ERR;\n+\t\tgoto close_msg_fds;\n \t}\n \n \tVHOST_LOG_CONFIG(INFO,\n@@ -2131,6 +2131,10 @@ vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \tmsg->fd_num = 0;\n \n \treturn RTE_VHOST_MSG_RESULT_REPLY;\n+\n+close_msg_fds:\n+\tclose_msg_fds(msg);\n+\treturn RTE_VHOST_MSG_RESULT_ERR;\n }\n \n static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,\n", "prefixes": [ "2/3" ] }