Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83708/?format=api
{ "id": 83708, "url": "https://patches.dpdk.org/api/patches/83708/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1604541940-5994-2-git-send-email-wei.huang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1604541940-5994-2-git-send-email-wei.huang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1604541940-5994-2-git-send-email-wei.huang@intel.com", "date": "2020-11-05T02:05:39", "name": "[v2,1/2] raw/ifpga/base: unlock mutex when nios init fail", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1a6f742db3c169a0380192d752b662a63c1aaf83", "submitter": { "id": 2033, "url": "https://patches.dpdk.org/api/people/2033/?format=api", "name": "Wei Huang", "email": "wei.huang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1604541940-5994-2-git-send-email-wei.huang@intel.com/mbox/", "series": [ { "id": 13679, "url": "https://patches.dpdk.org/api/series/13679/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13679", "date": "2020-11-05T02:05:38", "name": "raw/ifpga/base: fix defects found by coverity scan", "version": 2, "mbox": "https://patches.dpdk.org/series/13679/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83708/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/83708/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EB2BEA04B1;\n\tThu, 5 Nov 2020 04:06:12 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EE07F5AB3;\n\tThu, 5 Nov 2020 04:05:53 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id A5652592C;\n Thu, 5 Nov 2020 04:05:49 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Nov 2020 19:05:37 -0800", "from unknown (HELO sh_lab5_1.sh.intel.com) ([10.238.175.190])\n by orsmga004.jf.intel.com with ESMTP; 04 Nov 2020 19:05:36 -0800" ], "IronPort-SDR": [ "\n QDhruU7cx+hDzQMmc5ZLsWt1ehiJjHJy3s5OKryvWv9FLGV3svnlBju71XYLnW2VPzHz69ymIb\n eg1AcQfSrJkA==", "\n Kg+6zOJZA5dhhPZ1OZcuQBdz7Ahvetwxq0AgC/e7gAFISjmZltySE6RJe9lUrwRNrxg63M0KuO\n LOf5U7An+f4w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9795\"; a=\"165811403\"", "E=Sophos;i=\"5.77,452,1596524400\"; d=\"scan'208\";a=\"165811403\"", "E=Sophos;i=\"5.77,452,1596524400\"; d=\"scan'208\";a=\"471470858\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Wei Huang <wei.huang@intel.com>", "To": "dev@dpdk.org,\n\trosen.xu@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "stable@dpdk.org,\n\tWei Huang <wei.huang@intel.com>", "Date": "Wed, 4 Nov 2020 21:05:39 -0500", "Message-Id": "<1604541940-5994-2-git-send-email-wei.huang@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1604541940-5994-1-git-send-email-wei.huang@intel.com>", "References": "<1604541940-5994-1-git-send-email-wei.huang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/2] raw/ifpga/base: unlock mutex when nios\n\tinit fail", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In fme_nios_spi_init(), a mutex is locked for protecting nios\ninitialization process, the mutex is only unlocked when process\nis successful, it should also be unlocked when process fail.\n\nFixes: e41856b515ce (\"raw/ifpga/base: enhance driver reliability in multi-process\")\nCoverity issue: 363751\n\nSigned-off-by: Wei Huang <wei.huang@intel.com>\n---\n drivers/raw/ifpga/base/ifpga_fme.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c\nindex 540bb1110..f29ff3159 100644\n--- a/drivers/raw/ifpga/base/ifpga_fme.c\n+++ b/drivers/raw/ifpga/base/ifpga_fme.c\n@@ -1115,6 +1115,8 @@ static int fme_nios_spi_init(struct ifpga_feature *feature)\n \tret = nios_spi_wait_init_done(spi_master);\n \tif (ret != 0) {\n \t\tdev_err(fme, \"FME NIOS_SPI init fail\\n\");\n+\t\tif (spi_master->mutex)\n+\t\t\tpthread_mutex_unlock(spi_master->mutex);\n \t\tgoto release_dev;\n \t}\n \n", "prefixes": [ "v2", "1/2" ] }