Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83685/?format=api
{ "id": 83685, "url": "https://patches.dpdk.org/api/patches/83685/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/b29c6bf5012d9b84abfdcb5e198a1fc4da3f2f84.1604499811.git.dekelp@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b29c6bf5012d9b84abfdcb5e198a1fc4da3f2f84.1604499811.git.dekelp@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b29c6bf5012d9b84abfdcb5e198a1fc4da3f2f84.1604499811.git.dekelp@nvidia.com", "date": "2020-11-04T14:25:19", "name": "net/mlx5: fix use of local array for global error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a1daffcd704be9a1699cfcc6875008e9a93e0117", "submitter": { "id": 1897, "url": "https://patches.dpdk.org/api/people/1897/?format=api", "name": "Dekel Peled", "email": "dekelp@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/b29c6bf5012d9b84abfdcb5e198a1fc4da3f2f84.1604499811.git.dekelp@nvidia.com/mbox/", "series": [ { "id": 13664, "url": "https://patches.dpdk.org/api/series/13664/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13664", "date": "2020-11-04T14:25:19", "name": "net/mlx5: fix use of local array for global error", "version": 1, "mbox": "https://patches.dpdk.org/series/13664/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83685/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/83685/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9E5FFA04B1;\n\tWed, 4 Nov 2020 15:25:33 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 01823C92E;\n\tWed, 4 Nov 2020 15:25:32 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id E5AAAC92A\n for <dev@dpdk.org>; Wed, 4 Nov 2020 15:25:29 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@nvidia.com) with SMTP; 4 Nov 2020 16:25:24 +0200", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.228.134.250])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0A4EPO3u010027;\n Wed, 4 Nov 2020 16:25:24 +0200" ], "From": "Dekel Peled <dekelp@nvidia.com>", "To": "viacheslavo@nvidia.com, shahafs@nvidia.com, matan@nvidia.com", "Cc": "dev@dpdk.org", "Date": "Wed, 4 Nov 2020 16:25:19 +0200", "Message-Id": "\n <b29c6bf5012d9b84abfdcb5e198a1fc4da3f2f84.1604499811.git.dekelp@nvidia.com>", "X-Mailer": "git-send-email 1.7.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix use of local array for global error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Recent patch uses a local string array as input for function\nrte_flow_error_set().\nThis stack memory may be later used by other code sections,\noverwriting the desired error string.\n\nThis patch impelemnets an error string for the specific case\nrequested, of ICMP item not supported in Verbs flow engine.\n\nFixes: cb6a02dcea9d (\"net/mlx5: support item type error message in flow Verbs\")\n\nSigned-off-by: Dekel Peled <dekelp@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_verbs.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_flow_verbs.c\nindex 28fd120..04f6b40 100644\n--- a/drivers/net/mlx5/mlx5_flow_verbs.c\n+++ b/drivers/net/mlx5/mlx5_flow_verbs.c\n@@ -1247,7 +1247,6 @@\n \tuint64_t last_item = 0;\n \tuint8_t next_protocol = 0xff;\n \tuint16_t ether_type = 0;\n-\tchar errstr[32];\n \n \tif (items == NULL)\n \t\treturn -1;\n@@ -1398,12 +1397,16 @@\n \t\t\t\treturn ret;\n \t\t\tlast_item = MLX5_FLOW_LAYER_MPLS;\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ITEM_TYPE_ICMP:\n+\t\tcase RTE_FLOW_ITEM_TYPE_ICMP6:\n+\t\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t\t NULL, \"ICMP/ICMP6 \"\n+\t\t\t\t\t\t \"item not supported\");\n \t\tdefault:\n-\t\t\tsnprintf(errstr, sizeof(errstr), \"item type %d not supported\",\n-\t\t\t\t items->type);\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\t\t\t\t NULL, errstr);\n+\t\t\t\t\t\t NULL, \"item not supported\");\n \t\t}\n \t\titem_flags |= last_item;\n \t}\n@@ -1698,7 +1701,6 @@\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tstruct mlx5_flow_workspace *wks = mlx5_flow_get_thread_workspace();\n \tstruct mlx5_flow_rss_desc *rss_desc;\n-\tchar errstr[32];\n \n \tMLX5_ASSERT(wks);\n \trss_desc = &wks->rss_desc[!!wks->flow_nested_idx];\n@@ -1846,11 +1848,9 @@\n \t\t\titem_flags |= MLX5_FLOW_LAYER_MPLS;\n \t\t\tbreak;\n \t\tdefault:\n-\t\t\tsnprintf(errstr, sizeof(errstr), \"item type %d not supported\",\n-\t\t\t\t items->type);\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\t\t\t\t NULL, errstr);\n+\t\t\t\t\t\t NULL, \"item not supported\");\n \t\t}\n \t}\n \tdev_flow->handle->layers = item_flags;\n", "prefixes": [] }