Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83657/?format=api
{ "id": 83657, "url": "https://patches.dpdk.org/api/patches/83657/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201104070350.28224-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201104070350.28224-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20201104070350.28224-6-stephen@networkplumber.org", "date": "2020-11-04T07:03:49", "name": "[v2,5/6] dpdk-devbind: fix unnecessary else after return", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ede669bb74daf2ba45b51a8f00a8415c35de7372", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201104070350.28224-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 13648, "url": "https://patches.dpdk.org/api/series/13648/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13648", "date": "2020-11-04T07:03:44", "name": "dpdk-devbind: python lint cleanups", "version": 2, "mbox": "https://patches.dpdk.org/series/13648/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83657/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/83657/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 53708A04E7;\n\tWed, 4 Nov 2020 08:05:36 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E81B7C83A;\n\tWed, 4 Nov 2020 08:04:05 +0100 (CET)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 9DF75C81A\n for <dev@dpdk.org>; Wed, 4 Nov 2020 08:04:01 +0100 (CET)", "by mail-pg1-f196.google.com with SMTP id i7so13845304pgh.6\n for <dev@dpdk.org>; Tue, 03 Nov 2020 23:04:01 -0800 (PST)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id z21sm1181177pfa.158.2020.11.03.23.03.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 03 Nov 2020 23:03:58 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=O0hDDPqJ1rsd2SwIvXX4b+gAgam1T4WP0pY3Y22C0tg=;\n b=UroUDCQW7wPSaOuYWSQx7ohSl41y4aVWBK9gCZpcHdzSWmXv/UV/w4RoWKkgYjIeId\n YWk+s7JFqe/On8VxHy/uIi7rEG/79MhYhOy2J1d3P3cnN9MgkOr2wuncKIKMZ1YPUHsb\n H9n2QsjsqxaFjYBZnLSDD4P2ymExP73MBeaRrF9EBWpAxWCAg/3kIwsOzJru/BKcN5u6\n 2dRia9pxMTwwbd4SsYh80GWYadfknjMSIg9LdDvbIHtTGQN3LHN5JEdK/C1uG05lYvHN\n Aa2u/Ic7uMUXLL0iSF7g69C0v5wfY51K2+/MLugjy1i+ulr/LNAP7hKQYZkY7Wo9XY0m\n GwZA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=O0hDDPqJ1rsd2SwIvXX4b+gAgam1T4WP0pY3Y22C0tg=;\n b=fm1aPVfxeXE6qPB8wdVTe1I6JmabVrcAYHFkHBBh+qicdNeyVRBUiQOQkcBLVyS2Mo\n Z7MVPH5hkMRhUCI2vAUkDYpK4X2FiudJF825FXqTUdhUQWVdUMVJArFB3oFXL7OEP6F1\n XAUi/FHaNw9MvQm+bVX0BVDFnq02RulE+DRd0y+H40PDOK1o0umKZhZRGHEVC+nOvklh\n bTjhfTiGcJ51SYu36fSdkSfCszhrYikKnwKzmsXlJl9+uzVdBU2Xg5X+sgYpaTru2+KF\n 6xaqd6eD/rygEIqgX8hLizsYsuqzO9nnmKQiQPx6QlVgxthPqRPFCYozajIgvlMsAX8z\n NLFA==", "X-Gm-Message-State": "AOAM5315nMrUo20chRt1Zx93HN6F6eYQgOZIA6SS4HqGlcJNDf50B+7E\n 1zPt6T50hd1SW6I2ViCdYxPDzC10nvnqI4Oq", "X-Google-Smtp-Source": "\n ABdhPJx1NLMsjoBDJxSRAKOQIV7/OvVix4pmkLS4dNZvrwFnZJ8TqQdcCgG/LGTbYHUHbb+B5XFOKQ==", "X-Received": "by 2002:a17:90a:1546:: with SMTP id\n y6mr2920386pja.167.1604473439422;\n Tue, 03 Nov 2020 23:03:59 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 3 Nov 2020 23:03:49 -0800", "Message-Id": "<20201104070350.28224-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201104070350.28224-1-stephen@networkplumber.org>", "References": "<20200906013133.26360-12-stephen@networkplumber.org>\n <20201104070350.28224-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 5/6] dpdk-devbind: fix unnecessary else after\n\treturn", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Python lint complains about\n Unnecessary \"else\" after \"return\" (no-else-return)\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n usertools/dpdk-devbind.py | 19 +++++++++----------\n 1 file changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py\nindex afe93a217d79..47373e27bd74 100755\n--- a/usertools/dpdk-devbind.py\n+++ b/usertools/dpdk-devbind.py\n@@ -274,13 +274,13 @@ def dev_id_from_dev_name(dev_name):\n if dev_name in devices:\n return dev_name\n # check if it's an index just missing the domain part\n- elif \"0000:\" + dev_name in devices:\n+ if \"0000:\" + dev_name in devices:\n return \"0000:\" + dev_name\n- else:\n- # check if it's an interface name, e.g. eth1\n- for d in devices.keys():\n- if dev_name in devices[d][\"Interface\"].split(\",\"):\n- return devices[d][\"Slot\"]\n+\n+ # check if it's an interface name, e.g. eth1\n+ for d in devices.keys():\n+ if dev_name in devices[d][\"Interface\"].split(\",\"):\n+ return devices[d][\"Slot\"]\n # if nothing else matches - error\n raise ValueError(\"Unknown device: %s. \"\n \"Please specify device in \\\"bus:slot.func\\\" format\" % dev_name)\n@@ -329,10 +329,9 @@ def bind_one(dev_id, driver, force):\n print(\"Notice: %s already bound to driver %s, skipping\" %\n (dev_id, driver), file=sys.stderr)\n return\n- else:\n- saved_driver = dev[\"Driver_str\"]\n- unbind_one(dev_id, force)\n- dev[\"Driver_str\"] = \"\" # clear driver string\n+ saved_driver = dev[\"Driver_str\"]\n+ unbind_one(dev_id, force)\n+ dev[\"Driver_str\"] = \"\" # clear driver string\n \n # For kernels >= 3.15 driver_override can be used to specify the driver\n # for a device rather than relying on the driver to provide a positive\n", "prefixes": [ "v2", "5/6" ] }