Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83599/?format=api
{ "id": 83599, "url": "https://patches.dpdk.org/api/patches/83599/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201103140931.488700-9-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201103140931.488700-9-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201103140931.488700-9-thomas@monjalon.net", "date": "2020-11-03T14:09:23", "name": "[v5,08/16] net/nfb: switch Rx timestamp to dynamic mbuf field", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9f9475dda6991a9b3f8e1e8b1e59e1d9b9256721", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201103140931.488700-9-thomas@monjalon.net/mbox/", "series": [ { "id": 13621, "url": "https://patches.dpdk.org/api/series/13621/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13621", "date": "2020-11-03T14:09:15", "name": "remove mbuf timestamp", "version": 5, "mbox": "https://patches.dpdk.org/series/13621/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83599/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/83599/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B740A0521;\n\tTue, 3 Nov 2020 15:12:54 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F1D7ECAE0;\n\tTue, 3 Nov 2020 15:10:03 +0100 (CET)", "from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com\n [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 3091ECACD\n for <dev@dpdk.org>; Tue, 3 Nov 2020 15:10:01 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.west.internal (Postfix) with ESMTP id CF0FAD30;\n Tue, 3 Nov 2020 09:09:58 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Tue, 03 Nov 2020 09:09:59 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 218F63280065;\n Tue, 3 Nov 2020 09:09:57 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=Ad3YnWIV8//wa\n 0/Ps2HuGcyoJx3eHsifS7Fhic4NkI4=; b=wqu3a6d5zG3Aq+quNtHtP7a9dp0pR\n PI3JJmf1Hv2g3ETLhS+EaPsGg0Y0wE8dXbDJL6bXNYzukJcjkjBuMLp3lC6tmZYL\n c26VXtvNyH81rKBGqYaYiIfJsHbuOiY+4Y7S2rZrWae1azRah69nLToBPCN2WVVn\n cW7vrpEzcG91p6bRBZFiF4NNPpIf+xpzk7xk9mJGBF0CU51c6toZO2Q5mk+JsKy3\n vXitckq4u5PNGI/evQ49yC6snkMj/kX+c7NLxt9BlmMH91Hj253XDMpkXyeEROA3\n jKmEVmdc4CJoQsrVuwtNzX3AvGd8Bqo9aJgXW1yZuXpB0DqXPsJCrHTqw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=Ad3YnWIV8//wa0/Ps2HuGcyoJx3eHsifS7Fhic4NkI4=; b=WZHVU7x2\n 2ahMqKOuBv6ADSASxG5J0mlOi7zu9iupGNgkSjgnNv4af6EuG0U1y56DQTIEQAg9\n jNt84gcpp0oWN5XzS2Tbw423g8O1b/iiAKlgvfnvul9z4bnla8Ohx0Uoz2ec6ksH\n 7R1SVuP8RKmUC+nYgGJFqQtF5rxKTxi8+P4j96v218qpEuq61YAbTRKoJEiNVngC\n 2untQrv/7+nsJDDB/Ik6/0Y2sGuhkQSysh796028Py5FOdap5CnKsN+K0GhW1Sl/\n xYzYsD/7BheAMUCY33sv6ZlFQttBQPMsXLwt2rgEx1NEALi/jLUPaMbgAXUUlc2N\n zol5tb4Jx0Qkpw==" ], "X-ME-Sender": "<xms:tmShXxkDwJAyNBB5Fdr8qEjo2oASSFnYFSpSK4ZpI7j3ibS1gtD2Iw>\n <xme:tmShX83ji_V7PLbBKAthYosc6LuTxRgw5QdkpDW9WdAPHW_4rcsAgm2FkIQz_ldyI\n 0YXffkNVaOgqz8IoA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgheekucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:tmShX3qElvkJow1tO-72ep_NcdEeRqUC1AoBnmpJbtx_X2t58VMfMQ>\n <xmx:tmShXxlwd7GXXbVdmllhl4x_y9lJtAdru6EKi_wPaeCb-UURHrX1eQ>\n <xmx:tmShX_304B-CWwdJ4Qb1FH_SYvhRYNla4hueD4scfHAOA03FuJFC4g>\n <xmx:tmShX5pgiLPTn4TJR5D6j3ruu0Q0iYh4Lw6-VzAfwG0c72VfY8qwjg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com,\n Martin Spinler <spinler@cesnet.cz>", "Date": "Tue, 3 Nov 2020 15:09:23 +0100", "Message-Id": "<20201103140931.488700-9-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201103140931.488700-1-thomas@monjalon.net>", "References": "<20201029092751.3837177-1-thomas@monjalon.net>\n <20201103140931.488700-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 08/16] net/nfb: switch Rx timestamp to dynamic\n\tmbuf field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The mbuf timestamp is moved to a dynamic field\nin order to allow removal of the deprecated static field.\nThe related mbuf flag is also replaced.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/nfb/nfb_rx.c | 15 ++++++++++++++-\n drivers/net/nfb/nfb_rx.h | 21 +++++++++++++++++----\n 2 files changed, 31 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/nfb/nfb_rx.c b/drivers/net/nfb/nfb_rx.c\nindex d97179f818..d6d4ba9663 100644\n--- a/drivers/net/nfb/nfb_rx.c\n+++ b/drivers/net/nfb/nfb_rx.c\n@@ -9,6 +9,9 @@\n #include \"nfb_rx.h\"\n #include \"nfb.h\"\n \n+uint64_t nfb_timestamp_rx_dynflag;\n+int nfb_timestamp_dynfield_offset = -1;\n+\n static int\n timestamp_check_handler(__rte_unused const char *key,\n \tconst char *value, __rte_unused void *opaque)\n@@ -24,6 +27,7 @@ static int\n nfb_check_timestamp(struct rte_devargs *devargs)\n {\n \tstruct rte_kvargs *kvlist;\n+\tint ret;\n \n \tif (devargs == NULL)\n \t\treturn 0;\n@@ -38,6 +42,7 @@ nfb_check_timestamp(struct rte_devargs *devargs)\n \t}\n \t/* Timestamps are enabled when there is\n \t * key-value pair: enable_timestamp=1\n+\t * TODO: timestamp should be enabled with DEV_RX_OFFLOAD_TIMESTAMP\n \t */\n \tif (rte_kvargs_process(kvlist, TIMESTAMP_ARG,\n \t\ttimestamp_check_handler, NULL) < 0) {\n@@ -46,6 +51,14 @@ nfb_check_timestamp(struct rte_devargs *devargs)\n \t}\n \trte_kvargs_free(kvlist);\n \n+\tret = rte_mbuf_dyn_rx_timestamp_register(\n+\t\t\t&nfb_timestamp_dynfield_offset,\n+\t\t\t&nfb_timestamp_rx_dynflag);\n+\tif (ret != 0) {\n+\t\tRTE_LOG(ERR, PMD, \"Cannot register Rx timestamp field/flag\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\n \treturn 1;\n }\n \n@@ -125,7 +138,7 @@ nfb_eth_rx_queue_setup(struct rte_eth_dev *dev,\n \telse\n \t\trte_free(rxq);\n \n-\tif (nfb_check_timestamp(dev->device->devargs))\n+\tif (nfb_check_timestamp(dev->device->devargs) > 0)\n \t\trxq->flags |= NFB_TIMESTAMP_FLAG;\n \n \treturn ret;\ndiff --git a/drivers/net/nfb/nfb_rx.h b/drivers/net/nfb/nfb_rx.h\nindex cf3899b2fb..27a2888a75 100644\n--- a/drivers/net/nfb/nfb_rx.h\n+++ b/drivers/net/nfb/nfb_rx.h\n@@ -15,6 +15,16 @@\n \n #define NFB_TIMESTAMP_FLAG (1 << 0)\n \n+extern uint64_t nfb_timestamp_rx_dynflag;\n+extern int nfb_timestamp_dynfield_offset;\n+\n+static inline rte_mbuf_timestamp_t *\n+nfb_timestamp_dynfield(struct rte_mbuf *mbuf)\n+{\n+\treturn RTE_MBUF_DYNFIELD(mbuf,\n+\t\tnfb_timestamp_dynfield_offset, rte_mbuf_timestamp_t *);\n+}\n+\n struct ndp_rx_queue {\n \tstruct nfb_device *nfb;\t /* nfb dev structure */\n \tstruct ndp_queue *queue; /* rx queue */\n@@ -190,16 +200,19 @@ nfb_eth_ndp_rx(void *queue,\n \t\t\tmbuf->ol_flags = 0;\n \n \t\t\tif (timestamping_enabled) {\n+\t\t\t\trte_mbuf_timestamp_t timestamp;\n+\n \t\t\t\t/* nanoseconds */\n-\t\t\t\tmbuf->timestamp =\n+\t\t\t\ttimestamp =\n \t\t\t\t\trte_le_to_cpu_32(*((uint32_t *)\n \t\t\t\t\t(packets[i].header + 4)));\n-\t\t\t\tmbuf->timestamp <<= 32;\n+\t\t\t\ttimestamp <<= 32;\n \t\t\t\t/* seconds */\n-\t\t\t\tmbuf->timestamp |=\n+\t\t\t\ttimestamp |=\n \t\t\t\t\trte_le_to_cpu_32(*((uint32_t *)\n \t\t\t\t\t(packets[i].header + 8)));\n-\t\t\t\tmbuf->ol_flags |= PKT_RX_TIMESTAMP;\n+\t\t\t\t*nfb_timestamp_dynfield(mbuf) = timestamp;\n+\t\t\t\tmbuf->ol_flags |= nfb_timestamp_rx_dynflag;\n \t\t\t}\n \n \t\t\tbufs[num_rx++] = mbuf;\n", "prefixes": [ "v5", "08/16" ] }