Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83595/?format=api
{ "id": 83595, "url": "https://patches.dpdk.org/api/patches/83595/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201103140931.488700-5-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201103140931.488700-5-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201103140931.488700-5-thomas@monjalon.net", "date": "2020-11-03T14:09:19", "name": "[v5,04/16] net/ark: switch Rx timestamp to dynamic mbuf field", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a60b46cc2137fd4906fe8a71d1ac9ff56eded541", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201103140931.488700-5-thomas@monjalon.net/mbox/", "series": [ { "id": 13621, "url": "https://patches.dpdk.org/api/series/13621/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13621", "date": "2020-11-03T14:09:15", "name": "remove mbuf timestamp", "version": 5, "mbox": "https://patches.dpdk.org/series/13621/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83595/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/83595/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B03AA0521;\n\tTue, 3 Nov 2020 15:11:18 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D3E69CB01;\n\tTue, 3 Nov 2020 15:09:54 +0100 (CET)", "from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com\n [64.147.123.26]) by dpdk.org (Postfix) with ESMTP id 2B994CADB\n for <dev@dpdk.org>; Tue, 3 Nov 2020 15:09:52 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailnew.west.internal (Postfix) with ESMTP id 678838E1;\n Tue, 3 Nov 2020 09:09:50 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Tue, 03 Nov 2020 09:09:51 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 9CCCE3280064;\n Tue, 3 Nov 2020 09:09:48 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=vdA6ovYm1n+Yx\n fdg/EKTDdjJWOR3/R6hlj+s41cUV/A=; b=KGaEW2/7PqaGmI0dQIJIn1rXg4eOn\n RafdW2rrSo/6XgFV6bNEb2FSSGEk11qwC5ujagw7bUv1Iakpn17439GIKEvOorou\n VvK/ZG174q61nzh0vGuk/T+JPk27ixta/pvM2NsvuoKk3oKcMgTJ8TOpMYUN6kul\n Stb28pSU8+NvOiO/kc1kDC4KsO2AMkMYnT/ZXmXvdQn92HpDbMNKEjdXss2rpvRg\n AGvYnb+JfB/3AjQiNQ0sFzixlZkOnnR2+Vinon7p0zmpjQAcFah7NtVgUXff2Opv\n ajGgQ/FgQiyG7haUY71lwd2LOrENiTSFRYUuioZVLyb2JR3YP7Y+oY+JA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=vdA6ovYm1n+Yxfdg/EKTDdjJWOR3/R6hlj+s41cUV/A=; b=i37rKdR4\n hSDfSskiaA0dWHTl6ZTnonCNSpPYHcPgLaBL9RwjDkUQV6PhCwewGQec5cKH2z07\n 8EP8M6YX8OPADdDLZuh3jcThKDvWbtwYN3Dm4hbhWrTCdKL7Jp7lPMLx4/ZjXgWk\n L9g6FbGOxwbSh60nCNn9AUftayiV2FwjsIapAwTREgY8Ls72viKMYSBcdooARZFZ\n 4nAOBHbTY0RpA0/kV0JoBl6be+r1qG5jtZ5BOsDi1zRrSKuxFktfN66PKg4eTftR\n q/2aW4r9BBSgu4xq+R25fzgQ6DXNqUvEauY0i6/YMAvKME5EqszFP3V4Ragg09Gl\n WIOlek3eC7yRBw==" ], "X-ME-Sender": "<xms:rWShX7sOCnnhB02mgU4YhF4U9dPNKYdFxK3C3pUZKGSVRYNFUiJwvg>\n <xme:rWShX8dj3pgrEV2oJgk6lTYsAtsgkWMyH8ftuqh5h3jY0g4d-JjnUD1q5LS7dSP5A\n -odVOu9JvJvQQ347w>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgheekucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:rWShX-ydKWnhbVp8pMnv-7huArwyIV65jY5TIDXzGCtLw7qzFyRfVQ>\n <xmx:rWShX6OxDa0qmVmHy9dHsV3OmdVIv0XwIOytRBp7ueRxBXkKthJjIQ>\n <xmx:rWShX7_Y9FTffdUv9uYkR6qcC73TdIR2iFjuOqeE8gHHkQOv1HdaYQ>\n <xmx:rmShX3TZa02YczH0S3L_eU8WHL5j39gY311K6rTeX_pFXHDIHPo4P3J61sI>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com,\n Shepard Siegel <shepard.siegel@atomicrules.com>,\n Ed Czeck <ed.czeck@atomicrules.com>,\n John Miller <john.miller@atomicrules.com>", "Date": "Tue, 3 Nov 2020 15:09:19 +0100", "Message-Id": "<20201103140931.488700-5-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201103140931.488700-1-thomas@monjalon.net>", "References": "<20201029092751.3837177-1-thomas@monjalon.net>\n <20201103140931.488700-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 04/16] net/ark: switch Rx timestamp to dynamic\n\tmbuf field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The mbuf timestamp is moved to a dynamic field\nin order to allow removal of the deprecated static field.\nThe related dynamic mbuf flag is set, although was missing previously.\n\nThe timestamp is set if configured for at least one device.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/ark/ark_ethdev.c | 17 +++++++++++++++++\n drivers/net/ark/ark_ethdev_rx.c | 7 ++++++-\n drivers/net/ark/ark_ethdev_rx.h | 2 ++\n 3 files changed, 25 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c\nindex fa343999a1..a658993512 100644\n--- a/drivers/net/ark/ark_ethdev.c\n+++ b/drivers/net/ark/ark_ethdev.c\n@@ -79,6 +79,9 @@ static int eth_ark_set_mtu(struct rte_eth_dev *dev, uint16_t size);\n #define ARK_TX_MAX_QUEUE (4096 * 4)\n #define ARK_TX_MIN_QUEUE (256)\n \n+uint64_t ark_timestamp_rx_dynflag;\n+int ark_timestamp_dynfield_offset = -1;\n+\n int rte_pmd_ark_rx_userdata_dynfield_offset = -1;\n int rte_pmd_ark_tx_userdata_dynfield_offset = -1;\n \n@@ -552,6 +555,18 @@ static int\n eth_ark_dev_configure(struct rte_eth_dev *dev)\n {\n \tstruct ark_adapter *ark = dev->data->dev_private;\n+\tint ret;\n+\n+\tif (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_TIMESTAMP) {\n+\t\tret = rte_mbuf_dyn_rx_timestamp_register(\n+\t\t\t\t&ark_timestamp_dynfield_offset,\n+\t\t\t\t&ark_timestamp_rx_dynflag);\n+\t\tif (ret != 0) {\n+\t\t\tARK_PMD_LOG(ERR,\n+\t\t\t\t\"Failed to register Rx timestamp field/flag\\n\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t}\n \n \teth_ark_dev_set_link_up(dev);\n \tif (ark->user_ext.dev_configure)\n@@ -782,6 +797,8 @@ eth_ark_dev_info_get(struct rte_eth_dev *dev,\n \t\t\t\tETH_LINK_SPEED_50G |\n \t\t\t\tETH_LINK_SPEED_100G);\n \n+\tdev_info->rx_offload_capa = DEV_RX_OFFLOAD_TIMESTAMP;\n+\n \treturn 0;\n }\n \ndiff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c\nindex c24cc00e2f..d29d3db783 100644\n--- a/drivers/net/ark/ark_ethdev_rx.c\n+++ b/drivers/net/ark/ark_ethdev_rx.c\n@@ -272,7 +272,12 @@ eth_ark_recv_pkts(void *rx_queue,\n \t\tmbuf->port = meta->port;\n \t\tmbuf->pkt_len = meta->pkt_len;\n \t\tmbuf->data_len = meta->pkt_len;\n-\t\tmbuf->timestamp = meta->timestamp;\n+\t\t/* set timestamp if enabled at least on one device */\n+\t\tif (ark_timestamp_rx_dynflag > 0) {\n+\t\t\t*RTE_MBUF_DYNFIELD(mbuf, ark_timestamp_dynfield_offset,\n+\t\t\t\trte_mbuf_timestamp_t *) = meta->timestamp;\n+\t\t\tmbuf->ol_flags |= ark_timestamp_rx_dynflag;\n+\t\t}\n \t\trte_pmd_ark_mbuf_rx_userdata_set(mbuf, meta->user_data);\n \n \t\tif (ARK_DEBUG_CORE) {\t/* debug sanity checks */\ndiff --git a/drivers/net/ark/ark_ethdev_rx.h b/drivers/net/ark/ark_ethdev_rx.h\nindex 0fdd29b1ab..001fa9bdfa 100644\n--- a/drivers/net/ark/ark_ethdev_rx.h\n+++ b/drivers/net/ark/ark_ethdev_rx.h\n@@ -11,6 +11,8 @@\n #include <rte_mempool.h>\n #include <rte_ethdev_driver.h>\n \n+extern uint64_t ark_timestamp_rx_dynflag;\n+extern int ark_timestamp_dynfield_offset;\n \n int eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t\t\t uint16_t queue_idx,\n", "prefixes": [ "v5", "04/16" ] }