Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83452/?format=api
{ "id": 83452, "url": "https://patches.dpdk.org/api/patches/83452/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201103001407.2931963-2-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201103001407.2931963-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201103001407.2931963-2-thomas@monjalon.net", "date": "2020-11-03T00:13:52", "name": "[v3,01/16] eventdev: remove software Rx timestamp", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c4771ab6c4952300584e88fa7044f18e5c89abdd", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201103001407.2931963-2-thomas@monjalon.net/mbox/", "series": [ { "id": 13585, "url": "https://patches.dpdk.org/api/series/13585/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13585", "date": "2020-11-03T00:13:51", "name": "remove mbuf timestamp", "version": 3, "mbox": "https://patches.dpdk.org/series/13585/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83452/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/83452/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D3E45A04E7;\n\tTue, 3 Nov 2020 01:14:48 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E1E364CA6;\n\tTue, 3 Nov 2020 01:14:29 +0100 (CET)", "from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com\n [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 088EC4C7A\n for <dev@dpdk.org>; Tue, 3 Nov 2020 01:14:27 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.west.internal (Postfix) with ESMTP id 9F90CB3D;\n Mon, 2 Nov 2020 19:14:22 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Mon, 02 Nov 2020 19:14:23 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 279F73064674;\n Mon, 2 Nov 2020 19:14:21 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=d3ztsAyXOIJYQ\n l5EkxV8lcANpMnAVb2RCdS4o479Bec=; b=nYEV0tqVpC8Y6Th1X0jmeOzy7De5I\n fzUyLvDT8BqlJBmANJoANGGp2kmv8YYE1DaRW+rEh2b8YBz9gOCHsTKv5E2v4tax\n FGVtWZSaYT5lxCVdhbT+qNv9zOLx/bA2XqdVHtNSfZFekQ0P1r4SnGTrr/5BhVwG\n 6vVGe8pxydpplQcSp1MEBSgJw9aV4mvAeHZO9u93ySNJG80nWtYD6pKxFJDwuR/n\n PLyUz+OT5opVs7+WZNxF/L3nke1fPeFHBN9vlengG53wKLQ/X/nJAWomvF27PVX9\n SN+ZRYHKG4kt73yXiBOBL8IamaLd46x5ENnBZeqe4BdNBBnCT1uKHxlBQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=d3ztsAyXOIJYQl5EkxV8lcANpMnAVb2RCdS4o479Bec=; b=LgI/GCNr\n PEhYBpPBUmqksTt0c49gWj9ZDzoYEK29waClWjGXv2EGuJWJy3VShmfjkYkNUAsk\n Fc7lmfozHCQGvRgz1pB/CIL4YZZDXp+fjn71690DCv5v7qKVIGNSmpit04n6csjU\n k6iI2IFFirKpsUcD2da3E1UWv7IZ1zGR1B6SOYXZDPl8b9jKHOI8rHph30Isa7aN\n YVdJ3Wfv1FG//JRn/qh+ROV9EgsgWrdYwQKgXgwtpE4Yx1oiLsbnUQq8CWo/ekuM\n 6FVmGu3S6EBzMM40F21iyBQM8T8nXjuJYMXVlWoyktsXWp3ZjyhjxwtrJZQdskzD\n EjdQ2TUYwlrJVw==" ], "X-ME-Sender": "<xms:3qCgX_AUN4V0pg_jt9-2hipxSU2d-k4PJeV4wJLaOKy0O3Tu633Kcg>\n <xme:3qCgX1imeeok5ZsOlnwHNt87uaz8fbNr5s-ZOs_ibN_SNs6EKy91P77tlEKWaitwr\n lYYmBHz4jwflXh5jQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedruddtvddgudejucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:3qCgX6k7v8GGihFsyx6a-PmgS_Gt4D_yyQuLZ8XgxmdnfHufwe6tVQ>\n <xmx:3qCgXxyptSBdWB0w63erlPwSmlY9_mokEF0-BvVjXz03N5-8GMTqPA>\n <xmx:3qCgX0TtW43E0OqEd8TmejXgbUZXlJTHnhXnnSowWbZz2sPrY5TXeg>\n <xmx:3qCgXzGWU2lZDICciBVZWBX-waxTmMdKdQZhyUDkartAIaaB9VQG5w>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com,\n Nikhil Rao <nikhil.rao@intel.com>", "Date": "Tue, 3 Nov 2020 01:13:52 +0100", "Message-Id": "<20201103001407.2931963-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201103001407.2931963-1-thomas@monjalon.net>", "References": "<20201029092751.3837177-1-thomas@monjalon.net>\n <20201103001407.2931963-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 01/16] eventdev: remove software Rx timestamp", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This a revert of the commit 569758758dcd (\"eventdev: add Rx timestamp\").\nIf the Rx timestamp is not configured on the ethdev port,\nthere is no reason to set one.\nAlso the accuracy of the timestamp was bad because set at a late stage.\nAnyway there is no trace of the usage of this timestamp.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n doc/guides/prog_guide/event_ethernet_rx_adapter.rst | 6 +-----\n lib/librte_eventdev/rte_event_eth_rx_adapter.c | 11 -----------\n lib/librte_eventdev/rte_event_eth_rx_adapter.h | 6 +-----\n 3 files changed, 2 insertions(+), 21 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst\nindex 236f43f455..cb44ce0e47 100644\n--- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst\n+++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst\n@@ -12,11 +12,7 @@ be supported in hardware or require a software thread to receive packets from\n the ethdev port using ethdev poll mode APIs and enqueue these as events to the\n event device using the eventdev API. Both transfer mechanisms may be present on\n the same platform depending on the particular combination of the ethdev and\n-the event device. For SW based packet transfer, if the mbuf does not have a\n-timestamp set, the adapter adds a timestamp to the mbuf using\n-rte_get_tsc_cycles(), this provides a more accurate timestamp as compared to\n-if the application were to set the timestamp since it avoids event device\n-schedule latency.\n+the event device.\n \n The Event Ethernet Rx Adapter library is intended for the application code to\n configure both transfer mechanisms using a common API. A capability API allows\ndiff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c\nindex f0000d1ede..3c73046551 100644\n--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c\n+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c\n@@ -763,7 +763,6 @@ rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx_adapter,\n \tuint32_t rss_mask;\n \tuint32_t rss;\n \tint do_rss;\n-\tuint64_t ts;\n \tuint16_t nb_cb;\n \tuint16_t dropped;\n \n@@ -771,16 +770,6 @@ rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx_adapter,\n \trss_mask = ~(((m->ol_flags & PKT_RX_RSS_HASH) != 0) - 1);\n \tdo_rss = !rss_mask && !eth_rx_queue_info->flow_id_mask;\n \n-\tif ((m->ol_flags & PKT_RX_TIMESTAMP) == 0) {\n-\t\tts = rte_get_tsc_cycles();\n-\t\tfor (i = 0; i < num; i++) {\n-\t\t\tm = mbufs[i];\n-\n-\t\t\tm->timestamp = ts;\n-\t\t\tm->ol_flags |= PKT_RX_TIMESTAMP;\n-\t\t}\n-\t}\n-\n \tfor (i = 0; i < num; i++) {\n \t\tm = mbufs[i];\n \ndiff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h\nindex 2dd259c279..21bb1e54c8 100644\n--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h\n+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h\n@@ -21,11 +21,7 @@\n *\n * The adapter uses a EAL service core function for SW based packet transfer\n * and uses the eventdev PMD functions to configure HW based packet transfer\n- * between the ethernet device and the event device. For SW based packet\n- * transfer, if the mbuf does not have a timestamp set, the adapter adds a\n- * timestamp to the mbuf using rte_get_tsc_cycles(), this provides a more\n- * accurate timestamp as compared to if the application were to set the time\n- * stamp since it avoids event device schedule latency.\n+ * between the ethernet device and the event device.\n *\n * The ethernet Rx event adapter's functions are:\n * - rte_event_eth_rx_adapter_create_ext()\n", "prefixes": [ "v3", "01/16" ] }