Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83450/?format=api
{ "id": 83450, "url": "https://patches.dpdk.org/api/patches/83450/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201102235203.6342-4-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201102235203.6342-4-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201102235203.6342-4-dharmik.thakkar@arm.com", "date": "2020-11-02T23:52:02", "name": "[v2,3/4] test/lpm: remove error checking in rcu qsbr perf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "15e811896d74f652c00541b80d7a525e1386c4f4", "submitter": { "id": 1108, "url": "https://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201102235203.6342-4-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 13584, "url": "https://patches.dpdk.org/api/series/13584/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13584", "date": "2020-11-02T23:51:59", "name": "test/lpm: fix rcu qsbr perf test", "version": 2, "mbox": "https://patches.dpdk.org/series/13584/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83450/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/83450/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D0C13A04E7;\n\tTue, 3 Nov 2020 00:56:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BCF2D5AB2;\n\tTue, 3 Nov 2020 00:54:52 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 301583976;\n Tue, 3 Nov 2020 00:54:44 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8CA0F143B;\n Mon, 2 Nov 2020 15:54:42 -0800 (PST)", "from localhost.localdomain (2p2660v4-1.austin.arm.com\n [10.118.13.220])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 85D073F718;\n Mon, 2 Nov 2020 15:54:42 -0800 (PST)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Gavin Hu <gavin.hu@arm.com>", "Cc": "dev@dpdk.org, nd@arm.com, Dharmik Thakkar <dharmik.thakkar@arm.com>,\n stable@dpdk.org", "Date": "Mon, 2 Nov 2020 17:52:02 -0600", "Message-Id": "<20201102235203.6342-4-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201102235203.6342-1-dharmik.thakkar@arm.com>", "References": "<20201029153634.10647-1-dharmik.thakkar@arm.com>\n <20201102235203.6342-1-dharmik.thakkar@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 3/4] test/lpm: remove error checking in rcu\n\tqsbr perf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove redundant error checking for reader threads\nsince they never return error.\n\nFixes: eff30b59cc2e (\"test/lpm: add RCU performance tests\")\nCc: honnappa.nagarahalli@arm.com\nCc: stable@dpdk.org\n\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test/test_lpm_perf.c | 21 ++++++++-------------\n 1 file changed, 8 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c\nindex 55084816ab91..224c92fa3d65 100644\n--- a/app/test/test_lpm_perf.c\n+++ b/app/test/test_lpm_perf.c\n@@ -554,11 +554,10 @@ test_lpm_rcu_perf_multi_writer(void)\n \t\t__atomic_load_n(&gwrite_cycles, __ATOMIC_RELAXED)\n \t\t/ TOTAL_WRITES);\n \n-\t/* Wait and check return value from reader threads */\n \twriter_done = 1;\n+\t/* Wait until all readers have exited */\n \tfor (i = 2; i < num_cores; i++)\n-\t\tif (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)\n-\t\t\tgoto error;\n+\t\trte_eal_wait_lcore(enabled_core_ids[i]);\n \n \trte_lpm_free(lpm);\n \trte_free(rv);\n@@ -603,10 +602,9 @@ test_lpm_rcu_perf_multi_writer(void)\n \t\t/ TOTAL_WRITES);\n \n \twriter_done = 1;\n-\t/* Wait and check return value from reader threads */\n+\t/* Wait until all readers have exited */\n \tfor (i = 2; i < num_cores; i++)\n-\t\tif (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)\n-\t\t\tgoto error;\n+\t\trte_eal_wait_lcore(enabled_core_ids[i]);\n \n \trte_lpm_free(lpm);\n \n@@ -710,10 +708,9 @@ test_lpm_rcu_perf(void)\n \t\t(double)total_cycles / TOTAL_WRITES);\n \n \twriter_done = 1;\n-\t/* Wait and check return value from reader threads */\n+\t/* Wait until all readers have exited */\n \tfor (i = 0; i < num_cores; i++)\n-\t\tif (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)\n-\t\t\tgoto error;\n+\t\tif (rte_eal_wait_lcore(enabled_core_ids[i]);\n \n \trte_lpm_free(lpm);\n \trte_free(rv);\n@@ -769,11 +766,9 @@ test_lpm_rcu_perf(void)\n \t\t(double)total_cycles / TOTAL_WRITES);\n \n \twriter_done = 1;\n-\t/* Wait and check return value from reader threads */\n+\t/* Wait until all readers have exited */\n \tfor (i = 0; i < num_cores; i++)\n-\t\tif (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)\n-\t\t\tprintf(\"Warning: lcore %u not finished.\\n\",\n-\t\t\t\tenabled_core_ids[i]);\n+\t\trte_eal_wait_lcore(enabled_core_ids[i]);\n \n \trte_lpm_free(lpm);\n \n", "prefixes": [ "v2", "3/4" ] }