Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83365/?format=api
{ "id": 83365, "url": "https://patches.dpdk.org/api/patches/83365/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201102085234.72779-2-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201102085234.72779-2-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201102085234.72779-2-stevex.yang@intel.com", "date": "2020-11-02T08:52:33", "name": "[v8,1/2] app/testpmd: fix max rx packet length for VLAN packets", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ec7bf5c81f4085b4624cd1733951622fb038b942", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201102085234.72779-2-stevex.yang@intel.com/mbox/", "series": [ { "id": 13555, "url": "https://patches.dpdk.org/api/series/13555/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13555", "date": "2020-11-02T08:52:32", "name": "fix default max mtu size when device configured", "version": 8, "mbox": "https://patches.dpdk.org/series/13555/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/83365/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/83365/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C1F51A04E7;\n\tMon, 2 Nov 2020 09:54:22 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 66CA1BBB4;\n\tMon, 2 Nov 2020 09:54:09 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id CEBF7BBA4\n for <dev@dpdk.org>; Mon, 2 Nov 2020 09:54:06 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Nov 2020 00:54:06 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Nov 2020 00:54:02 -0800" ], "IronPort-SDR": [ "\n B+pUcTsX2Jxxs2uqP8+cj0EXVVLpZydxx/shPwtlfpOx16+vLj2iGEd8wOybJorwUSe8Yjci5M\n Z/3PmoQiKtkA==", "\n ETc+/n8yy2utQ4CYRfH+c0Y3ajKr2OB+LWZ2RRsjz71p95/pIZLfCc7V6SuITxet20/YFrHMXR\n YkHpBQ8ddD5A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9792\"; a=\"253562017\"", "E=Sophos;i=\"5.77,444,1596524400\"; d=\"scan'208\";a=\"253562017\"", "E=Sophos;i=\"5.77,444,1596524400\"; d=\"scan'208\";a=\"537939364\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "From": "SteveX Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n beilei.xing@intel.com, wenzhuo.lu@intel.com, bernard.iremonger@intel.com,\n qiming.yang@intel.com, mdr@ashroe.eu, nhorman@tuxdriver.com,\n SteveX Yang <stevex.yang@intel.com>", "Date": "Mon, 2 Nov 2020 08:52:33 +0000", "Message-Id": "<20201102085234.72779-2-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201102085234.72779-1-stevex.yang@intel.com>", "References": "<20201028030334.30300-1-stevex.yang@intel.com>\n <20201102085234.72779-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for\n\tVLAN packets", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the max rx packet length is smaller than the sum of mtu size and\nether overhead size, it should be enlarged, otherwise the VLAN packets\nwill be dropped.\n\nFixes: 35b2d13fd6fd (\"net: add rte prefix to ether defines\")\n\nSigned-off-by: SteveX Yang <stevex.yang@intel.com>\n---\n app/test-pmd/testpmd.c | 23 +++++++++++++++++++++++\n 1 file changed, 23 insertions(+)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 33fc0fddf..c263121a9 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -1421,6 +1421,7 @@ init_config(void)\n \tstruct rte_gro_param gro_param;\n \tuint32_t gso_types;\n \tuint16_t data_size;\n+\tuint16_t overhead_len;\n \tbool warning = 0;\n \tint k;\n \tint ret;\n@@ -1457,6 +1458,28 @@ init_config(void)\n \t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t \"rte_eth_dev_info_get() failed\\n\");\n \n+\t\t/* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */\n+\t\tif (port->dev_info.max_rx_pktlen && port->dev_info.max_mtu)\n+\t\t\toverhead_len = port->dev_info.max_rx_pktlen -\n+\t\t\t\tport->dev_info.max_mtu;\n+\t\telse\n+\t\t\toverhead_len = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;\n+\n+\t\tport->dev_conf.rxmode.max_rx_pkt_len =\n+\t\t\t\t\t\tRTE_ETHER_MTU + overhead_len;\n+\n+\t\t/*\n+\t\t * This is workaround to avoid resize max rx packet len.\n+\t\t * Ethdev assumes jumbo frame size must be greater than\n+\t\t * RTE_ETHER_MAX_LEN, and will resize 'max_rx_pkt_len' to\n+\t\t * default value when it is greater than RTE_ETHER_MAX_LEN\n+\t\t * for normal frame.\n+\t\t */\n+\t\tif (port->dev_conf.rxmode.max_rx_pkt_len > RTE_ETHER_MAX_LEN) {\n+\t\t\tport->dev_conf.rxmode.offloads |=\n+\t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t\t}\n+\n \t\tif (!(port->dev_info.tx_offload_capa &\n \t\t DEV_TX_OFFLOAD_MBUF_FAST_FREE))\n \t\t\tport->dev_conf.txmode.offloads &=\n", "prefixes": [ "v8", "1/2" ] }