Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82990/?format=api
{ "id": 82990, "url": "https://patches.dpdk.org/api/patches/82990/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201030174617.1958-1-nick.connolly@mayadata.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201030174617.1958-1-nick.connolly@mayadata.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20201030174617.1958-1-nick.connolly@mayadata.io", "date": "2020-10-30T17:46:16", "name": "Windows: minor build fixes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "16295aaa54b0c5775063ccd19004d9cb7aab9236", "submitter": { "id": 1861, "url": "https://patches.dpdk.org/api/people/1861/?format=api", "name": "Nick Connolly", "email": "nick.connolly@mayadata.io" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201030174617.1958-1-nick.connolly@mayadata.io/mbox/", "series": [ { "id": 13506, "url": "https://patches.dpdk.org/api/series/13506/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13506", "date": "2020-10-30T17:46:16", "name": "Windows: minor build fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/13506/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/82990/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/82990/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1C0C8A04E6;\n\tFri, 30 Oct 2020 18:50:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 92D262E8D;\n\tFri, 30 Oct 2020 18:47:40 +0100 (CET)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 9009F2E8B\n for <dev@dpdk.org>; Fri, 30 Oct 2020 18:47:38 +0100 (CET)", "by mail-wr1-f66.google.com with SMTP id b8so7417322wrn.0\n for <dev@dpdk.org>; Fri, 30 Oct 2020 10:47:38 -0700 (PDT)", "from FENIX.localdomain\n (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78])\n by smtp.gmail.com with ESMTPSA id f5sm5321679wmh.16.2020.10.30.10.47.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 30 Oct 2020 10:47:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=mayadata-io.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=LT+lpcGUfGMVRTdENgAUAqgfals5S6Ljv4w2B3N90oE=;\n b=UzaX+IoEQtCZmEnlyrF3kAkG0zwZ0BtbM7r+QEu+H0gAD3OsS8UFR+Ij+FYUXFzs2X\n FOcuiZqlEkLGrUlswhfb3o9v1wNNpHNf5GtZ7fj1YW1DOeR2T2Ih7s669WbctEAgaGNw\n IwEzVMbJBl3scpfrRcVvlMrE9Zcew4Fl7E4+co2aocXzJTpV0yLe2ROw9WVm52MnE7/s\n 67rYy+/Zuu3TMmIQVtb+ebjEHJNc7sZQMW7aOA84MRj4Dccl8cXitQIbBI80IGQmVOhN\n kdckpBIc/s9r0suvZkjBMHs0J2em5SolvedsRV/Q4jhU8HqzXVxc76cQGDVRs5QKwRZC\n um1A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=LT+lpcGUfGMVRTdENgAUAqgfals5S6Ljv4w2B3N90oE=;\n b=ms6TbDTtmq3W4aiWN8gYNe+N+F1U1gWh7vrTkdPVpOcIvXK4t5zgqupJ30ZwmFeL/J\n gd9e8Ir7lTRc4aete8pKlz1mzecma4m6C16ly4FFrHxhpdWFwTVZPcNlprv++bkiZn7B\n g5vWmmOh6VRjB37dwXInQLbhgllcEwzpSGxhOq1APxqLy9NCcz9CnyfAMY8vOGVLCaOP\n C+E25Lkv1bHG4kiUq8qzwP9LTj14lsrSifLtJxCE1WnUg5XSAcrl16w/qXWschGGMg6d\n TNSPMQMqayCbFsQz7J3vB6134aC8yiJnkL7Y1nu+KkK+le4oLmU2a2+Zki51QNhWQhUK\n Ab5A==", "X-Gm-Message-State": "AOAM533071BmK7Lw8ZHYAleMRNni9Lw8BfoCGhn+SIVPs9WaiAo3mf5e\n rXKgjKXaIHXQ9ZlRHHZyZzlyew==", "X-Google-Smtp-Source": "\n ABdhPJwikfWxh/yngCQLpG3LH9x/Dz9IJVvBpuy0iLdYe8htA+6HfG7+cUoxDpjnZzW0E2hgQYDrvA==", "X-Received": "by 2002:adf:cd87:: with SMTP id q7mr4582334wrj.169.1604080057271;\n Fri, 30 Oct 2020 10:47:37 -0700 (PDT)", "From": "Nick Connolly <nick.connolly@mayadata.io>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org,\n\tNick Connolly <nick.connolly@mayadata.io>", "Date": "Fri, 30 Oct 2020 17:46:16 +0000", "Message-Id": "<20201030174617.1958-1-nick.connolly@mayadata.io>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] Windows: minor build fixes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Don't run symlink-drivers-solibs.sh as part of 'install' because\nWindows doesn't support shell scripts, causing the install to\nfail.\n\nMeson versions >= 0.54.0 include support for handling /implib\nwith msvc link. Specifying it explicitly causes failures when\nlinking against the dll. Tested using Link 14.27.29112.0 and\nClang 11.0.0.\n\nSigned-off-by: Nick Connolly <nick.connolly@mayadata.io>\n---\n config/meson.build | 8 +++++---\n drivers/meson.build | 6 ++++--\n lib/meson.build | 6 ++++--\n 3 files changed, 13 insertions(+), 7 deletions(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 258b01d06..a29693b88 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -57,9 +57,11 @@ eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)\n # driver .so files often depend upon the bus drivers for their connect bus,\n # e.g. ixgbe depends on librte_bus_pci. This means that the bus drivers need\n # to be in the library path, so symlink the drivers from the main lib directory.\n-meson.add_install_script('../buildtools/symlink-drivers-solibs.sh',\n-\t\tget_option('libdir'),\n-\t\tpmd_subdir_opt)\n+if not is_windows\n+\tmeson.add_install_script('../buildtools/symlink-drivers-solibs.sh',\n+\t\t\tget_option('libdir'),\n+\t\t\tpmd_subdir_opt)\n+endif\n \n # set the machine type and cflags for it\n if meson.is_cross_build()\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex 4bb7e9218..6b50f7238 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -186,8 +186,10 @@ foreach subpath:subdirs\n \t\t\tlk_deps = [version_map, def_file, mingw_map]\n \t\t\tif is_windows\n \t\t\t\tif is_ms_linker\n-\t\t\t\t\tlk_args = ['-Wl,/def:' + def_file.full_path(),\n-\t\t\t\t\t\t'-Wl,/implib:drivers\\\\' + implib]\n+\t\t\t\t\tlk_args = ['-Wl,/def:' + def_file.full_path()]\n+\t\t\t\t\tif meson.version().version_compare('<0.54.0')\n+\t\t\t\t\t\tlk_args += ['-Wl,/implib:drivers\\\\' + implib]\n+\t\t\t\t\tendif\n \t\t\t\telse\n \t\t\t\t\tlk_args = ['-Wl,--version-script=' + mingw_map.full_path()]\n \t\t\t\tendif\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 1bb019720..ed00f8914 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -157,8 +157,10 @@ foreach l:libraries\n \t\t\t\toutput: '@0@_mingw.map'.format(libname))\n \n \t\t\tif is_ms_linker\n-\t\t\t\tlk_args = ['-Wl,/def:' + def_file.full_path(),\n-\t\t\t\t\t'-Wl,/implib:lib\\\\' + implib]\n+\t\t\t\tlk_args = ['-Wl,/def:' + def_file.full_path()]\n+\t\t\t\tif meson.version().version_compare('<0.54.0')\n+\t\t\t\t\tlk_args += ['-Wl,/implib:lib\\\\' + implib]\n+\t\t\t\tendif\n \t\t\telse\n \t\t\t\tif is_windows\n \t\t\t\t\tlk_args = ['-Wl,--version-script=' + mingw_map.full_path()]\n", "prefixes": [] }