Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82761/?format=api
{ "id": 82761, "url": "https://patches.dpdk.org/api/patches/82761/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1603975917-28576-5-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603975917-28576-5-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603975917-28576-5-git-send-email-oulijun@huawei.com", "date": "2020-10-29T12:51:53", "name": "[v3,4/8] net/hns3: fix uncheck return value warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3f320a1a528bba1d033fb4279f8cc9e8e54c878e", "submitter": { "id": 1675, "url": "https://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1603975917-28576-5-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 13462, "url": "https://patches.dpdk.org/api/series/13462/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13462", "date": "2020-10-29T12:51:50", "name": "hns3 misc updates", "version": 3, "mbox": "https://patches.dpdk.org/series/13462/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/82761/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/82761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4ADC0A04B5;\n\tThu, 29 Oct 2020 13:52:53 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5B2F8CCDC;\n\tThu, 29 Oct 2020 13:51:40 +0100 (CET)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by dpdk.org (Postfix) with ESMTP id 49C6FCBAF\n for <dev@dpdk.org>; Thu, 29 Oct 2020 13:51:33 +0100 (CET)", "from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CMQLF5dxqzLrC6\n for <dev@dpdk.org>; Thu, 29 Oct 2020 20:51:33 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id\n 14.3.487.0; Thu, 29 Oct 2020 20:51:22 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@huawei.com>", "Date": "Thu, 29 Oct 2020 20:51:53 +0800", "Message-ID": "<1603975917-28576-5-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1603975917-28576-1-git-send-email-oulijun@huawei.com>", "References": "<1603975751-27955-1-git-send-email-oulijun@huawei.com>\n <1603975917-28576-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v3 4/8] net/hns3: fix uncheck return value warning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hongbo Zheng <zhenghongbo3@huawei.com>\n\nThere are coverity defects related \"calling\nhns3_reset_all_tqps without checking return value\nin hns3_do_start\".\n\nThis patch fixes the warning by add \"void\" declaration\nbecause here is exception handling, hns3_reset_all_tqps\nwill have the corresponding error message if it is\nhandled incorrectly, so it is not necessary to check\nhns3_reset_all_tqps return value, here keep ret as the\nerror code causing the exception.\n\nCoverity issue: 363048\nFixes: fa29fe45a7b4 (\"net/hns3: support queue start and stop\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 6342c70..6b4be76 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -4752,7 +4752,13 @@ hns3_do_start(struct hns3_adapter *hns, bool reset_queue)\n \n err_config_mac_mode:\n \thns3_dev_release_mbufs(hns);\n-\thns3_reset_all_tqps(hns);\n+\t/*\n+\t * Here is exception handling, hns3_reset_all_tqps will have the\n+\t * corresponding error message if it is handled incorrectly, so it is\n+\t * not necessary to check hns3_reset_all_tqps return value, here keep\n+\t * ret as the error code causing the exception.\n+\t */\n+\t(void)hns3_reset_all_tqps(hns);\n \treturn ret;\n }\n \n", "prefixes": [ "v3", "4/8" ] }