Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82645/?format=api
{ "id": 82645, "url": "https://patches.dpdk.org/api/patches/82645/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201028122013.31104-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201028122013.31104-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201028122013.31104-4-david.marchand@redhat.com", "date": "2020-10-28T12:20:07", "name": "[v2,3/9] net/ark: remove use of seqn for debug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c810ffd2f85563d4dc4216f3144ecce39fd16ade", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201028122013.31104-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 13421, "url": "https://patches.dpdk.org/api/series/13421/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13421", "date": "2020-10-28T12:20:05", "name": "remove mbuf seqn", "version": 2, "mbox": "https://patches.dpdk.org/series/13421/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/82645/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/82645/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD2EFA04DD;\n\tWed, 28 Oct 2020 13:21:29 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 75904CA5E;\n\tWed, 28 Oct 2020 13:20:41 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [63.128.21.124])\n by dpdk.org (Postfix) with ESMTP id 0408FCA38\n for <dev@dpdk.org>; Wed, 28 Oct 2020 13:20:35 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-180-34gyyAwdM-OrFa0IBxI-kg-1; Wed, 28 Oct 2020 08:20:32 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com\n [10.5.11.22])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B08501084C94;\n Wed, 28 Oct 2020 12:20:31 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.40])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 62E1D10013DB;\n Wed, 28 Oct 2020 12:20:30 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1603887634;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Ofr52FRB1pXg7Sl18jqqFewPn4uWCsB9eFoh65db2FA=;\n b=FpzGKqvX+ZrGyKCltVUk2NIyOLPIT6ate/D2fGT23TXucI4mx4+wLowRv6Ciiimp50tQyX\n 1ObmZWAsOXdF2KMt+/wJVbGJJOGVQBZRFLvh0q4JdoD9sFXsBIphMTJoLk2Bb5T9HficSF\n FgsYz+OwH6My11WZ+FY5r5AlOAHHd8Y=", "X-MC-Unique": "34gyyAwdM-OrFa0IBxI-kg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Shepard Siegel <shepard.siegel@atomicrules.com>,\n Ed Czeck <ed.czeck@atomicrules.com>,\n John Miller <john.miller@atomicrules.com>", "Date": "Wed, 28 Oct 2020 13:20:07 +0100", "Message-Id": "<20201028122013.31104-4-david.marchand@redhat.com>", "In-Reply-To": "<20201028122013.31104-1-david.marchand@redhat.com>", "References": "<20201027221343.28551-1-david.marchand@redhat.com>\n <20201028122013.31104-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v2 3/9] net/ark: remove use of seqn for debug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The seqn mbuf field is deprecated.\nIt is currently hacked for debug purpose, it could be changed to a\ndynamic field but I see little value in the debug info it offers.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/ark/ark_ethdev_rx.c | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c\nindex 825b4791be..c24cc00e2f 100644\n--- a/drivers/net/ark/ark_ethdev_rx.c\n+++ b/drivers/net/ark/ark_ethdev_rx.c\n@@ -302,8 +302,6 @@ eth_ark_recv_pkts(void *rx_queue,\n \t\t\t\tmbuf->pkt_len = 63;\n \t\t\t\tmeta->pkt_len = 63;\n \t\t\t}\n-\t\t\t/* seqn is only set under debug */\n-\t\t\tmbuf->seqn = cons_index;\n \t\t}\n \n \t\tif (unlikely(meta->pkt_len > ARK_RX_MAX_NOCHAIN))\n@@ -360,8 +358,6 @@ eth_ark_rx_jumbo(struct ark_rx_queue *queue,\n \t\tmbuf_prev = mbuf;\n \t\tmbuf->data_len = data_len;\n \t\tmbuf->data_off = 0;\n-\t\tif (ARK_DEBUG_CORE)\n-\t\t\tmbuf->seqn = cons_index;\t/* for debug only */\n \n \t\tcons_index += 1;\n \t}\n@@ -667,8 +663,8 @@ dump_mbuf_data(struct rte_mbuf *mbuf, uint16_t lo, uint16_t hi)\n {\n \tuint16_t i, j;\n \n-\tARK_PMD_LOG(DEBUG, \" MBUF: %p len %d, off: %d, seq: %\" PRIU32 \"\\n\",\n-\t\t mbuf, mbuf->pkt_len, mbuf->data_off, mbuf->seqn);\n+\tARK_PMD_LOG(DEBUG, \" MBUF: %p len %d, off: %d\\n\",\n+\t\t mbuf, mbuf->pkt_len, mbuf->data_off);\n \tfor (i = lo; i < hi; i += 16) {\n \t\tuint8_t *dp = RTE_PTR_ADD(mbuf->buf_addr, i);\n \n", "prefixes": [ "v2", "3/9" ] }