Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82627/?format=api
{ "id": 82627, "url": "https://patches.dpdk.org/api/patches/82627/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201028102640.3191964-15-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201028102640.3191964-15-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201028102640.3191964-15-thomas@monjalon.net", "date": "2020-10-28T10:26:39", "name": "[v4,14/15] examples/rxtx_callbacks: switch to dynamic mbuf field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9808f22e7bb20d1cbee25e0f8d24509396f0f22f", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201028102640.3191964-15-thomas@monjalon.net/mbox/", "series": [ { "id": 13416, "url": "https://patches.dpdk.org/api/series/13416/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13416", "date": "2020-10-28T10:26:25", "name": "remove mbuf userdata", "version": 4, "mbox": "https://patches.dpdk.org/series/13416/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/82627/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/82627/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D6782A04DD;\n\tWed, 28 Oct 2020 11:31:38 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 30CA8CA90;\n\tWed, 28 Oct 2020 11:27:46 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id EB025CA37\n for <dev@dpdk.org>; Wed, 28 Oct 2020 11:27:29 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id A25FC5C01A3;\n Wed, 28 Oct 2020 06:27:29 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Wed, 28 Oct 2020 06:27:29 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 8DC473280060;\n Wed, 28 Oct 2020 06:27:28 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=4yZj+8b1nOxb6\n ehMxfOUTqIE3F/4Ed8jzYXpIR+VKNk=; b=dn3oNt53fRvWVC2c3G+Bmb6eYRQmm\n JY89+hgmWcj0K2GgPLmLlaQiOsjlqvf3P+EORxUrY9+dKzH4fuJZqTK/DpuBXvNw\n pdRfOEgUlFo7KMaUuG5ibH1nTUSVBWGnJJ3/m9WPWTjd1LRJghUYuTSPRV1P66vs\n 4jsuCuJAfccJqadsEaDeXklvY6/avpMXnhw7S0c7Y5k4kLh9JyiMP4k6UNh/FZha\n u9LWyekngkjGl7q7Cw9LyChyQfO/8qGF0rdUDBRtxz+C5EtLkZ0eNtTMAljyGgaW\n bm0gSYX7Mmj5VR/aKsDZUo0AiGUOdq4S+BiuitdrglMNmIjC2h07PupIA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=4yZj+8b1nOxb6ehMxfOUTqIE3F/4Ed8jzYXpIR+VKNk=; b=DeMwK5Mt\n nMZezv1aObd1a4aMvw8IKmq/gSt2mkccjHSnBvVkwcOqX+cQ64hlbDZi5C9/+rGI\n roy3yezNGOxSGSbyH+Z5Cw70wDPxKVlX81qQG5OiLjVyGzrymLy4VJqt070u+lol\n V7IFD6vQwYeveLD83NjVjbCKYKTeAsy3tU8XE934PuXpo/SExs4nRBS+aZxt0EvZ\n hsOxzdUo0jJ7pd8+7+ALoVfL2q3GgXVjdSjI7B4j+vE9Gy8lEMCdfJ3NdQ8Z3fBp\n cx8yNIf4+5agm8TJfjliBjWzZ5wkIZ8cShgAhbOay6UYpSY8I20OHExOE+olspLz\n MPC5qXGvyI/IaQ==" ], "X-ME-Sender": "<xms:kUeZXz3Q2LoKW4R_hL5mEzKjrzAvXA35KrGnlOHZBR3vUl3_-TsaUw>\n <xme:kUeZXyGUmX-NeWjchNXejN-orDiMevATUkLx41ukhUmEzgqnD6CcOhN6QWMlQUI8o\n PGR66k4IGjFIU8-SQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrledugdduhecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu\n tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgepleenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho\n nhdrnhgvth", "X-ME-Proxy": "<xmx:kUeZXz4QRnOS62z1tlRlS4yJCNloJew_6mdABt9U-fDRCy5Bzgjv_w>\n <xmx:kUeZX40KeAlJDNQIEWE6P8ZvezLRnZbs7Hta8_LsGg21_qBDnuodRw>\n <xmx:kUeZX2Hw1h1CY4clO17ULJqfP-l3q6-H9xmPlMxJ5rDsrDjKm0v1Gg>\n <xmx:kUeZXzMG_Hg88IpukpES-8QsDZzqoa3ivw1XlD28bavRVuxTnO13yw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com,\n John McNamara <john.mcnamara@intel.com>", "Date": "Wed, 28 Oct 2020 11:26:39 +0100", "Message-Id": "<20201028102640.3191964-15-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201028102640.3191964-1-thomas@monjalon.net>", "References": "<20201026052105.1561859-1-thomas@monjalon.net>\n <20201028102640.3191964-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 14/15] examples/rxtx_callbacks: switch to\n\tdynamic mbuf field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The example used the deprecated mbuf field udata64.\nIt is moved to a dynamic field in order to allow removal of udata64.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n doc/guides/sample_app_ug/rxtx_callbacks.rst | 4 ++--\n examples/rxtx_callbacks/main.c | 20 ++++++++++++++++++--\n 2 files changed, 20 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/sample_app_ug/rxtx_callbacks.rst b/doc/guides/sample_app_ug/rxtx_callbacks.rst\nindex 62d1f39d7e..56c4293a1a 100644\n--- a/doc/guides/sample_app_ug/rxtx_callbacks.rst\n+++ b/doc/guides/sample_app_ug/rxtx_callbacks.rst\n@@ -152,7 +152,7 @@ all packets received:\n uint64_t now = rte_rdtsc();\n \n for (i = 0; i < nb_pkts; i++)\n- pkts[i]->udata64 = now;\n+ TSC_FIELD(pkts[i]) = now;\n \n return nb_pkts;\n }\n@@ -179,7 +179,7 @@ packets prior to transmission:\n unsigned i;\n \n for (i = 0; i < nb_pkts; i++)\n- cycles += now - pkts[i]->udata64;\n+ cycles += now - TSC_FIELD(pkts[i]);\n \n latency_numbers.total_cycles += cycles;\n latency_numbers.total_pkts += nb_pkts;\ndiff --git a/examples/rxtx_callbacks/main.c b/examples/rxtx_callbacks/main.c\nindex 6fe39546dd..b9a98ceddc 100644\n--- a/examples/rxtx_callbacks/main.c\n+++ b/examples/rxtx_callbacks/main.c\n@@ -10,6 +10,7 @@\n #include <rte_cycles.h>\n #include <rte_lcore.h>\n #include <rte_mbuf.h>\n+#include <rte_mbuf_dyn.h>\n \n #define RX_RING_SIZE 1024\n #define TX_RING_SIZE 1024\n@@ -18,6 +19,11 @@\n #define MBUF_CACHE_SIZE 250\n #define BURST_SIZE 32\n \n+typedef uint64_t tsc_t;\n+static int tsc_dynfield_offset = -1;\n+#define TSC_FIELD(mbuf) (*RTE_MBUF_DYNFIELD(mbuf, \\\n+\t\ttsc_dynfield_offset, tsc_t *))\n+\n static const char usage[] =\n \t\"%s EAL_ARGS -- [-t]\\n\";\n \n@@ -47,7 +53,7 @@ add_timestamps(uint16_t port __rte_unused, uint16_t qidx __rte_unused,\n \tuint64_t now = rte_rdtsc();\n \n \tfor (i = 0; i < nb_pkts; i++)\n-\t\tpkts[i]->udata64 = now;\n+\t\tTSC_FIELD(pkts[i]) = now;\n \treturn nb_pkts;\n }\n \n@@ -65,7 +71,7 @@ calc_latency(uint16_t port, uint16_t qidx __rte_unused,\n \t\trte_eth_read_clock(port, &ticks);\n \n \tfor (i = 0; i < nb_pkts; i++) {\n-\t\tcycles += now - pkts[i]->udata64;\n+\t\tcycles += now - TSC_FIELD(pkts[i]);\n \t\tif (hw_timestamping)\n \t\t\tqueue_ticks += ticks - pkts[i]->timestamp;\n \t}\n@@ -261,6 +267,11 @@ main(int argc, char *argv[])\n \t};\n \tint opt, option_index;\n \n+\tstatic const struct rte_mbuf_dynfield tsc_dynfield_desc = {\n+\t\t.name = \"example_bbdev_dynfield_tsc\",\n+\t\t.size = sizeof(tsc_t),\n+\t\t.align = __alignof__(tsc_t),\n+\t};\n \n \t/* init EAL */\n \tint ret = rte_eal_init(argc, argv);\n@@ -292,6 +303,11 @@ main(int argc, char *argv[])\n \tif (mbuf_pool == NULL)\n \t\trte_exit(EXIT_FAILURE, \"Cannot create mbuf pool\\n\");\n \n+\ttsc_dynfield_offset =\n+\t\trte_mbuf_dynfield_register(&tsc_dynfield_desc);\n+\tif (tsc_dynfield_offset < 0)\n+\t\trte_exit(EXIT_FAILURE, \"Cannot register mbuf field\\n\");\n+\n \t/* initialize all ports */\n \tRTE_ETH_FOREACH_DEV(portid)\n \t\tif (port_init(portid, mbuf_pool) != 0)\n", "prefixes": [ "v4", "14/15" ] }