Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82626/?format=api
{ "id": 82626, "url": "https://patches.dpdk.org/api/patches/82626/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201028102640.3191964-14-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201028102640.3191964-14-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201028102640.3191964-14-thomas@monjalon.net", "date": "2020-10-28T10:26:38", "name": "[v4,13/15] examples/bbdev: switch to dynamic mbuf field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5e0e93c3ab4431d661edb3b3eca7a078df4aeeb5", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201028102640.3191964-14-thomas@monjalon.net/mbox/", "series": [ { "id": 13416, "url": "https://patches.dpdk.org/api/series/13416/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13416", "date": "2020-10-28T10:26:25", "name": "remove mbuf userdata", "version": 4, "mbox": "https://patches.dpdk.org/series/13416/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/82626/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/82626/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA927A04DD;\n\tWed, 28 Oct 2020 11:31:19 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7F3BCCA87;\n\tWed, 28 Oct 2020 11:27:44 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 154EFCA37\n for <dev@dpdk.org>; Wed, 28 Oct 2020 11:27:29 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id B91005C01A1;\n Wed, 28 Oct 2020 06:27:27 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Wed, 28 Oct 2020 06:27:27 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id A38FD3280064;\n Wed, 28 Oct 2020 06:27:26 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=tQuKWbiliUVAj\n SSPhKYtMVm5sa1lzLavUnMWeV38LP4=; b=pQ2qcIVb6b0KG+f5xYENUi3NPhaF/\n eUzDKLLqcbpkGno9c8VnOyCvuXZoDOYrdARSZZqHXQ8bZII+08MfzGceq3PiCXfv\n hy6haMlAeEyHCGW2Dix3McfA2KmAWvH1hVUO0l+NmqrCdrvIkT3bjsz8rqKghGCh\n RmeCurlEo7P0tpVX3XI3tcuuL2La9ylzVdtSXUg5mHa7UL+G00JBLw46ryRn+2Q5\n hahIwsa3kxm7DF4GY5NhA0lg8q6yQy4ezcCp+TtAN5itfjooh3AF2BGBWOkWl02X\n hOXO0cj1aQnikzFIA9yTpO0wOIgzqfn27Z51g4gMcF6LpZgnAMMNWV83g==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=tQuKWbiliUVAjSSPhKYtMVm5sa1lzLavUnMWeV38LP4=; b=ZrNtfIe6\n F+PDDcdAxrW8T1qZ/FItjQ5oVPEa/iBD1EI7nqYfAKUTvvhTFhvqauyWMmrnKkuE\n 6EU00+Ms7SxnqYfylz0MX4HjVArjOi98ioViemjCljJcHQKTnQNqawfeyhiFDf7H\n h5ymPLNNjlv0j+M7ODqE0NXgUP+kQlqEHG4cfYAmSBqtg0xCodK4O9QQW78CIjwV\n kQ7VIfSa260HwLUC65Ngodu3+BmYlhdvR0cktazSmv2VK0nKBALgfbeoHGKQvFNP\n cJNWP4JMpprafMGrCaq6E+5LNQl3A+e2T3C2WPV9pFfoON1m1eFTmllpNtw64odp\n 608zDFEbqvlY0Q==" ], "X-ME-Sender": "<xms:j0eZX6AVSoDYNtUDF8cI-IyM0Cf0VpimCKHT4vC2HVBPQqGrJXosvA>\n <xme:j0eZX0gRbyZqy1vA32iM6vtTuZZZCyHXpDyLqcJqSveKUWRj5zg2FeiOZq63MonOP\n DT8epVabQJrlooCBw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrledugdduhecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu\n tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgepleenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho\n nhdrnhgvth", "X-ME-Proxy": "<xmx:j0eZX9ljkXximAfKtUJjrsNENZfXDoZEUYJkBTp2NwNtgBonuRFvQw>\n <xmx:j0eZX4zliyjvY5OHkSBk2l8q-tyT0ImJhpV4-QWpblfbCBsbsMWDGg>\n <xmx:j0eZX_RIIDWMaKGT3YfBsciAWBPV_bY0FN8XaewHgjh8OJKp1wUaiQ>\n <xmx:j0eZXwIhgD3wSae0BuiUKky2d9HnhqMT_tN8YCqi185hI0wyjw4eWQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com,\n Nicolas Chautru <nicolas.chautru@intel.com>", "Date": "Wed, 28 Oct 2020 11:26:38 +0100", "Message-Id": "<20201028102640.3191964-14-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201028102640.3191964-1-thomas@monjalon.net>", "References": "<20201026052105.1561859-1-thomas@monjalon.net>\n <20201028102640.3191964-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 13/15] examples/bbdev: switch to dynamic mbuf\n\tfield", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The example used the deprecated mbuf field udata64 as input mbuf pointer.\nIt is moved to a dynamic field in order to allow removal of udata64.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n examples/bbdev_app/main.c | 49 +++++++++++++++++++++++++++++++--------\n 1 file changed, 39 insertions(+), 10 deletions(-)", "diff": "diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c\nindex e512c807cd..63e8b18e44 100644\n--- a/examples/bbdev_app/main.c\n+++ b/examples/bbdev_app/main.c\n@@ -28,6 +28,7 @@\n #include <rte_lcore.h>\n #include <rte_malloc.h>\n #include <rte_mbuf.h>\n+#include <rte_mbuf_dyn.h>\n #include <rte_memory.h>\n #include <rte_mempool.h>\n #include <rte_log.h>\n@@ -59,6 +60,22 @@\n \t} \\\n } while (0)\n \n+static int input_dynfield_offset = -1;\n+\n+static inline struct rte_mbuf *\n+get_mbuf_input(struct rte_mbuf *mbuf)\n+{\n+\treturn *RTE_MBUF_DYNFIELD(mbuf,\n+\t\t\tinput_dynfield_offset, struct rte_mbuf **);\n+}\n+\n+static inline void\n+set_mbuf_input(struct rte_mbuf *mbuf, struct rte_mbuf *input)\n+{\n+\t*RTE_MBUF_DYNFIELD(mbuf,\n+\t\t\tinput_dynfield_offset, struct rte_mbuf **) = input;\n+}\n+\n static const struct rte_eth_conf port_conf = {\n \t.rxmode = {\n \t\t.mq_mode = ETH_MQ_RX_NONE,\n@@ -294,11 +311,11 @@ pktmbuf_free_bulk(struct rte_mbuf **mbufs, unsigned int nb_to_free)\n }\n \n static inline void\n-pktmbuf_userdata_free_bulk(struct rte_mbuf **mbufs, unsigned int nb_to_free)\n+pktmbuf_input_free_bulk(struct rte_mbuf **mbufs, unsigned int nb_to_free)\n {\n \tunsigned int i;\n \tfor (i = 0; i < nb_to_free; ++i) {\n-\t\tstruct rte_mbuf *rx_pkt = mbufs[i]->userdata;\n+\t\tstruct rte_mbuf *rx_pkt = get_mbuf_input(mbufs[i]);\n \t\trte_pktmbuf_free(rx_pkt);\n \t\trte_pktmbuf_free(mbufs[i]);\n \t}\n@@ -429,7 +446,7 @@ verify_data(struct rte_mbuf **mbufs, uint16_t num_pkts)\n \tuint16_t i;\n \tfor (i = 0; i < num_pkts; ++i) {\n \t\tstruct rte_mbuf *out = mbufs[i];\n-\t\tstruct rte_mbuf *in = out->userdata;\n+\t\tstruct rte_mbuf *in = get_mbuf_input(out);\n \n \t\tif (memcmp(rte_pktmbuf_mtod_offset(in, uint8_t *,\n \t\t\t\tsizeof(struct rte_ether_hdr)),\n@@ -731,7 +748,7 @@ run_encoding(struct lcore_conf *lcore_conf)\n \t\t\t\trte_pktmbuf_data_len(rx_pkts_burst[i]) -\n \t\t\t\tsizeof(struct rte_ether_hdr);\n \t\t/* save input mbuf pointer for later comparison */\n-\t\tenc_out_pkts[i]->userdata = rx_pkts_burst[i];\n+\t\tset_mbuf_input(enc_out_pkts[i], rx_pkts_burst[i]);\n \n \t\t/* copy ethernet header */\n \t\trte_pktmbuf_reset(enc_out_pkts[i]);\n@@ -775,7 +792,7 @@ run_encoding(struct lcore_conf *lcore_conf)\n \tnb_enq = rte_bbdev_enqueue_enc_ops(bbdev_id, enc_queue_id,\n \t\t\tbbdev_ops_burst, nb_rx);\n \tif (unlikely(nb_enq < nb_rx)) {\n-\t\tpktmbuf_userdata_free_bulk(&enc_out_pkts[nb_enq],\n+\t\tpktmbuf_input_free_bulk(&enc_out_pkts[nb_enq],\n \t\t\t\tnb_rx - nb_enq);\n \t\trte_bbdev_enc_op_free_bulk(&bbdev_ops_burst[nb_enq],\n \t\t\t\tnb_rx - nb_enq);\n@@ -805,7 +822,7 @@ run_encoding(struct lcore_conf *lcore_conf)\n \tnb_sent = rte_ring_enqueue_burst(enc_to_dec_ring, (void **)enc_out_pkts,\n \t\t\tnb_deq, NULL);\n \tif (unlikely(nb_sent < nb_deq)) {\n-\t\tpktmbuf_userdata_free_bulk(&enc_out_pkts[nb_sent],\n+\t\tpktmbuf_input_free_bulk(&enc_out_pkts[nb_sent],\n \t\t\t\tnb_deq - nb_sent);\n \t\tlcore_stats->enc_to_dec_lost_packets += nb_deq - nb_sent;\n \t}\n@@ -842,7 +859,7 @@ run_decoding(struct lcore_conf *lcore_conf)\n \n \tif (unlikely(rte_bbdev_dec_op_alloc_bulk(bbdev_op_pool, bbdev_ops_burst,\n \t\t\tnb_recv) != 0)) {\n-\t\tpktmbuf_userdata_free_bulk(recv_pkts_burst, nb_recv);\n+\t\tpktmbuf_input_free_bulk(recv_pkts_burst, nb_recv);\n \t\tlcore_stats->rx_lost_packets += nb_recv;\n \t\treturn;\n \t}\n@@ -871,7 +888,7 @@ run_decoding(struct lcore_conf *lcore_conf)\n \tnb_enq = rte_bbdev_enqueue_dec_ops(bbdev_id, bbdev_queue_id,\n \t\t\tbbdev_ops_burst, nb_recv);\n \tif (unlikely(nb_enq < nb_recv)) {\n-\t\tpktmbuf_userdata_free_bulk(&recv_pkts_burst[nb_enq],\n+\t\tpktmbuf_input_free_bulk(&recv_pkts_burst[nb_enq],\n \t\t\t\tnb_recv - nb_enq);\n \t\trte_bbdev_dec_op_free_bulk(&bbdev_ops_burst[nb_enq],\n \t\t\t\tnb_recv - nb_enq);\n@@ -898,12 +915,12 @@ run_decoding(struct lcore_conf *lcore_conf)\n \n \t/* Free the RX mbufs after verification */\n \tfor (i = 0; i < nb_deq; ++i)\n-\t\trte_pktmbuf_free(recv_pkts_burst[i]->userdata);\n+\t\trte_pktmbuf_free(get_mbuf_input(recv_pkts_burst[i]));\n \n \t/* Transmit the packets */\n \tnb_tx = rte_eth_tx_burst(port_id, tx_queue_id, recv_pkts_burst, nb_deq);\n \tif (unlikely(nb_tx < nb_deq)) {\n-\t\tpktmbuf_userdata_free_bulk(&recv_pkts_burst[nb_tx],\n+\t\tpktmbuf_input_free_bulk(&recv_pkts_burst[nb_tx],\n \t\t\t\tnb_deq - nb_tx);\n \t\tlcore_stats->tx_lost_packets += nb_deq - nb_tx;\n \t}\n@@ -1046,6 +1063,12 @@ main(int argc, char **argv)\n \tbool stats_thread_started = false;\n \tunsigned int main_lcore_id = rte_get_main_lcore();\n \n+\tstatic const struct rte_mbuf_dynfield input_dynfield_desc = {\n+\t\t.name = \"example_bbdev_dynfield_input\",\n+\t\t.size = sizeof(struct rte_mbuf *),\n+\t\t.align = __alignof__(struct rte_mbuf *),\n+\t};\n+\n \trte_atomic16_init(&global_exit_flag);\n \n \tsigret = signal(SIGTERM, signal_handler);\n@@ -1115,6 +1138,12 @@ main(int argc, char **argv)\n \tif (bbdev_mbuf_mempool == NULL)\n \t\trte_exit(EXIT_FAILURE, \"Cannot create ethdev mbuf mempool\\n\");\n \n+\t/* register mbuf field to store input pointer */\n+\tinput_dynfield_offset =\n+\t\trte_mbuf_dynfield_register(&input_dynfield_desc);\n+\tif (input_dynfield_offset < 0)\n+\t\trte_exit(EXIT_FAILURE, \"Cannot register mbuf field\\n\");\n+\n \t/* initialize ports */\n \tret = initialize_ports(&app_params, ethdev_mbuf_mempool);\n \n", "prefixes": [ "v4", "13/15" ] }