Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82392/?format=api
{ "id": 82392, "url": "https://patches.dpdk.org/api/patches/82392/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201027232335.31427-3-ophirmu@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201027232335.31427-3-ophirmu@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201027232335.31427-3-ophirmu@nvidia.com", "date": "2020-10-27T23:22:25", "name": "[v1,02/72] net/mlx5: fix flow sample definitions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "122b78bf1f8ad6374c2e678bfe0fe07f282b970e", "submitter": { "id": 1908, "url": "https://patches.dpdk.org/api/people/1908/?format=api", "name": "Ophir Munk", "email": "ophirmu@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201027232335.31427-3-ophirmu@nvidia.com/mbox/", "series": [ { "id": 13395, "url": "https://patches.dpdk.org/api/series/13395/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13395", "date": "2020-10-27T23:22:23", "name": "mlx5 Windows support - part #5", "version": 1, "mbox": "https://patches.dpdk.org/series/13395/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/82392/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/82392/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 74FBDA04B5;\n\tWed, 28 Oct 2020 00:24:33 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A346F2C1A;\n\tWed, 28 Oct 2020 00:24:09 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 1CDAB2BF9\n for <dev@dpdk.org>; Wed, 28 Oct 2020 00:24:00 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n ophirmu@nvidia.com) with SMTP; 28 Oct 2020 01:23:53 +0200", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 09RNNrrE026642;\n Wed, 28 Oct 2020 01:23:53 +0200" ], "From": "Ophir Munk <ophirmu@nvidia.com>", "To": "dev@dpdk.org, Raslan Darawsheh <rasland@nvidia.com>", "Cc": "Ophir Munk <ophirmu@nvidia.com>, Matan Azrad <matan@nvidia.com>,\n Tal Shnaiderman <talshn@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>, stable@dpdk.org", "Date": "Tue, 27 Oct 2020 23:22:25 +0000", "Message-Id": "<20201027232335.31427-3-ophirmu@nvidia.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20201027232335.31427-1-ophirmu@nvidia.com>", "References": "<20201027232335.31427-1-ophirmu@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v1 02/72] net/mlx5: fix flow sample definitions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Flow sampling is dependent on rdma-core support. The definitions which\nenable sampling code are HAVE_MLX5_DR_CREATE_ACTION_FLOW_SAMPLE and\nHAVE_MLX5_DR_CREATE_ACTION_DEST_ARRAY. This commit expands these\ndefinitions to more functions which use sampling logic and structs:\nflow_dv_sample_resource_register, flow_dv_dest_array_resource_register,\nflow_dv_sample_resource_release, flow_dv_dest_array_resource_release.\nHence any system without the required rdma-core support will not compile\nor execute redundant sampling code.\n\nFixes: eb7368b0109a (\"net/mlx5: update translate function for sample action\")\nFixes: e8a1d23ae9a8 (\"net/mlx5: update translate function for mirror\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ophir Munk <ophirmu@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 37 +++++++++++++++++++++++++++++++++++++\n 1 file changed, 37 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex dafe07f..2560559 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -8629,6 +8629,7 @@ flow_dv_sample_resource_register(struct rte_eth_dev *dev,\n \t\t\t void **sample_dv_actions,\n \t\t\t struct rte_flow_error *error)\n {\n+#ifdef HAVE_MLX5_DR_CREATE_ACTION_FLOW_SAMPLE\n \tstruct mlx5_flow_dv_sample_resource *cache_resource;\n \tstruct mlx5dv_dr_flow_sampler_attr sampler_attr;\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n@@ -8746,6 +8747,17 @@ flow_dv_sample_resource_register(struct rte_eth_dev *dev,\n \t\t\t\tdev_flow->handle->dvh.rix_sample);\n \tdev_flow->handle->dvh.rix_sample = 0;\n \treturn -rte_errno;\n+#else\n+\tRTE_SET_USED(dev);\n+\tRTE_SET_USED(attr);\n+\tRTE_SET_USED(resource);\n+\tRTE_SET_USED(dev_flow);\n+\tRTE_SET_USED(sample_dv_actions);\n+\tRTE_SET_USED(error);\n+\tDRV_LOG(ERR, \"Sample resource registration is not supported.\");\n+\trte_errno = ENOTSUP;\n+\treturn -ENOTSUP;\n+#endif /* HAVE_MLX5_DR_CREATE_ACTION_FLOW_SAMPLE */\n }\n \n /**\n@@ -8772,6 +8784,7 @@ flow_dv_dest_array_resource_register(struct rte_eth_dev *dev,\n \t\t\t struct mlx5_flow *dev_flow,\n \t\t\t struct rte_flow_error *error)\n {\n+#ifdef HAVE_MLX5_DR_CREATE_ACTION_DEST_ARRAY\n \tstruct mlx5_flow_dv_dest_array_resource *cache_resource;\n \tstruct mlx5dv_dr_action_dest_attr *dest_attr[MLX5_MAX_DEST_NUM] = { 0 };\n \tstruct mlx5dv_dr_action_dest_reformat dest_reformat[MLX5_MAX_DEST_NUM];\n@@ -8894,6 +8907,16 @@ flow_dv_dest_array_resource_register(struct rte_eth_dev *dev,\n \t\t\t\tdev_flow->handle->dvh.rix_dest_array);\n \tdev_flow->handle->dvh.rix_dest_array = 0;\n \treturn -rte_errno;\n+#else\n+\tRTE_SET_USED(dev);\n+\tRTE_SET_USED(attr);\n+\tRTE_SET_USED(resource);\n+\tRTE_SET_USED(dev_flow);\n+\tRTE_SET_USED(error);\n+\tDRV_LOG(ERR, \"Dest array resource registration is not supported.\");\n+\trte_errno = ENOTSUP;\n+\treturn -ENOTSUP;\n+#endif /* HAVE_MLX5_DR_CREATE_ACTION_DEST_ARRAY */\n }\n \n /**\n@@ -10758,6 +10781,7 @@ static int\n flow_dv_sample_resource_release(struct rte_eth_dev *dev,\n \t\t\t\t struct mlx5_flow_handle *handle)\n {\n+#ifdef HAVE_MLX5_DR_CREATE_ACTION_FLOW_SAMPLE\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tuint32_t idx = handle->dvh.rix_sample;\n \tstruct mlx5_flow_dv_sample_resource *cache_resource;\n@@ -10807,6 +10831,12 @@ flow_dv_sample_resource_release(struct rte_eth_dev *dev,\n \t\treturn 0;\n \t}\n \treturn 1;\n+#else\n+\tRTE_SET_USED(dev);\n+\tRTE_SET_USED(handle);\n+\tDRV_LOG(ERR, \"Sample resource release is not supported.\");\n+\treturn 0;\n+#endif /* HAVE_MLX5_DR_CREATE_ACTION_FLOW_SAMPLE */\n }\n \n /**\n@@ -10824,6 +10854,7 @@ static int\n flow_dv_dest_array_resource_release(struct rte_eth_dev *dev,\n \t\t\t\t struct mlx5_flow_handle *handle)\n {\n+#ifdef HAVE_MLX5_DR_CREATE_ACTION_DEST_ARRAY\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tstruct mlx5_flow_dv_dest_array_resource *cache_resource;\n \tstruct mlx5_flow_sub_actions_idx *mdest_act_res;\n@@ -10875,6 +10906,12 @@ flow_dv_dest_array_resource_release(struct rte_eth_dev *dev,\n \t\treturn 0;\n \t}\n \treturn 1;\n+#else\n+\tRTE_SET_USED(dev);\n+\tRTE_SET_USED(handle);\n+\tDRV_LOG(ERR, \"Dest array resource release is not supported.\");\n+\treturn 0;\n+#endif /* ifdef HAVE_MLX5_DR_CREATE_ACTION_DEST_ARRAY */\n }\n \n /**\n", "prefixes": [ "v1", "02/72" ] }