Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81778/?format=api
{ "id": 81778, "url": "https://patches.dpdk.org/api/patches/81778/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201022095927.587840-3-roy.fan.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201022095927.587840-3-roy.fan.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201022095927.587840-3-roy.fan.zhang@intel.com", "date": "2020-10-22T09:59:27", "name": "[2/2] fips_validation: fix gcm test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ed0518d4fe56e9b236cff4f5f801129938e57ce1", "submitter": { "id": 304, "url": "https://patches.dpdk.org/api/people/304/?format=api", "name": "Fan Zhang", "email": "roy.fan.zhang@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201022095927.587840-3-roy.fan.zhang@intel.com/mbox/", "series": [ { "id": 13210, "url": "https://patches.dpdk.org/api/series/13210/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13210", "date": "2020-10-22T09:59:25", "name": "fips_validation: fix issues", "version": 1, "mbox": "https://patches.dpdk.org/series/13210/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/81778/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/81778/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C9C17A04DD;\n\tThu, 22 Oct 2020 11:59:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F16A6A996;\n\tThu, 22 Oct 2020 11:59:36 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 3BA4CA989\n for <dev@dpdk.org>; Thu, 22 Oct 2020 11:59:33 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Oct 2020 02:59:32 -0700", "from silpixa00398673.ir.intel.com (HELO\n silpixa00398673.ger.corp.intel.com) ([10.237.223.11])\n by fmsmga004.fm.intel.com with ESMTP; 22 Oct 2020 02:59:31 -0700" ], "IronPort-SDR": [ "\n oWfYGuVZeTd6ewnObSch4lG6pw1owh4yPeV4MXjeGpCKnFfuqTV4/IZMn1IveC91lxJ42u3HLY\n AhsDw1S+RXhw==", "\n BtpCriNf3Khq44DM7PO5GRXSqWuEjAnOmgSmVWLNWulfyH0o4e++Dfsug/ve7UCRZDpmHjhikB\n 21VeHORnyiWw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9781\"; a=\"229131195\"", "E=Sophos;i=\"5.77,404,1596524400\"; d=\"scan'208\";a=\"229131195\"", "E=Sophos;i=\"5.77,404,1596524400\"; d=\"scan'208\";a=\"348688705\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Fan Zhang <roy.fan.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com,\n\tFan Zhang <roy.fan.zhang@intel.com>", "Date": "Thu, 22 Oct 2020 10:59:27 +0100", "Message-Id": "<20201022095927.587840-3-roy.fan.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20201022095927.587840-1-roy.fan.zhang@intel.com>", "References": "<20201022095927.587840-1-roy.fan.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [dpdk-dev 2/2] fips_validation: fix gcm test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes FIPS GCM test of the redundant plaintext string\nwrite and insufficient test case support check for some corner\ncases.\n\nFixes: d09abf2d1007 (\"examples/fips_validation: update GCM test\")\nCc: roy.fan.zhang@intel.com\n\nSigned-off-by: Fan Zhang <roy.fan.zhang@intel.com>\n---\n examples/fips_validation/fips_validation_gcm.c | 1 -\n examples/fips_validation/main.c | 10 +++++++---\n 2 files changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c\nindex df3caa267..250d09bf9 100644\n--- a/examples/fips_validation/fips_validation_gcm.c\n+++ b/examples/fips_validation/fips_validation_gcm.c\n@@ -175,7 +175,6 @@ parse_test_gcm_writeback(struct fips_val *val)\n \t\tif (vec.status == RTE_CRYPTO_OP_STATUS_SUCCESS) {\n \t\t\tfprintf(info.fp_wr, \"%s\", PT_STR);\n \t\t\tif (!info.interim_info.gcm_data.is_gmac) {\n-\t\t\t\tfprintf(info.fp_wr, \"%s\", PT_STR);\n \t\t\t\ttmp_val.val = val->val;\n \t\t\t\ttmp_val.len = vec.pt.len;\n \ndiff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c\nindex 07532c956..f3678f056 100644\n--- a/examples/fips_validation/main.c\n+++ b/examples/fips_validation/main.c\n@@ -927,10 +927,14 @@ prepare_gmac_xform(struct rte_crypto_sym_xform *xform)\n \n \tif (rte_cryptodev_sym_capability_check_auth(cap,\n \t\t\tauth_xform->key.length,\n-\t\t\tauth_xform->digest_length, 0) != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"PMD %s key length %u IV length %u\\n\",\n+\t\t\tauth_xform->digest_length,\n+\t\t\tauth_xform->iv.length) != 0) {\n+\n+\t\tRTE_LOG(ERR, USER1,\n+\t\t\t\"PMD %s key length %u Digest length %u IV length %u\\n\",\n \t\t\t\tinfo.device_name, auth_xform->key.length,\n-\t\t\t\tauth_xform->digest_length);\n+\t\t\t\tauth_xform->digest_length,\n+\t\t\t\tauth_xform->iv.length);\n \t\treturn -EPERM;\n \t}\n \n", "prefixes": [ "2/2" ] }