Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 81715,
    "url": "https://patches.dpdk.org/api/patches/81715/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201021225006.10438-4-dharmik.thakkar@arm.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201021225006.10438-4-dharmik.thakkar@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201021225006.10438-4-dharmik.thakkar@arm.com",
    "date": "2020-10-21T22:50:05",
    "name": "[v6,3/4] test/hash: replace rte atomic with C11 atomic APIs",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "dd4c21b1380fe68f50d45db9ec1b614e793e9a53",
    "submitter": {
        "id": 1108,
        "url": "https://patches.dpdk.org/api/people/1108/?format=api",
        "name": "Dharmik Thakkar",
        "email": "dharmik.thakkar@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201021225006.10438-4-dharmik.thakkar@arm.com/mbox/",
    "series": [
        {
            "id": 13183,
            "url": "https://patches.dpdk.org/api/series/13183/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13183",
            "date": "2020-10-21T22:50:02",
            "name": "hash: integrate RCU QSBR",
            "version": 6,
            "mbox": "https://patches.dpdk.org/series/13183/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/81715/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/81715/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 09480A04DD;\n\tThu, 22 Oct 2020 00:51:24 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C47E0A573;\n\tThu, 22 Oct 2020 00:50:53 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 7D8B09AFE\n for <dev@dpdk.org>; Thu, 22 Oct 2020 00:50:44 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 83A4C143B;\n Wed, 21 Oct 2020 15:50:42 -0700 (PDT)",
            "from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com\n [10.118.12.95])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7BCEF3F66B;\n Wed, 21 Oct 2020 15:50:42 -0700 (PDT)"
        ],
        "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>",
        "To": "Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>",
        "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>",
        "Date": "Wed, 21 Oct 2020 17:50:05 -0500",
        "Message-Id": "<20201021225006.10438-4-dharmik.thakkar@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20201021225006.10438-1-dharmik.thakkar@arm.com>",
        "References": "<20201020161301.7458-1-dharmik.thakkar@arm.com>\n <20201021225006.10438-1-dharmik.thakkar@arm.com>",
        "Subject": "[dpdk-dev] [PATCH v6 3/4] test/hash: replace rte atomic with C11\n\tatomic APIs",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Replace rte_atomic APIs with C11 atomic APIs in\ntest_hash_readwrite_lf_perf.c\n\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nAcked-by: Yipeng Wang <yipeng1.wang@intel.com>\n---\n app/test/test_hash_readwrite_lf_perf.c | 89 +++++++++++---------------\n 1 file changed, 36 insertions(+), 53 deletions(-)",
    "diff": "diff --git a/app/test/test_hash_readwrite_lf_perf.c b/app/test/test_hash_readwrite_lf_perf.c\nindex 889799865c7b..328fa5116f65 100644\n--- a/app/test/test_hash_readwrite_lf_perf.c\n+++ b/app/test/test_hash_readwrite_lf_perf.c\n@@ -82,8 +82,8 @@ static struct {\n \tstruct rte_hash *h;\n } tbl_rwc_test_param;\n \n-static rte_atomic64_t gread_cycles;\n-static rte_atomic64_t greads;\n+static uint64_t gread_cycles;\n+static uint64_t greads;\n \n static volatile uint8_t writer_done;\n \n@@ -645,8 +645,8 @@ test_rwc_reader(__rte_unused void *arg)\n \t} while (!writer_done);\n \n \tcycles = rte_rdtsc_precise() - begin;\n-\trte_atomic64_add(&gread_cycles, cycles);\n-\trte_atomic64_add(&greads, read_cnt*loop_cnt);\n+\t__atomic_fetch_add(&gread_cycles, cycles, __ATOMIC_RELAXED);\n+\t__atomic_fetch_add(&greads, read_cnt*loop_cnt, __ATOMIC_RELAXED);\n \treturn 0;\n }\n \n@@ -703,9 +703,6 @@ test_hash_add_no_ks_lookup_hit(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \tuint8_t write_type = WRITE_NO_KEY_SHIFT;\n \tuint8_t read_type = READ_PASS_NO_KEY_SHIFTS;\n \n-\trte_atomic64_init(&greads);\n-\trte_atomic64_init(&gread_cycles);\n-\n \tif (init_params(rwc_lf, use_jhash, htm, ext_bkt) != 0)\n \t\tgoto err;\n \tprintf(\"\\nTest: Hash add - no key-shifts, read - hit\\n\");\n@@ -721,8 +718,8 @@ test_hash_add_no_ks_lookup_hit(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \n \t\t\tprintf(\"\\nNumber of readers: %u\\n\", rwc_core_cnt[n]);\n \n-\t\t\trte_atomic64_clear(&greads);\n-\t\t\trte_atomic64_clear(&gread_cycles);\n+\t\t\t__atomic_store_n(&greads, 0, __ATOMIC_RELAXED);\n+\t\t\t__atomic_store_n(&gread_cycles, 0, __ATOMIC_RELAXED);\n \n \t\t\trte_hash_reset(tbl_rwc_test_param.h);\n \t\t\twriter_done = 0;\n@@ -739,8 +736,8 @@ test_hash_add_no_ks_lookup_hit(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n-\t\t\t\trte_atomic64_read(&gread_cycles) /\n-\t\t\t\trte_atomic64_read(&greads);\n+\t\t\t\t__atomic_load_n(&gread_cycles, __ATOMIC_RELAXED)\n+\t\t\t\t/ __atomic_load_n(&greads, __ATOMIC_RELAXED);\n \t\t\trwc_perf_results->w_no_ks_r_hit[m][n]\n \t\t\t\t\t\t= cycles_per_lookup;\n \t\t\tprintf(\"Cycles per lookup: %llu\\n\", cycles_per_lookup);\n@@ -773,9 +770,6 @@ test_hash_add_no_ks_lookup_miss(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \tuint8_t read_type = READ_FAIL;\n \tint ret;\n \n-\trte_atomic64_init(&greads);\n-\trte_atomic64_init(&gread_cycles);\n-\n \tif (init_params(rwc_lf, use_jhash, htm, ext_bkt) != 0)\n \t\tgoto err;\n \tprintf(\"\\nTest: Hash add - no key-shifts, Hash lookup - miss\\n\");\n@@ -791,8 +785,8 @@ test_hash_add_no_ks_lookup_miss(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \n \t\t\tprintf(\"\\nNumber of readers: %u\\n\", rwc_core_cnt[n]);\n \n-\t\t\trte_atomic64_clear(&greads);\n-\t\t\trte_atomic64_clear(&gread_cycles);\n+\t\t\t__atomic_store_n(&greads, 0, __ATOMIC_RELAXED);\n+\t\t\t__atomic_store_n(&gread_cycles, 0, __ATOMIC_RELAXED);\n \n \t\t\trte_hash_reset(tbl_rwc_test_param.h);\n \t\t\twriter_done = 0;\n@@ -811,8 +805,8 @@ test_hash_add_no_ks_lookup_miss(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n-\t\t\t\trte_atomic64_read(&gread_cycles) /\n-\t\t\t\trte_atomic64_read(&greads);\n+\t\t\t\t__atomic_load_n(&gread_cycles, __ATOMIC_RELAXED)\n+\t\t\t\t/ __atomic_load_n(&greads, __ATOMIC_RELAXED);\n \t\t\trwc_perf_results->w_no_ks_r_miss[m][n]\n \t\t\t\t\t\t= cycles_per_lookup;\n \t\t\tprintf(\"Cycles per lookup: %llu\\n\", cycles_per_lookup);\n@@ -845,9 +839,6 @@ test_hash_add_ks_lookup_hit_non_sp(struct rwc_perf *rwc_perf_results,\n \tuint8_t write_type;\n \tuint8_t read_type = READ_PASS_NON_SHIFT_PATH;\n \n-\trte_atomic64_init(&greads);\n-\trte_atomic64_init(&gread_cycles);\n-\n \tif (init_params(rwc_lf, use_jhash, htm, ext_bkt) != 0)\n \t\tgoto err;\n \tprintf(\"\\nTest: Hash add - key shift, Hash lookup - hit\"\n@@ -864,8 +855,8 @@ test_hash_add_ks_lookup_hit_non_sp(struct rwc_perf *rwc_perf_results,\n \n \t\t\tprintf(\"\\nNumber of readers: %u\\n\", rwc_core_cnt[n]);\n \n-\t\t\trte_atomic64_clear(&greads);\n-\t\t\trte_atomic64_clear(&gread_cycles);\n+\t\t\t__atomic_store_n(&greads, 0, __ATOMIC_RELAXED);\n+\t\t\t__atomic_store_n(&gread_cycles, 0, __ATOMIC_RELAXED);\n \n \t\t\trte_hash_reset(tbl_rwc_test_param.h);\n \t\t\twriter_done = 0;\n@@ -887,8 +878,8 @@ test_hash_add_ks_lookup_hit_non_sp(struct rwc_perf *rwc_perf_results,\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n-\t\t\t\trte_atomic64_read(&gread_cycles) /\n-\t\t\t\trte_atomic64_read(&greads);\n+\t\t\t\t__atomic_load_n(&gread_cycles, __ATOMIC_RELAXED)\n+\t\t\t\t/ __atomic_load_n(&greads, __ATOMIC_RELAXED);\n \t\t\trwc_perf_results->w_ks_r_hit_nsp[m][n]\n \t\t\t\t\t\t= cycles_per_lookup;\n \t\t\tprintf(\"Cycles per lookup: %llu\\n\", cycles_per_lookup);\n@@ -921,9 +912,6 @@ test_hash_add_ks_lookup_hit_sp(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \tuint8_t write_type;\n \tuint8_t read_type = READ_PASS_SHIFT_PATH;\n \n-\trte_atomic64_init(&greads);\n-\trte_atomic64_init(&gread_cycles);\n-\n \tif (init_params(rwc_lf, use_jhash, htm, ext_bkt) != 0)\n \t\tgoto err;\n \tprintf(\"\\nTest: Hash add - key shift, Hash lookup - hit (shift-path)\"\n@@ -940,8 +928,9 @@ test_hash_add_ks_lookup_hit_sp(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\t\tgoto finish;\n \n \t\t\tprintf(\"\\nNumber of readers: %u\\n\", rwc_core_cnt[n]);\n-\t\t\trte_atomic64_clear(&greads);\n-\t\t\trte_atomic64_clear(&gread_cycles);\n+\n+\t\t\t__atomic_store_n(&greads, 0, __ATOMIC_RELAXED);\n+\t\t\t__atomic_store_n(&gread_cycles, 0, __ATOMIC_RELAXED);\n \n \t\t\trte_hash_reset(tbl_rwc_test_param.h);\n \t\t\twriter_done = 0;\n@@ -963,8 +952,8 @@ test_hash_add_ks_lookup_hit_sp(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n-\t\t\t\trte_atomic64_read(&gread_cycles) /\n-\t\t\t\trte_atomic64_read(&greads);\n+\t\t\t\t__atomic_load_n(&gread_cycles, __ATOMIC_RELAXED)\n+\t\t\t\t/ __atomic_load_n(&greads, __ATOMIC_RELAXED);\n \t\t\trwc_perf_results->w_ks_r_hit_sp[m][n]\n \t\t\t\t\t\t= cycles_per_lookup;\n \t\t\tprintf(\"Cycles per lookup: %llu\\n\", cycles_per_lookup);\n@@ -997,9 +986,6 @@ test_hash_add_ks_lookup_miss(struct rwc_perf *rwc_perf_results, int rwc_lf, int\n \tuint8_t write_type;\n \tuint8_t read_type = READ_FAIL;\n \n-\trte_atomic64_init(&greads);\n-\trte_atomic64_init(&gread_cycles);\n-\n \tif (init_params(rwc_lf, use_jhash, htm, ext_bkt) != 0)\n \t\tgoto err;\n \tprintf(\"\\nTest: Hash add - key shift, Hash lookup - miss\\n\");\n@@ -1015,8 +1001,8 @@ test_hash_add_ks_lookup_miss(struct rwc_perf *rwc_perf_results, int rwc_lf, int\n \n \t\t\tprintf(\"\\nNumber of readers: %u\\n\", rwc_core_cnt[n]);\n \n-\t\t\trte_atomic64_clear(&greads);\n-\t\t\trte_atomic64_clear(&gread_cycles);\n+\t\t\t__atomic_store_n(&greads, 0, __ATOMIC_RELAXED);\n+\t\t\t__atomic_store_n(&gread_cycles, 0, __ATOMIC_RELAXED);\n \n \t\t\trte_hash_reset(tbl_rwc_test_param.h);\n \t\t\twriter_done = 0;\n@@ -1038,8 +1024,8 @@ test_hash_add_ks_lookup_miss(struct rwc_perf *rwc_perf_results, int rwc_lf, int\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n-\t\t\t\trte_atomic64_read(&gread_cycles) /\n-\t\t\t\trte_atomic64_read(&greads);\n+\t\t\t\t__atomic_load_n(&gread_cycles, __ATOMIC_RELAXED)\n+\t\t\t\t/ __atomic_load_n(&greads, __ATOMIC_RELAXED);\n \t\t\trwc_perf_results->w_ks_r_miss[m][n] = cycles_per_lookup;\n \t\t\tprintf(\"Cycles per lookup: %llu\\n\", cycles_per_lookup);\n \t\t}\n@@ -1071,9 +1057,6 @@ test_hash_multi_add_lookup(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \tuint8_t write_type;\n \tuint8_t read_type = READ_PASS_SHIFT_PATH;\n \n-\trte_atomic64_init(&greads);\n-\trte_atomic64_init(&gread_cycles);\n-\n \tif (init_params(rwc_lf, use_jhash, htm, ext_bkt) != 0)\n \t\tgoto err;\n \tprintf(\"\\nTest: Multi-add-lookup\\n\");\n@@ -1098,8 +1081,9 @@ test_hash_multi_add_lookup(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\t\tprintf(\"\\nNumber of readers: %u\\n\",\n \t\t\t\t       rwc_core_cnt[n]);\n \n-\t\t\t\trte_atomic64_clear(&greads);\n-\t\t\t\trte_atomic64_clear(&gread_cycles);\n+\t\t\t\t__atomic_store_n(&greads, 0, __ATOMIC_RELAXED);\n+\t\t\t\t__atomic_store_n(&gread_cycles, 0,\n+\t\t\t\t\t\t __ATOMIC_RELAXED);\n \n \t\t\t\trte_hash_reset(tbl_rwc_test_param.h);\n \t\t\t\twriter_done = 0;\n@@ -1138,8 +1122,10 @@ test_hash_multi_add_lookup(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\t\t\t\tgoto err;\n \n \t\t\t\tunsigned long long cycles_per_lookup =\n-\t\t\t\t\trte_atomic64_read(&gread_cycles)\n-\t\t\t\t\t/ rte_atomic64_read(&greads);\n+\t\t\t\t\t__atomic_load_n(&gread_cycles,\n+\t\t\t\t\t\t\t__ATOMIC_RELAXED) /\n+\t\t\t\t\t__atomic_load_n(&greads,\n+\t\t\t\t\t\t\t  __ATOMIC_RELAXED);\n \t\t\t\trwc_perf_results->multi_rw[m][k][n]\n \t\t\t\t\t= cycles_per_lookup;\n \t\t\t\tprintf(\"Cycles per lookup: %llu\\n\",\n@@ -1172,9 +1158,6 @@ test_hash_add_ks_lookup_hit_extbkt(struct rwc_perf *rwc_perf_results,\n \tuint8_t write_type;\n \tuint8_t read_type = READ_PASS_KEY_SHIFTS_EXTBKT;\n \n-\trte_atomic64_init(&greads);\n-\trte_atomic64_init(&gread_cycles);\n-\n \tif (init_params(rwc_lf, use_jhash, htm, ext_bkt) != 0)\n \t\tgoto err;\n \tprintf(\"\\nTest: Hash add - key-shifts, read - hit (ext_bkt)\\n\");\n@@ -1190,8 +1173,8 @@ test_hash_add_ks_lookup_hit_extbkt(struct rwc_perf *rwc_perf_results,\n \n \t\t\tprintf(\"\\nNumber of readers: %u\\n\", rwc_core_cnt[n]);\n \n-\t\t\trte_atomic64_clear(&greads);\n-\t\t\trte_atomic64_clear(&gread_cycles);\n+\t\t\t__atomic_store_n(&greads, 0, __ATOMIC_RELAXED);\n+\t\t\t__atomic_store_n(&gread_cycles, 0, __ATOMIC_RELAXED);\n \n \t\t\trte_hash_reset(tbl_rwc_test_param.h);\n \t\t\twrite_type = WRITE_NO_KEY_SHIFT;\n@@ -1222,8 +1205,8 @@ test_hash_add_ks_lookup_hit_extbkt(struct rwc_perf *rwc_perf_results,\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n-\t\t\t\trte_atomic64_read(&gread_cycles) /\n-\t\t\t\trte_atomic64_read(&greads);\n+\t\t\t\t__atomic_load_n(&gread_cycles, __ATOMIC_RELAXED)\n+\t\t\t\t/ __atomic_load_n(&greads, __ATOMIC_RELAXED);\n \t\t\trwc_perf_results->w_ks_r_hit_extbkt[m][n]\n \t\t\t\t\t\t= cycles_per_lookup;\n \t\t\tprintf(\"Cycles per lookup: %llu\\n\", cycles_per_lookup);\n",
    "prefixes": [
        "v6",
        "3/4"
    ]
}