Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/81531/?format=api
{ "id": 81531, "url": "https://patches.dpdk.org/api/patches/81531/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1603185222-14831-26-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603185222-14831-26-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603185222-14831-26-git-send-email-arybchenko@solarflare.com", "date": "2020-10-20T09:13:05", "name": "[v2,25/62] common/sfc_efx/base: support adding VLAN POP action to a set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9fdaa901f63cccab64b4cdc19f9bd1063156ab7b", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1603185222-14831-26-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13137, "url": "https://patches.dpdk.org/api/series/13137/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13137", "date": "2020-10-20T09:12:44", "name": "net/sfc: support flow API transfer rules", "version": 2, "mbox": "https://patches.dpdk.org/series/13137/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/81531/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/81531/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82AC6A04DD;\n\tTue, 20 Oct 2020 11:27:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9ACD4D041;\n\tTue, 20 Oct 2020 11:14:51 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id C10DBC81A\n for <dev@dpdk.org>; Tue, 20 Oct 2020 11:14:11 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.61])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 907216007F for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:11 +0000 (UTC)", "from us4-mdac16-73.ut7.mdlocal (unknown [10.7.64.192])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 908628009E\n for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:11 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.66.34])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 278108005B\n for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:10 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n D1CDF600053\n for <dev@dpdk.org>; Tue, 20 Oct 2020 09:14:09 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 20 Oct 2020 10:14:00 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 20 Oct 2020 10:14:00 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09K9E0xM028412;\n Tue, 20 Oct 2020 10:14:00 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 2C3801613BE;\n Tue, 20 Oct 2020 10:14:00 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Tue, 20 Oct 2020 10:13:05 +0100", "Message-ID": "<1603185222-14831-26-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603185222-14831-1-git-send-email-arybchenko@solarflare.com>", "References": "<1603183709-23420-1-git-send-email-arybchenko@solarflare.com>\n <1603185222-14831-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-TM-AS-Result": "No-3.402300-8.000000-10", "X-TMASE-MatchedRID": "S7VGIvJZFFl1zuUvhONl81ftSkmEYHZiWNbBpQ++I1lwkdIrVt8X1VDT\n Kayi2ZF6pVG0HeSt+ryWGRCs++FM0t1RkEnBFAu+nFVnNmvv47uWODD/yzpvd7Zk7gsuflVKajy\n hX70MWYEaArPy7J2TRUQAYu+Zw/VJ0ywZEqbRuQQaPMGCcVm9DjVfUuzvrtymR2YNIFh+clFwmP\n /re/Fv5vtPFmJbG+2sXJFotwJumW5kihO6QdpZxZ4CIKY/Hg3AGdQnQSTrKGPEQdG7H66TyHEqm\n 8QYBtMO4O/iGw8qRmQJQheewnrWPK2gVRXQiAPDumqcaPkiPDv4MQw3pXdafVJ+vnzb7hsYR8ba\n 7yWJKLC33T9ZB6r8Qvv0bC9D3tKsk3UkV5Qp4wSI45Rd9ORJwFlJvEhEss3fzQahrdQz77w=", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--3.402300-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25736.003", "X-MDID": "1603185250-mKO9RNwdhZtO", "X-PPE-DISP": "1603185250;mKO9RNwdhZtO", "Subject": "[dpdk-dev] [PATCH v2 25/62] common/sfc_efx/base: support adding\n\tVLAN POP action to a set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nMAE supports stripping two tags, so this action can\nbe requested once or twice.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx.h | 5 ++\n drivers/common/sfc_efx/base/efx_impl.h | 7 +++\n drivers/common/sfc_efx/base/efx_mae.c | 54 ++++++++++++++++++-\n .../sfc_efx/rte_common_sfc_efx_version.map | 1 +\n 4 files changed, 66 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex d37850eda6..17bfc6fdfd 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -4166,6 +4166,11 @@ efx_mae_action_set_spec_fini(\n \t__in\t\t\t\tefx_nic_t *enp,\n \t__in\t\t\t\tefx_mae_actions_t *spec);\n \n+LIBEFX_API\n+extern\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_action_set_populate_vlan_pop(\n+\t__in\t\t\t\tefx_mae_actions_t *spec);\n+\n LIBEFX_API\n extern\t__checkReturn\t\t\tefx_rc_t\n efx_mae_action_set_populate_deliver(\ndiff --git a/drivers/common/sfc_efx/base/efx_impl.h b/drivers/common/sfc_efx/base/efx_impl.h\nindex 927324c85c..abd7f78cc2 100644\n--- a/drivers/common/sfc_efx/base/efx_impl.h\n+++ b/drivers/common/sfc_efx/base/efx_impl.h\n@@ -1700,16 +1700,23 @@ struct efx_mae_match_spec_s {\n };\n \n typedef enum efx_mae_action_e {\n+\t/* These actions are strictly ordered. */\n+\tEFX_MAE_ACTION_VLAN_POP,\n+\n \t/* DELIVER is always the last action. */\n \tEFX_MAE_ACTION_DELIVER,\n \n \tEFX_MAE_NACTIONS\n } efx_mae_action_t;\n \n+/* MAE VLAN_POP action can handle 1 or 2 tags. */\n+#define\tEFX_MAE_VLAN_POP_MAX_NTAGS\t(2)\n+\n typedef struct efx_mae_actions_s {\n \t/* Bitmap of actions in spec, indexed by action type */\n \tuint32_t\t\t\temass_actions;\n \n+\tunsigned int\t\t\temass_n_vlan_tags_to_pop;\n \tefx_mport_sel_t\t\t\temass_deliver_mport;\n } efx_mae_actions_t;\n \ndiff --git a/drivers/common/sfc_efx/base/efx_mae.c b/drivers/common/sfc_efx/base/efx_mae.c\nindex 1715cdc4fb..0465ddf923 100644\n--- a/drivers/common/sfc_efx/base/efx_mae.c\n+++ b/drivers/common/sfc_efx/base/efx_mae.c\n@@ -641,6 +641,42 @@ efx_mae_action_set_spec_fini(\n \tEFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec), spec);\n }\n \n+static\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_action_set_add_vlan_pop(\n+\t__in\t\t\t\tefx_mae_actions_t *spec,\n+\t__in\t\t\t\tsize_t arg_size,\n+\t__in_bcount(arg_size)\t\tconst uint8_t *arg)\n+{\n+\tefx_rc_t rc;\n+\n+\tif (arg_size != 0) {\n+\t\trc = EINVAL;\n+\t\tgoto fail1;\n+\t}\n+\n+\tif (arg != NULL) {\n+\t\trc = EINVAL;\n+\t\tgoto fail2;\n+\t}\n+\n+\tif (spec->emass_n_vlan_tags_to_pop == EFX_MAE_VLAN_POP_MAX_NTAGS) {\n+\t\trc = ENOTSUP;\n+\t\tgoto fail3;\n+\t}\n+\n+\t++spec->emass_n_vlan_tags_to_pop;\n+\n+\treturn (0);\n+\n+fail3:\n+\tEFSYS_PROBE(fail3);\n+fail2:\n+\tEFSYS_PROBE(fail2);\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\treturn (rc);\n+}\n+\n static\t__checkReturn\t\t\tefx_rc_t\n efx_mae_action_set_add_deliver(\n \t__in\t\t\t\tefx_mae_actions_t *spec,\n@@ -677,15 +713,20 @@ typedef struct efx_mae_action_desc_s {\n } efx_mae_action_desc_t;\n \n static const efx_mae_action_desc_t efx_mae_actions[EFX_MAE_NACTIONS] = {\n+\t[EFX_MAE_ACTION_VLAN_POP] = {\n+\t\t.emad_add = efx_mae_action_set_add_vlan_pop\n+\t},\n \t[EFX_MAE_ACTION_DELIVER] = {\n \t\t.emad_add = efx_mae_action_set_add_deliver\n \t}\n };\n \n static const uint32_t efx_mae_action_ordered_map =\n+\t(1U << EFX_MAE_ACTION_VLAN_POP) |\n \t(1U << EFX_MAE_ACTION_DELIVER);\n \n-static const uint32_t efx_mae_action_repeat_map = 0;\n+static const uint32_t efx_mae_action_repeat_map =\n+\t(1U << EFX_MAE_ACTION_VLAN_POP);\n \n /*\n * Add an action to an action set.\n@@ -759,6 +800,14 @@ efx_mae_action_set_spec_populate(\n \treturn (rc);\n }\n \n+\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_action_set_populate_vlan_pop(\n+\t__in\t\t\t\tefx_mae_actions_t *spec)\n+{\n+\treturn (efx_mae_action_set_spec_populate(spec,\n+\t EFX_MAE_ACTION_VLAN_POP, 0, NULL));\n+}\n+\n \t__checkReturn\t\t\tefx_rc_t\n efx_mae_action_set_populate_deliver(\n \t__in\t\t\t\tefx_mae_actions_t *spec,\n@@ -923,6 +972,9 @@ efx_mae_action_set_alloc(\n \tMCDI_IN_SET_DWORD(req,\n \t MAE_ACTION_SET_ALLOC_IN_ENCAP_HEADER_ID, EFX_MAE_RSRC_ID_INVALID);\n \n+\tMCDI_IN_SET_DWORD_FIELD(req, MAE_ACTION_SET_ALLOC_IN_FLAGS,\n+\t MAE_ACTION_SET_ALLOC_IN_VLAN_POP, spec->emass_n_vlan_tags_to_pop);\n+\n \tMCDI_IN_SET_DWORD(req,\n \t MAE_ACTION_SET_ALLOC_IN_DELIVER, spec->emass_deliver_mport.sel);\n \ndiff --git a/drivers/common/sfc_efx/rte_common_sfc_efx_version.map b/drivers/common/sfc_efx/rte_common_sfc_efx_version.map\nindex 0e0d058c8f..41c14c6451 100644\n--- a/drivers/common/sfc_efx/rte_common_sfc_efx_version.map\n+++ b/drivers/common/sfc_efx/rte_common_sfc_efx_version.map\n@@ -90,6 +90,7 @@ INTERNAL {\n \tefx_mae_action_set_alloc;\n \tefx_mae_action_set_free;\n \tefx_mae_action_set_populate_deliver;\n+\tefx_mae_action_set_populate_vlan_pop;\n \tefx_mae_action_set_spec_fini;\n \tefx_mae_action_set_spec_init;\n \tefx_mae_action_set_specs_equal;\n", "prefixes": [ "v2", "25/62" ] }