Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80916/?format=api
{ "id": 80916, "url": "https://patches.dpdk.org/api/patches/80916/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1602768646-13142-6-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602768646-13142-6-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602768646-13142-6-git-send-email-arybchenko@solarflare.com", "date": "2020-10-15T13:30:39", "name": "[v2,05/11] net/bonding: check eth dev stop status", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "12314e962adfd63e4ce94df330b9c1e593ac4ea8", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1602768646-13142-6-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 13012, "url": "https://patches.dpdk.org/api/series/13012/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=13012", "date": "2020-10-15T13:30:34", "name": "ethdev: change device stop to return status", "version": 2, "mbox": "https://patches.dpdk.org/series/13012/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/80916/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/80916/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5288BA04DB;\n\tThu, 15 Oct 2020 15:32:28 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0872E1E948;\n\tThu, 15 Oct 2020 15:31:23 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 8DB621DFE4\n for <dev@dpdk.org>; Thu, 15 Oct 2020 15:31:16 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.60])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 072EC60107; Thu, 15 Oct 2020 13:31:15 +0000 (UTC)", "from us4-mdac16-20.ut7.mdlocal (unknown [10.7.65.244])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 04ECD2009A;\n Thu, 15 Oct 2020 13:31:15 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.174])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 834BD1C005B;\n Thu, 15 Oct 2020 13:31:14 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 3AC771C009C;\n Thu, 15 Oct 2020 13:31:14 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 15 Oct 2020 14:31:11 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 15 Oct 2020 14:31:11 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09FDVASX025329;\n Thu, 15 Oct 2020 14:31:11 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id CF57C1613AB;\n Thu, 15 Oct 2020 14:31:10 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Chas Williams <chas3@att.com>, \"Min Hu (Connor)\" <humin29@huawei.com>", "CC": "<dev@dpdk.org>, Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>", "Date": "Thu, 15 Oct 2020 14:30:39 +0100", "Message-ID": "<1602768646-13142-6-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1602768646-13142-1-git-send-email-arybchenko@solarflare.com>", "References": "<1602682146-4722-1-git-send-email-arybchenko@solarflare.com>\n <1602768646-13142-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25726.003", "X-TM-AS-Result": "No-0.405100-8.000000-10", "X-TMASE-MatchedRID": "m3UrM73BECPRlxaUc/KTYX4neC0h7SAD3V4UShoTXacd0WOKRkwsh0kx\n APClfhN02tmoqiGUvaLMdHm3E7kFwCHhSBQfglfsA9lly13c/gGByxVkfd04JFIxScKXZnK0DYo\n fQuAXb7gq6gxfT+cErya6mjy4RIhP4bVbyN6yIMmeAiCmPx4NwBnUJ0Ek6yhjxEHRux+uk8ifEz\n J5hPndGZa0UaoW74jY2VRnupLfvT1e7dy+fNoTC0+6FisgFNKw9eUxDL0BCgoub7KuTEVvnxCf5\n kJJfuTTypY3Bjx0uiBCgDf5kaYsDpN1JFeUKeMEiOOUXfTkScBZSbxIRLLN37zfneGoTKOTw8g2\n HBNcF5k=", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-0.405100-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25726.003", "X-MDID": "1602768675-t111NGAWzXRp", "X-PPE-DISP": "1602768675;t111NGAWzXRp", "Subject": "[dpdk-dev] [PATCH v2 05/11] net/bonding: check eth dev stop status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nrte_eth_dev_stop() return value was changed from void to int,\nso this patch modify usage of this function across net/bonding\naccording to new return type.\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/bonding/rte_eth_bond_api.c | 7 ++++++-\n drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++++++++--\n 2 files changed, 15 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c\nindex a4007fe07c..55c8e3167c 100644\n--- a/drivers/net/bonding/rte_eth_bond_api.c\n+++ b/drivers/net/bonding/rte_eth_bond_api.c\n@@ -237,7 +237,12 @@ slave_rte_flow_prepare(uint16_t slave_id, struct bond_dev_private *internals)\n \tuint16_t slave_port_id = internals->slaves[slave_id].port_id;\n \n \tif (internals->flow_isolated_valid != 0) {\n-\t\trte_eth_dev_stop(slave_port_id);\n+\t\tif (rte_eth_dev_stop(slave_port_id) != 0) {\n+\t\t\tRTE_BOND_LOG(ERR, \"Failed to stop device on port %u\",\n+\t\t\t\t slave_port_id);\n+\t\t\treturn -1;\n+\t\t}\n+\n \t\tif (rte_flow_isolate(slave_port_id, internals->flow_isolated,\n \t\t &ferror)) {\n \t\t\tRTE_BOND_LOG(ERR, \"rte_flow_isolate failed for slave\"\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 1c404b2edd..b75646117c 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1694,7 +1694,10 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \tstruct bond_dev_private *internals = bonded_eth_dev->data->dev_private;\n \n \t/* Stop slave */\n-\trte_eth_dev_stop(slave_eth_dev->data->port_id);\n+\terrval = rte_eth_dev_stop(slave_eth_dev->data->port_id);\n+\tif (errval != 0)\n+\t\tRTE_BOND_LOG(ERR, \"rte_eth_dev_stop: port %u, err (%d)\",\n+\t\t\t slave_eth_dev->data->port_id, errval);\n \n \t/* Enable interrupts on slave device if supported */\n \tif (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)\n@@ -2110,7 +2113,11 @@ bond_ethdev_close(struct rte_eth_dev *dev)\n \twhile (internals->slave_count != skipped) {\n \t\tuint16_t port_id = internals->slaves[skipped].port_id;\n \n-\t\trte_eth_dev_stop(port_id);\n+\t\tif (rte_eth_dev_stop(port_id) != 0) {\n+\t\t\tRTE_BOND_LOG(ERR, \"Failed to stop device on port %u\",\n+\t\t\t\t port_id);\n+\t\t\tskipped++;\n+\t\t}\n \n \t\tif (rte_eth_bond_slave_remove(bond_port_id, port_id) != 0) {\n \t\t\tRTE_BOND_LOG(ERR,\n", "prefixes": [ "v2", "05/11" ] }