Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8087/?format=api
https://patches.dpdk.org/api/patches/8087/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445965946-25002-2-git-send-email-bernard.iremonger@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445965946-25002-2-git-send-email-bernard.iremonger@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1445965946-25002-2-git-send-email-bernard.iremonger@intel.com", "date": "2015-10-27T17:12:26", "name": "[dpdk-dev,v3,1/1] vmxnet3: add PCI Port Hotplug support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "74d918669d14e9008fd58a7f40409991ea7ec3fe", "submitter": { "id": 91, "url": "https://patches.dpdk.org/api/people/91/?format=api", "name": "Iremonger, Bernard", "email": "bernard.iremonger@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445965946-25002-2-git-send-email-bernard.iremonger@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8087/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8087/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3E7148DA3;\n\tTue, 27 Oct 2015 18:56:12 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id F05948DA2\n\tfor <dev@dpdk.org>; Tue, 27 Oct 2015 18:56:09 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP; 27 Oct 2015 10:56:08 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 27 Oct 2015 10:56:07 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt9RHCV8X030909; Tue, 27 Oct 2015 17:12:31 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id t9RHCVQs029097;\n\tTue, 27 Oct 2015 17:12:31 GMT", "(from bairemon@localhost)\n\tby sivswdev01.ir.intel.com with id t9RHCVPf029093;\n\tTue, 27 Oct 2015 17:12:31 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,206,1444719600\"; d=\"scan'208\";a=\"589081140\"", "From": "Bernard Iremonger <bernard.iremonger@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 27 Oct 2015 17:12:26 +0000", "Message-Id": "<1445965946-25002-2-git-send-email-bernard.iremonger@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1445965946-25002-1-git-send-email-bernard.iremonger@intel.com>", "References": "<PATCH v3>\n\t<1445965946-25002-1-git-send-email-bernard.iremonger@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 1/1] vmxnet3: add PCI Port Hotplug support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\n---\n doc/guides/rel_notes/release_2_2.rst | 2 ++\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 33 +++++++++++++++++++++++++++++----\n 2 files changed, 31 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst\nindex 455b5a2..a26c5b8 100644\n--- a/doc/guides/rel_notes/release_2_2.rst\n+++ b/doc/guides/rel_notes/release_2_2.rst\n@@ -13,6 +13,8 @@ New Features\n \n * This change required modifications to librte_ether and all vdev and pdev PMD's.\n \n+* **Added port hotplug support to the vmxnet3 PMD.**\n+\n Resolved Issues\n ---------------\n \ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 2beee3e..5cd708e 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -70,6 +70,7 @@\n #define PROCESS_SYS_EVENTS 0\n \n static int eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev);\n+static int eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev);\n static int vmxnet3_dev_configure(struct rte_eth_dev *dev);\n static int vmxnet3_dev_start(struct rte_eth_dev *dev);\n static void vmxnet3_dev_stop(struct rte_eth_dev *dev);\n@@ -296,13 +297,37 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n+static int\n+eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct vmxnet3_hw *hw = eth_dev->data->dev_private;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn 0;\n+\n+\tif (hw->adapter_stopped == 0)\n+\t\tvmxnet3_dev_close(eth_dev);\n+\n+\teth_dev->dev_ops = NULL;\n+\teth_dev->rx_pkt_burst = NULL;\n+\teth_dev->tx_pkt_burst = NULL;\n+\n+\trte_free(eth_dev->data->mac_addrs);\n+\teth_dev->data->mac_addrs = NULL;\n+\n+\treturn 0;\n+}\n+\n static struct eth_driver rte_vmxnet3_pmd = {\n \t.pci_drv = {\n \t\t.name = \"rte_vmxnet3_pmd\",\n \t\t.id_table = pci_id_vmxnet3_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,\n \t},\n \t.eth_dev_init = eth_vmxnet3_dev_init,\n+\t.eth_dev_uninit = eth_vmxnet3_dev_uninit,\n \t.dev_private_size = sizeof(struct vmxnet3_hw),\n };\n \n@@ -581,7 +606,7 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\tif (hw->adapter_stopped == TRUE) {\n+\tif (hw->adapter_stopped == 1) {\n \t\tPMD_INIT_LOG(DEBUG, \"Device already closed.\");\n \t\treturn;\n \t}\n@@ -597,7 +622,7 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)\n \t/* reset the device */\n \tVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_RESET_DEV);\n \tPMD_INIT_LOG(DEBUG, \"Device reset.\");\n-\thw->adapter_stopped = FALSE;\n+\thw->adapter_stopped = 0;\n \n \tvmxnet3_dev_clear_queues(dev);\n \n@@ -617,7 +642,7 @@ vmxnet3_dev_close(struct rte_eth_dev *dev)\n \tPMD_INIT_FUNC_TRACE();\n \n \tvmxnet3_dev_stop(dev);\n-\thw->adapter_stopped = TRUE;\n+\thw->adapter_stopped = 1;\n }\n \n static void\n", "prefixes": [ "dpdk-dev", "v3", "1/1" ] }{ "id": 8087, "url": "