Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8081/?format=api
{ "id": 8081, "url": "https://patches.dpdk.org/api/patches/8081/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445957897-26909-6-git-send-email-yong.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445957897-26909-6-git-send-email-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1445957897-26909-6-git-send-email-yong.liu@intel.com", "date": "2015-10-27T14:58:15", "name": "[dpdk-dev,v2,5/7] e1000: check lsc and rxq not enable in the same time", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5d6103de31cc0a147139b7f0d9d930bcef0796ee", "submitter": { "id": 17, "url": "https://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445957897-26909-6-git-send-email-yong.liu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8081/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8081/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 48FF48DED;\n\tTue, 27 Oct 2015 15:58:40 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 750978DAC\n\tfor <dev@dpdk.org>; Tue, 27 Oct 2015 15:58:36 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 27 Oct 2015 07:58:35 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 27 Oct 2015 07:58:36 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9REwXGk020159;\n\tTue, 27 Oct 2015 22:58:33 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9REwTcc026980; Tue, 27 Oct 2015 22:58:32 +0800", "(from yliu84x@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9REwTiD026976; \n\tTue, 27 Oct 2015 22:58:29 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,205,1444719600\"; d=\"scan'208\";a=\"836185246\"", "From": "Yong Liu <yong.liu@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 27 Oct 2015 22:58:15 +0800", "Message-Id": "<1445957897-26909-6-git-send-email-yong.liu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1445957897-26909-1-git-send-email-yong.liu@intel.com>", "References": "<1445957897-26909-1-git-send-email-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 5/7] e1000: check lsc and rxq not enable in\n\tthe same time", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "e1000 only support one type of interrupt cause, so remove lsc interrupt\nhandler if rxq enabled.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex fc3cc1e..b1e0c3c 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -630,14 +630,22 @@ eth_em_start(struct rte_eth_dev *dev)\n \t}\n \te1000_setup_link(hw);\n \n-\t/* check if lsc interrupt feature is enabled */\n-\tif (dev->data->dev_conf.intr_conf.lsc != 0) {\n-\t\tret = eth_em_interrupt_setup(dev);\n-\t\tif (ret) {\n-\t\t\tPMD_INIT_LOG(ERR, \"Unable to setup interrupts\");\n-\t\t\tem_dev_clear_queues(dev);\n-\t\t\treturn ret;\n-\t\t}\n+\tif (rte_intr_allow_others(intr_handle)) {\n+\t\t/* check if lsc interrupt is enabled */\n+\t\tif (dev->data->dev_conf.intr_conf.lsc != 0)\n+\t\t\tret = eth_em_interrupt_setup(dev);\n+\t\t\tif (ret) {\n+\t\t\t\tPMD_INIT_LOG(ERR, \"Unable to setup interrupts\");\n+\t\t\t\tem_dev_clear_queues(dev);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t} else {\n+\t\trte_intr_callback_unregister(intr_handle,\n+\t\t\t\t\t\teth_em_interrupt_handler,\n+\t\t\t\t\t\t(void *)dev);\n+\t\tif (dev->data->dev_conf.intr_conf.lsc != 0)\n+\t\t\tPMD_INIT_LOG(INFO, \"lsc won't enable because of\"\n+\t\t\t\t \" no intr multiplex\\n\");\n \t}\n \t/* check if rxq interrupt is enabled */\n \tif (dev->data->dev_conf.intr_conf.rxq != 0)\n@@ -688,6 +696,12 @@ eth_em_stop(struct rte_eth_dev *dev)\n \tmemset(&link, 0, sizeof(link));\n \trte_em_dev_atomic_write_link_status(dev, &link);\n \n+\tif (!rte_intr_allow_others(intr_handle))\n+\t\t/* resume to the default handler */\n+\t\trte_intr_callback_register(intr_handle,\n+\t\t\t\t\t eth_em_interrupt_handler,\n+\t\t\t\t\t (void *)dev);\n+\n \t/* Clean datapath event and queue/vec mapping */\n \trte_intr_efd_disable(intr_handle);\n \tif (intr_handle->intr_vec != NULL) {\n", "prefixes": [ "dpdk-dev", "v2", "5/7" ] }