Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 8080,
    "url": "https://patches.dpdk.org/api/patches/8080/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445957897-26909-3-git-send-email-yong.liu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1445957897-26909-3-git-send-email-yong.liu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1445957897-26909-3-git-send-email-yong.liu@intel.com",
    "date": "2015-10-27T14:58:12",
    "name": "[dpdk-dev,v2,2/7] e1000: separate lsc and rxq interrupt disable function",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7dd7a1d0a9d77535956b197c46ce73f18455308f",
    "submitter": {
        "id": 17,
        "url": "https://patches.dpdk.org/api/people/17/?format=api",
        "name": "Marvin Liu",
        "email": "yong.liu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445957897-26909-3-git-send-email-yong.liu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/8080/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/8080/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5DF3A8DAE;\n\tTue, 27 Oct 2015 15:58:39 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 1F4428DA4\n\tfor <dev@dpdk.org>; Tue, 27 Oct 2015 15:58:34 +0100 (CET)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP; 27 Oct 2015 07:58:28 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 27 Oct 2015 07:58:27 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9REwQHQ020150;\n\tTue, 27 Oct 2015 22:58:26 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9REwNRB026959; Tue, 27 Oct 2015 22:58:25 +0800",
            "(from yliu84x@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9REwNj0026955; \n\tTue, 27 Oct 2015 22:58:23 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.20,205,1444719600\"; d=\"scan'208\";a=\"588962051\"",
        "From": "Yong Liu <yong.liu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 27 Oct 2015 22:58:12 +0800",
        "Message-Id": "<1445957897-26909-3-git-send-email-yong.liu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1445957897-26909-1-git-send-email-yong.liu@intel.com>",
        "References": "<1445957897-26909-1-git-send-email-yong.liu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 2/7] e1000: separate lsc and rxq interrupt\n\tdisable function",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Separate lsc and rxq interrupt for they have different interrupt handlers.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>",
    "diff": "diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex 3be8269..39f330a 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -108,11 +108,12 @@ static void em_vlan_hw_strip_disable(struct rte_eth_dev *dev);\n static void eth_em_vlan_filter_set(struct rte_eth_dev *dev,\n \t\t\t\t\tuint16_t vlan_id, int on);\n */\n+static void em_lsc_intr_disable(struct e1000_hw *hw);\n static void em_rxq_intr_enable(struct e1000_hw *hw);\n+static void em_rxq_intr_disable(struct e1000_hw *hw);\n static int eth_em_led_on(struct rte_eth_dev *dev);\n static int eth_em_led_off(struct rte_eth_dev *dev);\n \n-static void em_intr_disable(struct e1000_hw *hw);\n static int em_get_rx_buffer_size(struct e1000_hw *hw);\n static void eth_em_rar_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr,\n \t\tuint32_t index, uint32_t pool);\n@@ -640,7 +641,9 @@ eth_em_stop(struct rte_eth_dev *dev)\n \tstruct rte_eth_link link;\n \tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\tem_intr_disable(hw);\n+\tem_rxq_intr_disable(hw);\n+\tem_lsc_intr_disable(hw);\n+\n \te1000_reset_hw(hw);\n \tif (hw->mac.type >= e1000_82544)\n \t\tE1000_WRITE_REG(hw, E1000_WUC, 0);\n@@ -1254,13 +1257,7 @@ eth_em_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \t}\n }\n \n-static void\n-em_intr_disable(struct e1000_hw *hw)\n-{\n-\tE1000_WRITE_REG(hw, E1000_IMC, ~0);\n-}\n-\n-/**\n+/*\n  * It enables the interrupt mask and then enable the interrupt.\n  *\n  * @param dev\n@@ -1304,6 +1301,35 @@ eth_em_rxq_interrupt_setup(struct rte_eth_dev *dev)\n }\n \n /*\n+ * It disabled lsc interrupt.\n+ * @param hw\n+ * Pointer to struct e1000_hw\n+ *\n+ * @return\n+ */\n+static void\n+em_lsc_intr_disable(struct e1000_hw *hw)\n+{\n+\tE1000_WRITE_REG(hw, E1000_IMC, E1000_IMS_LSC);\n+\tE1000_WRITE_FLUSH(hw);\n+}\n+\n+/*\n+ * It disabled receive packet interrupt.\n+ * @param hw\n+ * Pointer to struct e1000_hw\n+ *\n+ * @return\n+ */\n+static void\n+em_rxq_intr_disable(struct e1000_hw *hw)\n+{\n+\tE1000_READ_REG(hw, E1000_ICR);\n+\tE1000_WRITE_REG(hw, E1000_IMC, E1000_IMS_RXT0);\n+\tE1000_WRITE_FLUSH(hw);\n+}\n+\n+/*\n  * It enable receive packet interrupt.\n  * @param hw\n  * Pointer to struct e1000_hw\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "2/7"
    ]
}