Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8066/?format=api
{ "id": 8066, "url": "https://patches.dpdk.org/api/patches/8066/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445946068-28183-1-git-send-email-kevin.traynor@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445946068-28183-1-git-send-email-kevin.traynor@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1445946068-28183-1-git-send-email-kevin.traynor@intel.com", "date": "2015-10-27T11:41:08", "name": "[dpdk-dev] ixgbe: change logging for ixgbe tx code path selection", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "604592758c704ff114248d8b08f4ea74039fb5bb", "submitter": { "id": 195, "url": "https://patches.dpdk.org/api/people/195/?format=api", "name": "Traynor, Kevin", "email": "kevin.traynor@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445946068-28183-1-git-send-email-kevin.traynor@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8066/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8066/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BE5025682;\n\tTue, 27 Oct 2015 12:41:12 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 3A9B5374E\n\tfor <dev@dpdk.org>; Tue, 27 Oct 2015 12:41:11 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 27 Oct 2015 04:41:10 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 27 Oct 2015 04:41:10 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt9RBf8GM030961 for <dev@dpdk.org>; Tue, 27 Oct 2015 11:41:09 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id t9RBf8KP028221\n\tfor <dev@dpdk.org>; Tue, 27 Oct 2015 11:41:08 GMT", "(from ktraynor@localhost)\n\tby sivswdev01.ir.intel.com with id t9RBf8L6028216\n\tfor dev@dpdk.org; Tue, 27 Oct 2015 11:41:08 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,204,1444719600\"; d=\"scan'208\";a=\"672629774\"", "From": "Kevin Traynor <kevin.traynor@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 27 Oct 2015 11:41:08 +0000", "Message-Id": "<1445946068-28183-1-git-send-email-kevin.traynor@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] ixgbe: change logging for ixgbe tx code path\n\tselection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Simple and vector are different tx code paths. If vector\nis selected, change logging from:\nPMD: ixgbe_set_tx_function(): Using simple tx code path\nPMD: ixgbe_set_tx_function(): Vector tx enabled.\n\nto:\nPMD: ixgbe_set_tx_function(): Using vector tx code path\n\nor, if simple selected:\nPMD: ixgbe_set_tx_function(): Using simple tx code path\n\nThe dangling else in the #ifdef makes readability difficult,\nso resolving in way that seems most readable.\n\nSigned-off-by: Kevin Traynor <kevin.traynor@intel.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx.c | 8 +++++---\n 1 files changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex a598a72..11d7feb 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -1963,16 +1963,18 @@ ixgbe_set_tx_function(struct rte_eth_dev *dev, struct ixgbe_tx_queue *txq)\n \t/* Use a simple Tx queue (no offloads, no multi segs) if possible */\n \tif (((txq->txq_flags & IXGBE_SIMPLE_FLAGS) == IXGBE_SIMPLE_FLAGS)\n \t\t\t&& (txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST)) {\n-\t\tPMD_INIT_LOG(DEBUG, \"Using simple tx code path\");\n #ifdef RTE_IXGBE_INC_VECTOR\n \t\tif (txq->tx_rs_thresh <= RTE_IXGBE_TX_MAX_FREE_BUF_SZ &&\n \t\t\t\t(rte_eal_process_type() != RTE_PROC_PRIMARY ||\n \t\t\t\t\tixgbe_txq_vec_setup(txq) == 0)) {\n-\t\t\tPMD_INIT_LOG(DEBUG, \"Vector tx enabled.\");\n+\t\t\tPMD_INIT_LOG(DEBUG, \"Using vector tx code path\");\n \t\t\tdev->tx_pkt_burst = ixgbe_xmit_pkts_vec;\n \t\t} else\n #endif\n-\t\tdev->tx_pkt_burst = ixgbe_xmit_pkts_simple;\n+\t\t{\n+\t\t\tPMD_INIT_LOG(DEBUG, \"Using simple tx code path\");\n+\t\t\tdev->tx_pkt_burst = ixgbe_xmit_pkts_simple;\n+\t\t}\n \t} else {\n \t\tPMD_INIT_LOG(DEBUG, \"Using full-featured tx code path\");\n \t\tPMD_INIT_LOG(DEBUG,\n", "prefixes": [ "dpdk-dev" ] }