Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80391/?format=api
{ "id": 80391, "url": "https://patches.dpdk.org/api/patches/80391/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201012164602.1965694-2-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201012164602.1965694-2-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201012164602.1965694-2-ferruh.yigit@intel.com", "date": "2020-10-12T16:46:01", "name": "[RFC,2/2] doc: announce queue stats moving to xstats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ed7ad53ec9eff066542720a73c93bf0063f0d4e5", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201012164602.1965694-2-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 12889, "url": "https://patches.dpdk.org/api/series/12889/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12889", "date": "2020-10-12T16:46:00", "name": "[RFC,1/2] ethdev: move queue stats to xstats", "version": 1, "mbox": "https://patches.dpdk.org/series/12889/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/80391/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/80391/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 70DCFA04B6;\n\tMon, 12 Oct 2020 18:46:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9E2181D954;\n\tMon, 12 Oct 2020 18:46:15 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id 074B31D942;\n Mon, 12 Oct 2020 18:46:12 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Oct 2020 09:46:09 -0700", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.180])\n by orsmga006.jf.intel.com with ESMTP; 12 Oct 2020 09:46:07 -0700" ], "IronPort-SDR": [ "\n e7S4hFMrVZ7xDCtw6rRuLYrMwus2YnrG0tOBuJSTS8RPtGGVERx6ouC8lhO5sOb9aCXMg2Uv8f\n 41cM+ZzyVrng==", "\n aUuy1RFHjGwGTykEPp04NdVP7Y/HIg+Yb9CcAYFHQIazrhPLqBRv7/APhtYUZa5iRF31c2XM1Q\n 8v40F+icx8hQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9772\"; a=\"145633417\"", "E=Sophos;i=\"5.77,367,1596524400\"; d=\"scan'208\";a=\"145633417\"", "E=Sophos;i=\"5.77,367,1596524400\"; d=\"scan'208\";a=\"317980285\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Cc": "dev@dpdk.org,\n\ttechboard@dpdk.org,\n\tMin Hu <humin29@huawei.com>", "Date": "Mon, 12 Oct 2020 17:46:01 +0100", "Message-Id": "<20201012164602.1965694-2-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20201012164602.1965694-1-ferruh.yigit@intel.com>", "References": "<20201012164602.1965694-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC 2/2] doc: announce queue stats moving to xstats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Queue stats will be removed from basic stats to xstats.\n\nIt will be PMDs responsibility to fill queue stats based on number of\nqueues they have.\n\nUntil all PMDs implement the xstats, a temporary\n'RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' device flag created. PMDs switched\nto the xstats should set this flag to bypass ethdev layer for queue\nstats.\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n config/rte_config.h | 2 +-\n doc/guides/rel_notes/deprecation.rst | 7 +++++++\n lib/librte_ethdev/rte_ethdev.h | 3 +++\n 3 files changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/config/rte_config.h b/config/rte_config.h\nindex 03d90d78bc..9ef3b75940 100644\n--- a/config/rte_config.h\n+++ b/config/rte_config.h\n@@ -55,7 +55,7 @@\n \n /* ether defines */\n #define RTE_MAX_QUEUES_PER_PORT 1024\n-#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16\n+#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 /* max 256 */\n #define RTE_ETHDEV_RXTX_CALLBACKS 1\n \n /* cryptodev defines */\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 584e720879..9143cfc529 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -164,6 +164,13 @@ Deprecation Notices\n following the IPv6 header, as proposed in RFC\n https://mails.dpdk.org/archives/dev/2020-August/177257.html.\n \n+* ethdev: Queue specific stats fields will be removed from ``struct rte_eth_stats``.\n+ Mentioned fields are: ``q_ipackets``, ``q_opackets``, ``q_ibytes``, ``q_obytes``,\n+ ``q_errors``.\n+ Instead queue stats will be received via xstats API. Current method support\n+ will be limited to maximum 256 queues.\n+ Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed.\n+\n * security: The API ``rte_security_session_create`` takes only single mempool\n for session and session private data. So the application need to create\n mempool for twice the number of sessions needed and will also lead to\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex 42c83303e1..160481c747 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -253,6 +253,7 @@ struct rte_eth_stats {\n \tuint64_t ierrors; /**< Total number of erroneous received packets. */\n \tuint64_t oerrors; /**< Total number of failed transmitted packets. */\n \tuint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */\n+\t/* Queue stats are limited to max 256 queues */\n \tuint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];\n \t/**< Total number of queue RX packets. */\n \tuint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];\n@@ -2701,6 +2702,7 @@ int rte_eth_xstats_reset(uint16_t port_id);\n * The per-queue packet statistics functionality number that the transmit\n * queue is to be assigned.\n * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1].\n+ * Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256.\n * @return\n * Zero if successful. Non-zero otherwise.\n */\n@@ -2721,6 +2723,7 @@ int rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id,\n * The per-queue packet statistics functionality number that the receive\n * queue is to be assigned.\n * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1].\n+ * Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256.\n * @return\n * Zero if successful. Non-zero otherwise.\n */\n", "prefixes": [ "RFC", "2/2" ] }