Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 8035,
    "url": "https://patches.dpdk.org/api/patches/8035/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445913268-26457-1-git-send-email-shemming@brocade.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1445913268-26457-1-git-send-email-shemming@brocade.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1445913268-26457-1-git-send-email-shemming@brocade.com",
    "date": "2015-10-27T02:34:28",
    "name": "[dpdk-dev] vfio: support iommu group zero",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "0845558ae8eb77bc244a51a408639b42a576f858",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445913268-26457-1-git-send-email-shemming@brocade.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/8035/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/8035/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 14E818D8B;\n\tTue, 27 Oct 2015 03:34:51 +0100 (CET)",
            "from mail-pa0-f53.google.com (mail-pa0-f53.google.com\n\t[209.85.220.53]) by dpdk.org (Postfix) with ESMTP id CB9258D8A\n\tfor <dev@dpdk.org>; Tue, 27 Oct 2015 03:34:49 +0100 (CET)",
            "by pabla5 with SMTP id la5so13291567pab.0\n\tfor <dev@dpdk.org>; Mon, 26 Oct 2015 19:34:49 -0700 (PDT)",
            "from localhost.localdomain ([58.123.138.250])\n\tby smtp.gmail.com with ESMTPSA id\n\tc4sm36579762pat.46.2015.10.26.19.34.47\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 26 Oct 2015 19:34:48 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber_org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=yuuwzTFiyOyayR+2tMA3K8CXu6P9yMfAd+KX4vUXaqw=;\n\tb=Hb+HT0bAPoEee31RXAzTPY+zM33p33jb7uakpRpbXJvt8XxkRkmh9d/k2m+ZN82xLk\n\tMUqf9w2NaEleQB74XZt/oS7M28yLL9oP2Tt4c2mbEkaT+1tNZLmWk6v4kBThNg3CPVqt\n\tx1NImbzd2YAQL+JaZuglVNXXetKHqHGCtK2k3DAU0JqIvLLHKBwlXz2Ge0dWsG6Xch6o\n\tpGYtGYzXlhpvPKmjFdgkgeqAHlFOzMaYP44MVeAUTHdMxkZ6J1L+eew5zXyVPuw3xZRM\n\tnjScB/plTJaULB6EUiaF1hXe3KMuxEZ9ku0gDpT4rm+ya9LBWzTN/pAoPJNycstlyKnK\n\thpWg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=yuuwzTFiyOyayR+2tMA3K8CXu6P9yMfAd+KX4vUXaqw=;\n\tb=b5JlAvNCevZVa4fvd3dXrw594vc9kJJ6mYQEYnNopOonup0uylYUt9feteqfzMFKSD\n\t2Y4AwWthsHkizCqC/4NE4wk3ShpZ4JMwBj+T5n/2PrNGZk77OiJlU2jwmJE3//pP5RGP\n\tHwqj8AtqjZANVj/nj8peQioz3p8dwNcdqaFTA7BHVJ6Je80rrCzFfs87TtphHSO6Ub9F\n\tJ90/TzCgtXEr/aZz3uWqzXPTE+Mt34sc1dxtWh3+ettYdh1d0jhFm9S/oY9h6Chg5a0Y\n\t0jcW3fNNI2aKAzl1V6lybtRS6IpXxs0lyCvpftMCCPkKWPuhZpzkZqEmhJVYbTVoN/8X\n\t2c7Q==",
        "X-Gm-Message-State": "ALoCoQlkhOio8G94REjz3yk0mWePzkUXs+xj1ywXE6F8d8VDSFXX9M8vcuR4R/1e8FomQ2wYqSE9",
        "X-Received": "by 10.68.103.161 with SMTP id fx1mr25465792pbb.42.1445913289142; \n\tMon, 26 Oct 2015 19:34:49 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "X-Google-Original-From": "Stephen Hemminger <shemming@brocade.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 27 Oct 2015 11:34:28 +0900",
        "Message-Id": "<1445913268-26457-1-git-send-email-shemming@brocade.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "Cc": "alex.williamson@redhat.com",
        "Subject": "[dpdk-dev] [PATCH] vfio: support iommu group zero",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nThe implementation of VFIO is broken on some platforms and if using\nthe proposed VFIO without IOMMU patch.  IOMMU group zero is a valid value.\n\nChange code to split the return value from the group value.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c\nindex 0e6c48a..74f91ba 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c\n@@ -499,14 +499,15 @@ pci_vfio_get_group_fd(int iommu_group_no)\n }\n \n /* parse IOMMU group number for a PCI device\n- * returns -1 for errors, 0 for non-existent group */\n+ * returns 1 on success, -1 for errors, 0 for non-existent group\n+ */\n static int\n-pci_vfio_get_group_no(const char *pci_addr)\n+pci_vfio_get_group_no(const char *pci_addr, int *iommu_group_no)\n {\n \tchar linkname[PATH_MAX];\n \tchar filename[PATH_MAX];\n \tchar *tok[16], *group_tok, *end;\n-\tint ret, iommu_group_no;\n+\tint ret;\n \n \tmemset(linkname, 0, sizeof(linkname));\n \tmemset(filename, 0, sizeof(filename));\n@@ -533,13 +534,13 @@ pci_vfio_get_group_no(const char *pci_addr)\n \terrno = 0;\n \tgroup_tok = tok[ret - 1];\n \tend = group_tok;\n-\tiommu_group_no = strtol(group_tok, &end, 10);\n+\t*iommu_group_no = strtol(group_tok, &end, 10);\n \tif ((end != group_tok && *end != '\\0') || errno != 0) {\n \t\tRTE_LOG(ERR, EAL, \"  %s error parsing IOMMU number!\\n\", pci_addr);\n \t\treturn -1;\n \t}\n \n-\treturn iommu_group_no;\n+\treturn 1;\n }\n \n static void\n@@ -581,16 +582,15 @@ pci_vfio_map_resource(struct rte_pci_device *dev)\n \t\t\tloc->domain, loc->bus, loc->devid, loc->function);\n \n \t/* get group number */\n-\tiommu_group_no = pci_vfio_get_group_no(pci_addr);\n-\n-\t/* if 0, group doesn't exist */\n-\tif (iommu_group_no == 0) {\n+\tret = pci_vfio_get_group_no(pci_addr, &iommu_group_no);\n+\tif (ret == 0) {\n \t\tRTE_LOG(WARNING, EAL, \"  %s not managed by VFIO driver, skipping\\n\",\n-\t\t\t\tpci_addr);\n+\t\t\tpci_addr);\n \t\treturn 1;\n \t}\n+\n \t/* if negative, something failed */\n-\telse if (iommu_group_no < 0)\n+\tif (ret < 0)\n \t\treturn -1;\n \n \t/* get the actual group fd */\n",
    "prefixes": [
        "dpdk-dev"
    ]
}