Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80167/?format=api
{ "id": 80167, "url": "https://patches.dpdk.org/api/patches/80167/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201009131331.5897-2-nipun.gupta@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201009131331.5897-2-nipun.gupta@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201009131331.5897-2-nipun.gupta@nxp.com", "date": "2020-10-09T13:13:30", "name": "[2/3,v3] net/dpaa: support RX offload for error packet drop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c7ef32f7f3a630031519438259497a0845a42795", "submitter": { "id": 471, "url": "https://patches.dpdk.org/api/people/471/?format=api", "name": "Nipun Gupta", "email": "nipun.gupta@nxp.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201009131331.5897-2-nipun.gupta@nxp.com/mbox/", "series": [ { "id": 12826, "url": "https://patches.dpdk.org/api/series/12826/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12826", "date": "2020-10-09T13:13:29", "name": "[1/3,v3] ethdev: add rx offload to drop error packets", "version": 3, "mbox": "https://patches.dpdk.org/series/12826/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/80167/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/80167/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E24FFA04BC;\n\tFri, 9 Oct 2020 15:14:03 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7CAE31D5F1;\n\tFri, 9 Oct 2020 15:13:49 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 15F8E1D5E6\n for <dev@dpdk.org>; Fri, 9 Oct 2020 15:13:47 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id EC8B620107A;\n Fri, 9 Oct 2020 15:13:46 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 546AB201064;\n Fri, 9 Oct 2020 15:13:42 +0200 (CEST)", "from lsv03273.swis.in-blr01.nxp.com (lsv03273.swis.in-blr01.nxp.com\n [92.120.147.113])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id E9E81402CA;\n Fri, 9 Oct 2020 15:13:36 +0200 (CEST)" ], "From": "nipun.gupta@nxp.com", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com,\n hemant.agrawal@nxp.com, sachin.saxena@nxp.com, rohit.raj@nxp.com,\n jerinjacobk@gmail.com, stephen@networkplumber.org, asafp@nvidia.com,\n Nipun Gupta <nipun.gupta@nxp.com>", "Date": "Fri, 9 Oct 2020 18:43:30 +0530", "Message-Id": "<20201009131331.5897-2-nipun.gupta@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201009131331.5897-1-nipun.gupta@nxp.com>", "References": "<20200831075333.10135-1-nipun.gupta@nxp.com>\n <20201009131331.5897-1-nipun.gupta@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 2/3 v3] net/dpaa: support RX offload for error\n\tpacket drop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nThis patch supports RX offload configuration to drop error\npackets in the hardware\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/bus/dpaa/base/fman/fman_hw.c | 7 ++++++-\n drivers/net/dpaa/dpaa_ethdev.c | 23 +++++++++++++++++++----\n 2 files changed, 25 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c\nindex 4ab49f785..40e4e0000 100644\n--- a/drivers/bus/dpaa/base/fman/fman_hw.c\n+++ b/drivers/bus/dpaa/base/fman/fman_hw.c\n@@ -597,7 +597,12 @@ void\n fman_if_discard_rx_errors(struct fman_if *fm_if)\n {\n \tstruct __fman_if *__if = container_of(fm_if, struct __fman_if, __if);\n-\tunsigned int *fmbm_rfsdm, *fmbm_rfsem;\n+\tunsigned int *fmbm_rcfg, *fmbm_rfsdm, *fmbm_rfsem;\n+\tunsigned int val;\n+\n+\tfmbm_rcfg = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rcfg;\n+\tval = in_be32(fmbm_rcfg);\n+\tout_be32(fmbm_rcfg, val & ~BMI_PORT_CFG_FDOVR);\n \n \tfmbm_rfsem = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rfsem;\n \tout_be32(fmbm_rfsem, 0);\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex af47c196a..bed84a584 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -52,7 +52,8 @@\n /* Supported Rx offloads */\n static uint64_t dev_rx_offloads_sup =\n \t\tDEV_RX_OFFLOAD_JUMBO_FRAME |\n-\t\tDEV_RX_OFFLOAD_SCATTER;\n+\t\tDEV_RX_OFFLOAD_SCATTER |\n+\t\tDEV_RX_OFFLOAD_ERR_PKT_DROP;\n \n /* Rx offloads which cannot be disabled */\n static uint64_t dev_rx_offloads_nodis =\n@@ -62,6 +63,10 @@ static uint64_t dev_rx_offloads_nodis =\n \t\tDEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |\n \t\tDEV_RX_OFFLOAD_RSS_HASH;\n \n+/* Supported Rx Error packet drop offload */\n+static uint64_t dev_rx_err_drop_offloads_sup =\n+\t\tDEV_RX_ERR_PKT_DROP_OFFLOAD_ALL;\n+\n /* Supported Tx offloads */\n static uint64_t dev_tx_offloads_sup =\n \t\tDEV_TX_OFFLOAD_MT_LOCKFREE |\n@@ -262,6 +267,18 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)\n \t\tdev->data->scattered_rx = 1;\n \t}\n \n+\tif (eth_conf->err_pkt_drop_conf.all) {\n+\t\tDPAA_PMD_DEBUG(\"error packets will be dropped on hw\");\n+\t\tfman_if_discard_rx_errors(fif);\n+\t} else {\n+\t\tstruct dpaa_if *dpaa_intf = dev->data->dev_private;\n+\t\tstruct qman_fq *rxq = &dpaa_intf->rx_queues[0];\n+\n+\t\tDPAA_PMD_DEBUG(\"error packets will not be dropped on hw\");\n+\t\tfman_if_receive_rx_errors(fif, FM_FD_RX_STATUS_ERR_MASK);\n+\t\tfman_if_set_err_fqid(fif, rxq->fqid);\n+\t}\n+\n \tif (!(default_q || fmc_q)) {\n \t\tif (dpaa_fm_config(dev,\n \t\t\teth_conf->rx_adv_conf.rss_conf.rss_hf)) {\n@@ -591,6 +608,7 @@ static int dpaa_eth_dev_info(struct rte_eth_dev *dev,\n \t\t\t\t\tdev_rx_offloads_nodis;\n \tdev_info->tx_offload_capa = dev_tx_offloads_sup |\n \t\t\t\t\tdev_tx_offloads_nodis;\n+\tdev_info->rx_err_drop_offload_capa = dev_rx_err_drop_offloads_sup;\n \tdev_info->default_rxportconf.burst_size = DPAA_DEF_RX_BURST_SIZE;\n \tdev_info->default_txportconf.burst_size = DPAA_DEF_TX_BURST_SIZE;\n \tdev_info->default_rxportconf.nb_queues = 1;\n@@ -2085,9 +2103,6 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)\n \t\tfman_intf->mac_addr.addr_bytes[5]);\n \n \tif (!fman_intf->is_shared_mac) {\n-\t\t/* Configure error packet handling */\n-\t\tfman_if_receive_rx_errors(fman_intf,\n-\t\t\tFM_FD_RX_STATUS_ERR_MASK);\n \t\t/* Disable RX mode */\n \t\tfman_if_disable_rx(fman_intf);\n \t\t/* Disable promiscuous mode */\n", "prefixes": [ "2/3", "v3" ] }