Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/80166/?format=api
{ "id": 80166, "url": "https://patches.dpdk.org/api/patches/80166/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201009131331.5897-1-nipun.gupta@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201009131331.5897-1-nipun.gupta@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201009131331.5897-1-nipun.gupta@nxp.com", "date": "2020-10-09T13:13:29", "name": "[1/3,v3] ethdev: add rx offload to drop error packets", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5a25eafe93b820d569865fbcacffd429708666d9", "submitter": { "id": 471, "url": "https://patches.dpdk.org/api/people/471/?format=api", "name": "Nipun Gupta", "email": "nipun.gupta@nxp.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201009131331.5897-1-nipun.gupta@nxp.com/mbox/", "series": [ { "id": 12826, "url": "https://patches.dpdk.org/api/series/12826/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12826", "date": "2020-10-09T13:13:29", "name": "[1/3,v3] ethdev: add rx offload to drop error packets", "version": 3, "mbox": "https://patches.dpdk.org/series/12826/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/80166/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/80166/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 294B7A04BC;\n\tFri, 9 Oct 2020 15:13:48 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 080171D5A2;\n\tFri, 9 Oct 2020 15:13:47 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id C32811C1D0\n for <dev@dpdk.org>; Fri, 9 Oct 2020 15:13:44 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 958AA20039E;\n Fri, 9 Oct 2020 15:13:44 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id F312620039C;\n Fri, 9 Oct 2020 15:13:39 +0200 (CEST)", "from lsv03273.swis.in-blr01.nxp.com (lsv03273.swis.in-blr01.nxp.com\n [92.120.147.113])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 95D55402B0;\n Fri, 9 Oct 2020 15:13:34 +0200 (CEST)" ], "From": "nipun.gupta@nxp.com", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com,\n hemant.agrawal@nxp.com, sachin.saxena@nxp.com, rohit.raj@nxp.com,\n jerinjacobk@gmail.com, stephen@networkplumber.org, asafp@nvidia.com,\n Nipun Gupta <nipun.gupta@nxp.com>", "Date": "Fri, 9 Oct 2020 18:43:29 +0530", "Message-Id": "<20201009131331.5897-1-nipun.gupta@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200831075333.10135-1-nipun.gupta@nxp.com>", "References": "<20200831075333.10135-1-nipun.gupta@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error\n\tpackets", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nThis change adds a RX offload capability and configuration to\nenable hardware to drop the packets in case of any error in the\npackets such as L3 checksum error or L4 checksum.\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\nSigned-off-by: Rohit Raj <rohit.raj@nxp.com>\nReviewed-by: Asaf Penso <asafp@nvidia.com>\n---\n\nv3:\n - Add additional rx_err_drop_offload_capa, which is specific\n capability flag for RX packets error drop offload. Currently\n only 'all' error packet drops are enabled, but can be extended\n to provide capability to drop any specific errors like L1 FCS,\n L3 Checksum etc.\n - Added separate config structure to enable the drop configuration.\n - Updated doc with the new updated option in testbbdev (patch 3/3)\n\nv2:\n - Add support in DPAA1 driver (patch 2/3)\n - Add support and config parameter in testpmd (patch 3/3)\n\n lib/librte_ethdev/rte_ethdev.c | 1 +\n lib/librte_ethdev/rte_ethdev.h | 22 ++++++++++++++++++++++\n 2 files changed, 23 insertions(+)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 48d1333b1..be25e947e 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -128,6 +128,7 @@ static const struct {\n \tRTE_RX_OFFLOAD_BIT2STR(SCTP_CKSUM),\n \tRTE_RX_OFFLOAD_BIT2STR(OUTER_UDP_CKSUM),\n \tRTE_RX_OFFLOAD_BIT2STR(RSS_HASH),\n+\tRTE_RX_OFFLOAD_BIT2STR(ERR_PKT_DROP),\n };\n \n #undef RTE_RX_OFFLOAD_BIT2STR\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex d2bf74f12..cb968d38a 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -1194,6 +1194,16 @@ struct rte_intr_conf {\n \tuint32_t rmv:1;\n };\n \n+/**\n+ * A structure used to enable/disable error packet drop on RX.\n+ */\n+struct rte_rx_err_pkt_drop_conf {\n+\t/** enable/disable all RX error packet drop.\n+\t * 0 (default) - disable, 1 enable\n+\t */\n+\tuint32_t all:1;\n+};\n+\n /**\n * A structure used to configure an Ethernet port.\n * Depending upon the RX multi-queue mode, extra advanced\n@@ -1236,6 +1246,8 @@ struct rte_eth_conf {\n \tuint32_t dcb_capability_en;\n \tstruct rte_fdir_conf fdir_conf; /**< FDIR configuration. DEPRECATED */\n \tstruct rte_intr_conf intr_conf; /**< Interrupt mode configuration. */\n+\tstruct rte_rx_err_pkt_drop_conf err_pkt_drop_conf;\n+\t/**< RX error packet drop configuration. */\n };\n \n /**\n@@ -1260,6 +1272,7 @@ struct rte_eth_conf {\n #define DEV_RX_OFFLOAD_SCTP_CKSUM\t0x00020000\n #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000\n #define DEV_RX_OFFLOAD_RSS_HASH\t\t0x00080000\n+#define DEV_RX_OFFLOAD_ERR_PKT_DROP\t0x00100000\n \n #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \\\n \t\t\t\t DEV_RX_OFFLOAD_UDP_CKSUM | \\\n@@ -1274,6 +1287,13 @@ struct rte_eth_conf {\n * mentioned in rte_rx_offload_names in rte_ethdev.c file.\n */\n \n+/**\n+ * RX Error Drop offload config/capabilities of a device. These\n+ * are valid only when RX capability DEV_RX_OFFLOAD_ERR_PKT_DROP\n+ * is supported by the device.\n+ */\n+#define DEV_RX_ERR_PKT_DROP_OFFLOAD_ALL\t\t0x00000001\n+\n /**\n * TX offload capabilities of a device.\n */\n@@ -1411,6 +1431,8 @@ struct rte_eth_dev_info {\n \t/**< Device per-queue RX offload capabilities. */\n \tuint64_t tx_queue_offload_capa;\n \t/**< Device per-queue TX offload capabilities. */\n+\tuint64_t rx_err_drop_offload_capa;\n+\t/**< RX error packet drop offload capabilities. */\n \tuint16_t reta_size;\n \t/**< Device redirection table size, the total number of entries. */\n \tuint8_t hash_key_size; /**< Hash key size in bytes */\n", "prefixes": [ "1/3", "v3" ] }